Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641991 > unrolled thread

[PATCH] scripts: check.c fix compile error

Back to article view | Back to linux.kernel

Contents

  [PATCH] scripts: check.c fix compile error Shuah Khan <shuahkh@osg.samsung.com> - 2017-05-15 21:20 +0200
    Re: [PATCH] scripts: check.c fix compile error Rob Herring <robh+dt@kernel.org> - 2017-05-16 15:00 +0200
      Re: [PATCH] scripts: check.c fix compile error Shuah Khan <shuahkh@osg.samsung.com> - 2017-05-16 17:50 +0200
        Re: [PATCH] scripts: check.c fix compile error Rob Herring <robh+dt@kernel.org> - 2017-05-17 18:50 +0200

#1641991 — [PATCH] scripts: check.c fix compile error

Fix the following compile error:

checks.c: In function ‘check_simple_bus_reg’:
checks.c:876:41: error: format ‘%lx’ expects argument of type
‘long unsigned int’, but argument 4 has type ‘uint64_t {aka
long long unsigned int}’ [-Werror=format=]
  snprintf(unit_addr, sizeof(unit_addr), "%lx", reg);
                                         ^
checks.c:876:41: error: format ‘%lx’ expects argument of type
‘long unsigned int’, but argument 4 has type ‘uint64_t
{aka long long unsigned int}’ [-Werror=format=]
cc1: all warnings being treated as errors
Makefile:304: recipe for target 'checks.o' failed
make: *** [checks.o] Error 1

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 scripts/dtc/checks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/dtc/checks.c b/scripts/dtc/checks.c
index 5adfc8f..6dfb82f 100644
--- a/scripts/dtc/checks.c
+++ b/scripts/dtc/checks.c
@@ -873,7 +873,7 @@ static void check_simple_bus_reg(struct check *c, struct dt_info *dti, struct no
 	while (size--)
 		reg = (reg << 32) | fdt32_to_cpu(*(cells++));
 
-	snprintf(unit_addr, sizeof(unit_addr), "%lx", reg);
+	snprintf(unit_addr, sizeof(unit_addr), "%llx", reg);
 	if (!streq(unitname, unit_addr))
 		FAIL(c, dti, "Node %s simple-bus unit address format error, expected \"%s\"",
 		     node->fullpath, unit_addr);
-- 
2.7.4

[toc] | [next] | [standalone]

#1642549

On Mon, May 15, 2017 at 2:10 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> Fix the following compile error:

On what host? 32-bit I guess.

I'll take this, but can you also send this to upstream dtc and
devicetree-compiler list. Normally, dtc is just an import.

>
> checks.c: In function ‘check_simple_bus_reg’:
> checks.c:876:41: error: format ‘%lx’ expects argument of type
> ‘long unsigned int’, but argument 4 has type ‘uint64_t {aka
> long long unsigned int}’ [-Werror=format=]
>   snprintf(unit_addr, sizeof(unit_addr), "%lx", reg);
>                                          ^
> checks.c:876:41: error: format ‘%lx’ expects argument of type
> ‘long unsigned int’, but argument 4 has type ‘uint64_t
> {aka long long unsigned int}’ [-Werror=format=]
> cc1: all warnings being treated as errors
> Makefile:304: recipe for target 'checks.o' failed
> make: *** [checks.o] Error 1
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>  scripts/dtc/checks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/dtc/checks.c b/scripts/dtc/checks.c
> index 5adfc8f..6dfb82f 100644
> --- a/scripts/dtc/checks.c
> +++ b/scripts/dtc/checks.c
> @@ -873,7 +873,7 @@ static void check_simple_bus_reg(struct check *c, struct dt_info *dti, struct no
>         while (size--)
>                 reg = (reg << 32) | fdt32_to_cpu(*(cells++));
>
> -       snprintf(unit_addr, sizeof(unit_addr), "%lx", reg);
> +       snprintf(unit_addr, sizeof(unit_addr), "%llx", reg);
>         if (!streq(unitname, unit_addr))
>                 FAIL(c, dti, "Node %s simple-bus unit address format error, expected \"%s\"",
>                      node->fullpath, unit_addr);
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1642620

On 05/16/2017 06:52 AM, Rob Herring wrote:
> On Mon, May 15, 2017 at 2:10 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>> Fix the following compile error:
> 
> On what host? 32-bit I guess.

Saw this on Odroid-xu4.

> 
> I'll take this, but can you also send this to upstream dtc and
> devicetree-compiler list. Normally, dtc is just an import.

Yes. I found this on upstream dtc build last week and git the patch
ready to send. Then, I noticed that it showed up in 4.12-rc1 with the
dtc import. I have the patch ready to go for upstream dtc. Will send
it shortly.

thanks,
-- Shuah

[toc] | [prev] | [next] | [standalone]

#1643504

On Tue, May 16, 2017 at 10:39 AM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> On 05/16/2017 06:52 AM, Rob Herring wrote:
>> On Mon, May 15, 2017 at 2:10 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>> Fix the following compile error:
>>
>> On what host? 32-bit I guess.
>
> Saw this on Odroid-xu4.
>
>>
>> I'll take this, but can you also send this to upstream dtc and
>> devicetree-compiler list. Normally, dtc is just an import.
>
> Yes. I found this on upstream dtc build last week and git the patch
> ready to send. Then, I noticed that it showed up in 4.12-rc1 with the
> dtc import. I have the patch ready to go for upstream dtc. Will send
> it shortly.

I've cherry-picked the version from dtc and applied.

Rob

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web