Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1642212 > unrolled thread
| Started by | Sricharan R <sricharan@codeaurora.org> |
|---|---|
| First post | 2017-05-16 07:30 +0200 |
| Last post | 2017-05-17 07:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] iommu: of: Fix check for returning EPROBE_DEFER Sricharan R <sricharan@codeaurora.org> - 2017-05-16 07:30 +0200
Re: [PATCH] iommu: of: Fix check for returning EPROBE_DEFER Jonathan Neuschäfer <j.neuschaefer@gmx.net> - 2017-05-16 16:20 +0200
Re: [PATCH] iommu: of: Fix check for returning EPROBE_DEFER Sricharan R <sricharan@codeaurora.org> - 2017-05-17 07:20 +0200
| From | Sricharan R <sricharan@codeaurora.org> |
|---|---|
| Date | 2017-05-16 07:30 +0200 |
| Subject | [PATCH] iommu: of: Fix check for returning EPROBE_DEFER |
| Message-ID | <tHDdv-1qC-5@gated-at.bofh.it> |
While returning EPROBE_DEFER for iommu masters take in to account of iommu nodes that could be marked in DT as 'status=disabled', in which case simply return NULL and let the master's probe continue rather than deferring. Signed-off-by: Sricharan R <sricharan@codeaurora.org> Tested-by: Will Deacon <will.deacon@arm.com> Acked-by: Will Deacon <will.deacon@arm.com> --- drivers/iommu/of_iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c index 9f44ee8..e6e9bec 100644 --- a/drivers/iommu/of_iommu.c +++ b/drivers/iommu/of_iommu.c @@ -118,6 +118,7 @@ static bool of_iommu_driver_present(struct device_node *np) ops = iommu_ops_from_fwnode(fwnode); if ((ops && !ops->of_xlate) || + !of_device_is_available(iommu_spec->np) || (!ops && !of_iommu_driver_present(iommu_spec->np))) return NULL; -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
[toc] | [next] | [standalone]
| From | Jonathan Neuschäfer <j.neuschaefer@gmx.net> |
|---|---|
| Date | 2017-05-16 16:20 +0200 |
| Message-ID | <tHLup-6H1-7@gated-at.bofh.it> |
| In reply to | #1642212 |
Hi, I have a few suggestions on how to make this commit message more readable: On Tue, May 16, 2017 at 10:54:13AM +0530, Sricharan R wrote: > While returning EPROBE_DEFER for iommu masters Add a comma at the end of this line > take in to account of iommu nodes that could be s/in to/into/ s/of iommu/of_iommu/ > marked in DT as 'status=disabled', in which case > simply return NULL and let the master's probe > continue rather than deferring. > > Signed-off-by: Sricharan R <sricharan@codeaurora.org> > Tested-by: Will Deacon <will.deacon@arm.com> > Acked-by: Will Deacon <will.deacon@arm.com> Thanks, Jonathan Neuschäfer
[toc] | [prev] | [next] | [standalone]
| From | Sricharan R <sricharan@codeaurora.org> |
|---|---|
| Date | 2017-05-17 07:20 +0200 |
| Message-ID | <tHZxn-7lc-1@gated-at.bofh.it> |
| In reply to | #1642578 |
Hi, On 5/16/2017 7:39 PM, Jonathan Neuschäfer wrote: > Hi, I have a few suggestions on how to make this commit message more > readable: > > On Tue, May 16, 2017 at 10:54:13AM +0530, Sricharan R wrote: >> While returning EPROBE_DEFER for iommu masters > > Add a comma at the end of this line > >> take in to account of iommu nodes that could be > > s/in to/into/ > s/of iommu/of_iommu/ > ok, will correct the above. Regards, Sricharan >> marked in DT as 'status=disabled', in which case >> simply return NULL and let the master's probe >> continue rather than deferring. >> >> Signed-off-by: Sricharan R <sricharan@codeaurora.org> >> Tested-by: Will Deacon <will.deacon@arm.com> >> Acked-by: Will Deacon <will.deacon@arm.com> > > > Thanks, > Jonathan Neuschäfer > -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web