Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1642272 > unrolled thread

[PATCH] staging: fbtft: fix sparse warning

Started byJandy Gou <gouqingsong@goodix.com>
First post2017-05-16 09:50 +0200
Last post2017-05-16 10:10 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] staging: fbtft: fix sparse warning Jandy Gou <gouqingsong@goodix.com> - 2017-05-16 09:50 +0200
    [PATCH] fix the sparse warning: drivers/staging/fbtft/fbtft-io.c:74:29: warning: incorrect type in assignment (different base types) drivers/staging/fbtft/fbtft-io.c:74:29:    expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> drivers/staging/fbtft/fbtft-io.c:74:29:    got restricted __be64 [usertype] <noident> Jandy Gou <gouqingsong@goodix.com> - 2017-05-16 09:50 +0200
      Re: [PATCH] fix the sparse warning:  drivers/staging/fbtft/fbtft-io.c:74:29: warning: incorrect type in  assignment (different base types) drivers/staging/fbtft/fbtft-io.c:74:29:  expected unsigned long long [unsigned] [long] [long long] [usertype]  <noident> drivers/staging/fbtft/fbtft-io.c:74:29: got restricted __be64  [usertype] <noident> Greg KH <gregkh@linuxfoundation.org> - 2017-05-16 10:10 +0200

#1642272 — [PATCH] staging: fbtft: fix sparse warning

FromJandy Gou <gouqingsong@goodix.com>
Date2017-05-16 09:50 +0200
Subject[PATCH] staging: fbtft: fix sparse warning
Message-ID<tHFoZ-2Ho-3@gated-at.bofh.it>
fix the sparse warning:
  drivers/staging/fbtft/fbtft-io.c:74:29:
    warning: incorrect type in     assignment (different base types)    
    drivers/staging/fbtft/fbtft-io.c:74:29:    expected unsigned long
    long     [unsigned] [long] [long long] [usertype] <noident>    
    drivers/staging/fbtft/fbtft-io.c:74:29:    got restricted __be64    
    [usertype] <noident>

 drivers/staging/fbtft/fbtft-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

[toc] | [next] | [standalone]


#1642279 — [PATCH] fix the sparse warning: drivers/staging/fbtft/fbtft-io.c:74:29: warning: incorrect type in assignment (different base types) drivers/staging/fbtft/fbtft-io.c:74:29: expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> drivers/staging/fbtft/fbtft-io.c:74:29: got restricted __be64 [usertype] <noident>

FromJandy Gou <gouqingsong@goodix.com>
Date2017-05-16 09:50 +0200
Subject[PATCH] fix the sparse warning: drivers/staging/fbtft/fbtft-io.c:74:29: warning: incorrect type in assignment (different base types) drivers/staging/fbtft/fbtft-io.c:74:29: expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> drivers/staging/fbtft/fbtft-io.c:74:29: got restricted __be64 [usertype] <noident>
Message-ID<tHFp0-2Ho-25@gated-at.bofh.it>
In reply to#1642272
Signed-off-by: Jandy Gou <gouqingsong@goodix.com>
---
 drivers/staging/fbtft/fbtft-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
index d868405..ffb9a3b 100644
--- a/drivers/staging/fbtft/fbtft-io.c
+++ b/drivers/staging/fbtft/fbtft-io.c
@@ -71,7 +71,7 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len)
 			src++;
 		}
 		tmp |= ((*src & 0x0100) ? 1 : 0);
-		*(u64 *)dst = cpu_to_be64(tmp);
+		*(__be64 *)dst = cpu_to_be64(tmp);
 		dst += 8;
 		*dst++ = (u8)(*src++ & 0x00FF);
 		added++;
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]


#1642287 — Re: [PATCH] fix the sparse warning: drivers/staging/fbtft/fbtft-io.c:74:29: warning: incorrect type in assignment (different base types) drivers/staging/fbtft/fbtft-io.c:74:29: expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> drivers/staging/fbtft/fbtft-io.c:74:29: got restricted __be64 [usertype] <noident>

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-05-16 10:10 +0200
SubjectRe: [PATCH] fix the sparse warning: drivers/staging/fbtft/fbtft-io.c:74:29: warning: incorrect type in assignment (different base types) drivers/staging/fbtft/fbtft-io.c:74:29: expected unsigned long long [unsigned] [long] [long long] [usertype] <noident> drivers/staging/fbtft/fbtft-io.c:74:29: got restricted __be64 [usertype] <noident>
Message-ID<tHFIl-36E-5@gated-at.bofh.it>
In reply to#1642279
On Tue, May 16, 2017 at 03:42:27PM +0800, Jandy Gou wrote:
> Signed-off-by: Jandy Gou <gouqingsong@goodix.com>

Your subject is a bit messed up :(

Please fix and resend.

No need for the 0/1 email for just a single patch.

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web