Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1641184 > unrolled thread

[patch 04/18] x86/smp: Adjust system_state check

Started byThomas Gleixner <tglx@linutronix.de>
First post2017-05-14 20:50 +0200
Last post2017-05-15 16:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [patch 04/18] x86/smp: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
    Re: [patch 04/18] x86/smp: Adjust system_state check Steven Rostedt <rostedt@goodmis.org> - 2017-05-15 16:20 +0200

#1641184 — [patch 04/18] x86/smp: Adjust system_state check

FromThomas Gleixner <tglx@linutronix.de>
Date2017-05-14 20:50 +0200
Subject[patch 04/18] x86/smp: Adjust system_state check
Message-ID<tH6KB-5j9-7@gated-at.bofh.it>
To enable smp_processor_id() and might_sleep() debug checks earlier, it's
required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.

Adjust the system_state check in announce_cpu() to handle the extra states.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/x86/kernel/smpboot.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -863,7 +863,7 @@ static void announce_cpu(int cpu, int ap
 	if (cpu == 1)
 		printk(KERN_INFO "x86: Booting SMP configuration:\n");
 
-	if (system_state == SYSTEM_BOOTING) {
+	if (system_state < SYSTEM_RUNNING) {
 		if (node != current_node) {
 			if (current_node > (-1))
 				pr_cont("\n");

[toc] | [next] | [standalone]


#1641734

FromSteven Rostedt <rostedt@goodmis.org>
Date2017-05-15 16:20 +0200
Message-ID<tHp0S-O3-21@gated-at.bofh.it>
In reply to#1641184
On Sun, 14 May 2017 20:27:20 +0200
Thomas Gleixner <tglx@linutronix.de> wrote:

> To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
> 
> Adjust the system_state check in announce_cpu() to handle the extra states.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> ---
>  arch/x86/kernel/smpboot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -863,7 +863,7 @@ static void announce_cpu(int cpu, int ap
>  	if (cpu == 1)
>  		printk(KERN_INFO "x86: Booting SMP configuration:\n");
>  
> -	if (system_state == SYSTEM_BOOTING) {
> +	if (system_state < SYSTEM_RUNNING) {
>  		if (node != current_node) {
>  			if (current_node > (-1))
>  				pr_cont("\n");
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web