Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1641183 > unrolled thread

[patch 11/18] iommu/of: Adjust system_state check

Started byThomas Gleixner <tglx@linutronix.de>
First post2017-05-14 20:50 +0200
Last post2017-05-15 16:50 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [patch 11/18] iommu/of: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:50 +0200
    Re: [patch 11/18] iommu/of: Adjust system_state check Robin Murphy <robin.murphy@arm.com> - 2017-05-15 12:50 +0200
    Re: [patch 11/18] iommu/of: Adjust system_state check Joerg Roedel <joro@8bytes.org> - 2017-05-15 16:50 +0200

#1641183 — [patch 11/18] iommu/of: Adjust system_state check

FromThomas Gleixner <tglx@linutronix.de>
Date2017-05-14 20:50 +0200
Subject[patch 11/18] iommu/of: Adjust system_state check
Message-ID<tH6KB-5j9-1@gated-at.bofh.it>
To enable smp_processor_id() and might_sleep() debug checks earlier, it's
required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.

Adjust the system_state check in of_iommu_driver_present() to handle the
extra states.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org
---
 drivers/iommu/of_iommu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -103,7 +103,7 @@ static bool of_iommu_driver_present(stru
 	 * it never will be. We don't want to defer indefinitely, nor attempt
 	 * to dereference __iommu_of_table after it's been freed.
 	 */
-	if (system_state > SYSTEM_BOOTING)
+	if (system_state >= SYSTEM_RUNNING)
 		return false;
 
 	return of_match_node(&__iommu_of_table, np);

[toc] | [next] | [standalone]


#1641531

FromRobin Murphy <robin.murphy@arm.com>
Date2017-05-15 12:50 +0200
Message-ID<tHlJE-6Zt-11@gated-at.bofh.it>
In reply to#1641183
On 14/05/17 19:27, Thomas Gleixner wrote:
> To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
> 
> Adjust the system_state check in of_iommu_driver_present() to handle the
> extra states.

FWIW,

Acked-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: iommu@lists.linux-foundation.org
> ---
>  drivers/iommu/of_iommu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/iommu/of_iommu.c
> +++ b/drivers/iommu/of_iommu.c
> @@ -103,7 +103,7 @@ static bool of_iommu_driver_present(stru
>  	 * it never will be. We don't want to defer indefinitely, nor attempt
>  	 * to dereference __iommu_of_table after it's been freed.
>  	 */
> -	if (system_state > SYSTEM_BOOTING)
> +	if (system_state >= SYSTEM_RUNNING)
>  		return false;
>  
>  	return of_match_node(&__iommu_of_table, np);
> 

[toc] | [prev] | [next] | [standalone]


#1641770

FromJoerg Roedel <joro@8bytes.org>
Date2017-05-15 16:50 +0200
Message-ID<tHptU-XY-25@gated-at.bofh.it>
In reply to#1641183
On Sun, May 14, 2017 at 08:27:27PM +0200, Thomas Gleixner wrote:
> To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
> 
> Adjust the system_state check in of_iommu_driver_present() to handle the
> extra states.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: iommu@lists.linux-foundation.org

Acked-by: Joerg Roedel <jroedel@suse.de>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web