Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1640783 > unrolled thread

Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare  epoll target files Andrew Morton <akpm@linux-foundation.org> - 2017-05-13 00:10 +0200
    Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare  epoll target files Cyrill Gorcunov <gorcunov@gmail.com> - 2017-05-13 00:20 +0200

#1640783 — Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

On Mon, 24 Apr 2017 18:39:28 +0300 Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> With current epoll architecture target files are addressed
> with file_struct and file descriptor number, where the last
> is not unique. Moreover files can be transferred from another
> process via unix socket, added into queue and closed then
> so we won't find this descriptor in the task fdinfo list.
> 
> Thus to checkpoint and restore such processes CRIU needs to
> find out where exactly the target file is present to add it into
> epoll queue. For this sake one can use kcmp call where
> some particular target file from the queue is compared with
> arbitrary file passed as an argument.
> 
> Because epoll target files can have same file descriptor
> number but different file_struct a caller should explicitly
> specify the offset within.
> 
> To test if some particular file is matching entry inside
> epoll one have to
> 
>  - fill kcmp_epoll_slot structure with epoll file descriptor,
>    target file number and target file offset (in case if only
>    one target is present then it should be 0)
> 
>  - call kcmp as kcmp(pid1, pid2, KCMP_EPOLL_TFD, fd, &kcmp_epoll_slot)
>     - the kernel fetch file pointer matching file descriptor @fd of pid1
>     - lookups for file struct in epoll queue of pid2 and returns traditional
>       0,1,2 result for sorting purpose

That's quite a bit more code.  Is there a neat way of making it depend
on a new CONFIG_foo, then select CONFIG_foo if
CONFIG_CHECKPOINT_RESTORE?

[toc] | [next] | [standalone]

#1640788

On Fri, May 12, 2017 at 03:00:18PM -0700, Andrew Morton wrote:
> On Mon, 24 Apr 2017 18:39:28 +0300 Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> 
> That's quite a bit more code.  Is there a neat way of making it depend
> on a new CONFIG_foo, then select CONFIG_foo if
> CONFIG_CHECKPOINT_RESTORE?

Sure, will do on top and send. Thank you!

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web