Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1640769 > unrolled thread
| Started by | Alexey Khoroshilov <khoroshilov@ispras.ru> |
|---|---|
| First post | 2017-05-12 23:40 +0200 |
| Last post | 2017-05-13 13:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] serial: altera_jtaguart: adding iounmap() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-05-12 23:40 +0200
Re: [PATCH] serial: altera_jtaguart: adding iounmap() Tobias Klauser <tklauser@distanz.ch> - 2017-05-13 13:10 +0200
| From | Alexey Khoroshilov <khoroshilov@ispras.ru> |
|---|---|
| Date | 2017-05-12 23:40 +0200 |
| Subject | [PATCH] serial: altera_jtaguart: adding iounmap() |
| Message-ID | <tGqs1-2k3-3@gated-at.bofh.it> |
The driver does ioremap(port->mapbase, ALTERA_JTAGUART_SIZE), but there is no any iounmap(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> --- drivers/tty/serial/altera_jtaguart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c index 18e3f8342b85..0475f5d261ce 100644 --- a/drivers/tty/serial/altera_jtaguart.c +++ b/drivers/tty/serial/altera_jtaguart.c @@ -478,6 +478,7 @@ static int altera_jtaguart_remove(struct platform_device *pdev) port = &altera_jtaguart_ports[i].port; uart_remove_one_port(&altera_jtaguart_driver, port); + iounmap(port->membase); return 0; } -- 2.7.4
[toc] | [next] | [standalone]
| From | Tobias Klauser <tklauser@distanz.ch> |
|---|---|
| Date | 2017-05-13 13:10 +0200 |
| Message-ID | <tGD5U-2RD-5@gated-at.bofh.it> |
| In reply to | #1640769 |
On 2017-05-12 at 23:36:22 +0200, Alexey Khoroshilov <khoroshilov@ispras.ru> wrote: > The driver does ioremap(port->mapbase, ALTERA_JTAGUART_SIZE), > but there is no any iounmap(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Acked-by: Tobias Klauser <tklauser@distanz.ch> Thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web