Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1640702 > unrolled thread

[PATCH net-next,v2] tools: hv: Add clean up for included files in Ubuntu net config

Started byHaiyang Zhang <haiyangz@exchange.microsoft.com>
First post2017-05-12 21:20 +0200
Last post2017-05-16 18:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH net-next,v2] tools: hv: Add clean up for included files in Ubuntu net config Haiyang Zhang <haiyangz@exchange.microsoft.com> - 2017-05-12 21:20 +0200
    Re: [PATCH net-next,v2] tools: hv: Add clean up for included files  in Ubuntu net config David Miller <davem@davemloft.net> - 2017-05-16 18:00 +0200

#1640702 — [PATCH net-next,v2] tools: hv: Add clean up for included files in Ubuntu net config

FromHaiyang Zhang <haiyangz@exchange.microsoft.com>
Date2017-05-12 21:20 +0200
Subject[PATCH net-next,v2] tools: hv: Add clean up for included files in Ubuntu net config
Message-ID<tGogx-Kn-1@gated-at.bofh.it>
From: Haiyang Zhang <haiyangz@microsoft.com>

The clean up function is updated to cover duplicate config info in
files included by "source" key word in Ubuntu network config.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
 tools/hv/bondvf.sh |   21 ++++++++++++++++++---
 1 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/tools/hv/bondvf.sh b/tools/hv/bondvf.sh
index d85968c..112deba 100755
--- a/tools/hv/bondvf.sh
+++ b/tools/hv/bondvf.sh
@@ -102,15 +102,30 @@ function create_bond_cfg_redhat {
 }
 
 function del_eth_cfg_ubuntu {
-	local fn=$cfgdir/interfaces
+	local mainfn=$cfgdir/interfaces
+	local fnlist=( $mainfn )
+
+	local dirlist=(`awk '/^[ \t]*source/{print $2}' $mainfn`)
+
+	local i
+	for i in "${dirlist[@]}"
+	do
+		fnlist+=(`ls $i 2>/dev/null`)
+	done
+
 	local tmpfl=$(mktemp)
 
 	local nic_start='^[ \t]*(auto|iface|mapping|allow-.*)[ \t]+'$1
 	local nic_end='^[ \t]*(auto|iface|mapping|allow-.*|source)'
 
-	awk "/$nic_end/{x=0} x{next} /$nic_start/{x=1;next} 1"  $fn >$tmpfl
+	local fn
+	for fn in "${fnlist[@]}"
+	do
+		awk "/$nic_end/{x=0} x{next} /$nic_start/{x=1;next} 1" \
+			$fn >$tmpfl
 
-	cp $tmpfl $fn
+		cp $tmpfl $fn
+	done
 
 	rm $tmpfl
 }
-- 
1.7.1

[toc] | [next] | [standalone]


#1642628 — Re: [PATCH net-next,v2] tools: hv: Add clean up for included files in Ubuntu net config

FromDavid Miller <davem@davemloft.net>
Date2017-05-16 18:00 +0200
SubjectRe: [PATCH net-next,v2] tools: hv: Add clean up for included files in Ubuntu net config
Message-ID<tHN3b-7uo-9@gated-at.bofh.it>
In reply to#1640702
From: Haiyang Zhang <haiyangz@exchange.microsoft.com>
Date: Fri, 12 May 2017 12:14:11 -0700

> From: Haiyang Zhang <haiyangz@microsoft.com>
> 
> The clean up function is updated to cover duplicate config info in
> files included by "source" key word in Ubuntu network config.
> 
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>

Applied.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web