Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1640384 > unrolled thread

Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

Started byJohan Hovold <johan@kernel.org>
First post2017-05-12 12:40 +0200
Last post2017-05-14 15:30 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe Johan Hovold <johan@kernel.org> - 2017-05-12 12:40 +0200
    Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe Guenter Roeck <linux@roeck-us.net> - 2017-05-12 19:00 +0200
      Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe Wim Van Sebroeck <wim@iguana.be> - 2017-05-14 15:10 +0200
        Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe Wim Van Sebroeck <wim@iguana.be> - 2017-05-14 15:30 +0200

#1640384 — Re: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe

FromJohan Hovold <johan@kernel.org>
Date2017-05-12 12:40 +0200
SubjectRe: [PATCH] watchdog: pcwd_usb: fix NULL-deref at probe
Message-ID<tGg9j-36j-1@gated-at.bofh.it>
Hi Guenter and Wim,

On Mon, Apr 03, 2017 at 07:05:46AM -0700, Guenter Roeck wrote:
> On 04/03/2017 01:36 AM, Johan Hovold wrote:
> > On Mon, Mar 13, 2017 at 10:16:33AM -0700, Guenter Roeck wrote:
> >> On Mon, Mar 13, 2017 at 01:49:45PM +0100, Johan Hovold wrote:
> >>> Make sure to check the number of endpoints to avoid dereferencing a
> >>> NULL-pointer should a malicious device lack endpoints.
> >>>
> >>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> >>> Cc: stable <stable@vger.kernel.org>
> >>> Signed-off-by: Johan Hovold <johan@kernel.org>
> >>
> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >
> > Any progress on this one? I noticed you merged it to both the fixes and
> > next branches in your staging tree, Guenter (but it does not show up in
> > linux-next). Will you be sending it on to Linus?

> my watchdog staging trees are inofficial and not in linux-next.
> Wim is working on setting up a new server which will provide the
> official staging tree.
> 
> I asked Wim to push the pending patches. I'll do it if he asks me.

I noticed Guenter's watchdog branch is now in next, but the patches for
4.12 are still not in mainline. Have you guys decided who will be
sending them on to Linus this cycle?

Thanks,
Johan

[toc] | [next] | [standalone]


#1640603

FromGuenter Roeck <linux@roeck-us.net>
Date2017-05-12 19:00 +0200
Message-ID<tGm54-7o1-19@gated-at.bofh.it>
In reply to#1640384
On Fri, May 12, 2017 at 12:36:27PM +0200, Johan Hovold wrote:
> Hi Guenter and Wim,
> 
> On Mon, Apr 03, 2017 at 07:05:46AM -0700, Guenter Roeck wrote:
> > On 04/03/2017 01:36 AM, Johan Hovold wrote:
> > > On Mon, Mar 13, 2017 at 10:16:33AM -0700, Guenter Roeck wrote:
> > >> On Mon, Mar 13, 2017 at 01:49:45PM +0100, Johan Hovold wrote:
> > >>> Make sure to check the number of endpoints to avoid dereferencing a
> > >>> NULL-pointer should a malicious device lack endpoints.
> > >>>
> > >>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > >>> Cc: stable <stable@vger.kernel.org>
> > >>> Signed-off-by: Johan Hovold <johan@kernel.org>
> > >>
> > >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > >
> > > Any progress on this one? I noticed you merged it to both the fixes and
> > > next branches in your staging tree, Guenter (but it does not show up in
> > > linux-next). Will you be sending it on to Linus?
> 
> > my watchdog staging trees are inofficial and not in linux-next.
> > Wim is working on setting up a new server which will provide the
> > official staging tree.
> > 
> > I asked Wim to push the pending patches. I'll do it if he asks me.
> 
> I noticed Guenter's watchdog branch is now in next, but the patches for
> 4.12 are still not in mainline. Have you guys decided who will be
> sending them on to Linus this cycle?
> 
Good question. I had expected Wim to do it, since it is actually his
repository which is in linux-next. But you are correct, it isn't upstream.

Wim ?

Thanks,
Guenter

[toc] | [prev] | [next] | [standalone]


#1641082

FromWim Van Sebroeck <wim@iguana.be>
Date2017-05-14 15:10 +0200
Message-ID<tH1rz-1YE-1@gated-at.bofh.it>
In reply to#1640603
All,

> On Fri, May 12, 2017 at 12:36:27PM +0200, Johan Hovold wrote:
> > Hi Guenter and Wim,
> > 
> > On Mon, Apr 03, 2017 at 07:05:46AM -0700, Guenter Roeck wrote:
> > > On 04/03/2017 01:36 AM, Johan Hovold wrote:
> > > > On Mon, Mar 13, 2017 at 10:16:33AM -0700, Guenter Roeck wrote:
> > > >> On Mon, Mar 13, 2017 at 01:49:45PM +0100, Johan Hovold wrote:
> > > >>> Make sure to check the number of endpoints to avoid dereferencing a
> > > >>> NULL-pointer should a malicious device lack endpoints.
> > > >>>
> > > >>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > > >>> Cc: stable <stable@vger.kernel.org>
> > > >>> Signed-off-by: Johan Hovold <johan@kernel.org>
> > > >>
> > > >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > >
> > > > Any progress on this one? I noticed you merged it to both the fixes and
> > > > next branches in your staging tree, Guenter (but it does not show up in
> > > > linux-next). Will you be sending it on to Linus?
> > 
> > > my watchdog staging trees are inofficial and not in linux-next.
> > > Wim is working on setting up a new server which will provide the
> > > official staging tree.
> > > 
> > > I asked Wim to push the pending patches. I'll do it if he asks me.
> > 
> > I noticed Guenter's watchdog branch is now in next, but the patches for
> > 4.12 are still not in mainline. Have you guys decided who will be
> > sending them on to Linus this cycle?
> > 
> Good question. I had expected Wim to do it, since it is actually his
> repository which is in linux-next. But you are correct, it isn't upstream.

Due to some issues, we (Linus, Guenter and myself) decided that Guenter will sent the pull request this time (which he allready did).

Kind regards,
Wim.

[toc] | [prev] | [next] | [standalone]


#1641086

FromWim Van Sebroeck <wim@iguana.be>
Date2017-05-14 15:30 +0200
Message-ID<tH1KW-26q-3@gated-at.bofh.it>
In reply to#1641082
All,

> > On Fri, May 12, 2017 at 12:36:27PM +0200, Johan Hovold wrote:
> > > Hi Guenter and Wim,
> > > 
> > > On Mon, Apr 03, 2017 at 07:05:46AM -0700, Guenter Roeck wrote:
> > > > On 04/03/2017 01:36 AM, Johan Hovold wrote:
> > > > > On Mon, Mar 13, 2017 at 10:16:33AM -0700, Guenter Roeck wrote:
> > > > >> On Mon, Mar 13, 2017 at 01:49:45PM +0100, Johan Hovold wrote:
> > > > >>> Make sure to check the number of endpoints to avoid dereferencing a
> > > > >>> NULL-pointer should a malicious device lack endpoints.
> > > > >>>
> > > > >>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > > > >>> Cc: stable <stable@vger.kernel.org>
> > > > >>> Signed-off-by: Johan Hovold <johan@kernel.org>
> > > > >>
> > > > >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > > >
> > > > > Any progress on this one? I noticed you merged it to both the fixes and
> > > > > next branches in your staging tree, Guenter (but it does not show up in
> > > > > linux-next). Will you be sending it on to Linus?
> > > 
> > > > my watchdog staging trees are inofficial and not in linux-next.
> > > > Wim is working on setting up a new server which will provide the
> > > > official staging tree.
> > > > 
> > > > I asked Wim to push the pending patches. I'll do it if he asks me.
> > > 
> > > I noticed Guenter's watchdog branch is now in next, but the patches for
> > > 4.12 are still not in mainline. Have you guys decided who will be
> > > sending them on to Linus this cycle?
> > > 
> > Good question. I had expected Wim to do it, since it is actually his
> > repository which is in linux-next. But you are correct, it isn't upstream.
> 
> Due to some issues, we (Linus, Guenter and myself) decided that Guenter will sent the pull request this time (which he allready did).

OK, we were to late. We will line up the fixes for rc2. Feature changes and new drivers will be for next merge window.
My apologies to the people that have sent in these changes and drivers.

Kind regards,
Wim.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web