Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1637066 > unrolled thread
| Started by | Pavel Machek <pavel@ucw.cz> |
|---|---|
| First post | 2017-05-08 00:10 +0200 |
| Last post | 2017-05-12 19:30 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/1] thinkpad_acpi: Add support for status (external cover) LED Pavel Machek <pavel@ucw.cz> - 2017-05-08 00:10 +0200
Re: [PATCH 1/1] thinkpad_acpi: Add support for status (external cover) LED Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-08 02:00 +0200
Re: [PATCH 1/1] thinkpad_acpi: Add support for status (external cover) LED Pavel Machek <pavel@ucw.cz> - 2017-05-12 12:50 +0200
Re: [ibm-acpi-devel] [PATCH 1/1] thinkpad_acpi: Add support for status (external cover) LED Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-05-12 19:30 +0200
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2017-05-08 00:10 +0200 |
| Subject | Re: [PATCH 1/1] thinkpad_acpi: Add support for status (external cover) LED |
| Message-ID | <tECxk-3oj-15@gated-at.bofh.it> |
On Thu 2017-01-19 12:21:32, Adam Goode wrote:
> This allows the control of the red status LED, which is the dot of the "i"
> in the word "ThinkPad" on the outside cover of newer models.
>
> In the manual, both this LED and the power LED are referred to as
> the "system-status indicators" without distinction between the two, so
> I chose "status" as the LED name.
Could we name it something like external_status or something? "status" is way too generic.
Pavel
>
> Signed-off-by: Adam Goode <agoode@google.com>
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index cacb43fb1df7..6577bf8e5635 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -5611,11 +5611,11 @@ static const char * const tpacpi_led_names[TPACPI_LED_NUMLEDS] = {
> "tpacpi::standby",
> "tpacpi::dock_status1",
> "tpacpi::dock_status2",
> - "tpacpi::unknown_led2",
> + "tpacpi::status",
> "tpacpi::unknown_led3",
> "tpacpi::thinkvantage",
> };
> -#define TPACPI_SAFE_LEDS 0x1081U
> +#define TPACPI_SAFE_LEDS 0x1481U
>
> static inline bool tpacpi_is_led_restricted(const unsigned int led)
> {
> --
> 2.11.0.390.gc69c2f50cf-goog
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[toc] | [next] | [standalone]
| From | Henrique de Moraes Holschuh <hmh@hmh.eng.br> |
|---|---|
| Date | 2017-05-08 02:00 +0200 |
| Message-ID | <tEEfL-4rL-1@gated-at.bofh.it> |
| In reply to | #1637066 |
On Sun, 07 May 2017, Pavel Machek wrote: > On Thu 2017-01-19 12:21:32, Adam Goode wrote: > > This allows the control of the red status LED, which is the dot of the "i" > > in the word "ThinkPad" on the outside cover of newer models. > > > > In the manual, both this LED and the power LED are referred to as > > the "system-status indicators" without distinction between the two, so > > I chose "status" as the LED name. > > Could we name it something like external_status or something? "status" is way too generic. "thinkdot" ;-) -- Henrique Holschuh
[toc] | [prev] | [next] | [standalone]
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2017-05-12 12:50 +0200 |
| Message-ID | <tGgiZ-3aJ-11@gated-at.bofh.it> |
| In reply to | #1637167 |
[Multipart message — attachments visible in raw view] — view raw
On Sun 2017-05-07 20:49:03, Henrique de Moraes Holschuh wrote: > On Sun, 07 May 2017, Pavel Machek wrote: > > On Thu 2017-01-19 12:21:32, Adam Goode wrote: > > > This allows the control of the red status LED, which is the dot of the "i" > > > in the word "ThinkPad" on the outside cover of newer models. > > > > > > In the manual, both this LED and the power LED are referred to as > > > the "system-status indicators" without distinction between the two, so > > > I chose "status" as the LED name. > > > > Could we name it something like external_status or something? "status" is way too generic. > > "thinkdot" ;-) Sounds good to me ;-). -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[toc] | [prev] | [next] | [standalone]
| From | Henrique de Moraes Holschuh <hmh@hmh.eng.br> |
|---|---|
| Date | 2017-05-12 19:30 +0200 |
| Subject | Re: [ibm-acpi-devel] [PATCH 1/1] thinkpad_acpi: Add support for status (external cover) LED |
| Message-ID | <tGmy6-7Uc-31@gated-at.bofh.it> |
| In reply to | #1640389 |
On Fri, 12 May 2017, Pavel Machek wrote: > On Sun 2017-05-07 20:49:03, Henrique de Moraes Holschuh wrote: > > On Sun, 07 May 2017, Pavel Machek wrote: > > > On Thu 2017-01-19 12:21:32, Adam Goode wrote: > > > > This allows the control of the red status LED, which is the dot of the "i" > > > > in the word "ThinkPad" on the outside cover of newer models. > > > > > > > > In the manual, both this LED and the power LED are referred to as > > > > the "system-status indicators" without distinction between the two, so > > > > I chose "status" as the LED name. > > > > > > Could we name it something like external_status or something? "status" is way too generic. > > > > "thinkdot" ;-) > > Sounds good to me ;-). Ok. Adam, care to respin this when you have the time? -- Henrique Holschuh
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web