Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1639207 > unrolled thread
| Started by | Vivek Gautam <vivek.gautam@codeaurora.org> |
|---|---|
| First post | 2017-05-11 08:50 +0200 |
| Last post | 2017-05-17 05:50 +0200 |
| Articles | 6 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v5 1/3] phy: qcom-usb: Remove unused ulpi phy header Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-05-11 08:50 +0200
Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-12 10:50 +0200
Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-05-12 11:40 +0200
Re: [PATCH v5 1/3] phy: qcom-usb: Remove unused ulpi phy header Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-16 12:10 +0200
Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-16 12:20 +0200
Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-05-17 05:50 +0200
| From | Vivek Gautam <vivek.gautam@codeaurora.org> |
|---|---|
| Date | 2017-05-11 08:50 +0200 |
| Subject | [PATCH v5 1/3] phy: qcom-usb: Remove unused ulpi phy header |
| Message-ID | <tFQ5c-2S2-3@gated-at.bofh.it> |
Ulpi phy header is not used for anything. Remove the same from qcom-hs and qcom-hsic phy drivers. Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> Suggested-by: Stephen Boyd <stephen.boyd@linaro.org> Cc: Kishon Vijay Abraham I <kishon@ti.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-usb@vger.kernel.org --- Changes since v4: - None. Changes since v3: - New patch added in the series. Removing headers as per Stephen's suggestion. drivers/phy/phy-qcom-usb-hs.c | 2 -- drivers/phy/phy-qcom-usb-hsic.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/phy/phy-qcom-usb-hs.c b/drivers/phy/phy-qcom-usb-hs.c index 94dfbfd739c3..43704f4f23e9 100644 --- a/drivers/phy/phy-qcom-usb-hs.c +++ b/drivers/phy/phy-qcom-usb-hs.c @@ -15,8 +15,6 @@ #include <linux/extcon.h> #include <linux/notifier.h> -#include "ulpi_phy.h" - #define ULPI_PWR_CLK_MNG_REG 0x88 # define ULPI_PWR_OTG_COMP_DISABLE BIT(0) diff --git a/drivers/phy/phy-qcom-usb-hsic.c b/drivers/phy/phy-qcom-usb-hsic.c index 47690f9945b9..6dcaf04fa367 100644 --- a/drivers/phy/phy-qcom-usb-hsic.c +++ b/drivers/phy/phy-qcom-usb-hsic.c @@ -13,8 +13,6 @@ #include <linux/delay.h> #include <linux/clk.h> -#include "ulpi_phy.h" - #define ULPI_HSIC_CFG 0x30 #define ULPI_HSIC_IO_CAL 0x33 -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [next] | [standalone]
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Date | 2017-05-12 10:50 +0200 |
| Subject | Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers |
| Message-ID | <tGeqS-1Rw-15@gated-at.bofh.it> |
| In reply to | #1639207 |
Hi Vivek, On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: > Adding vendor specific directories in phy to group > phy drivers under their respective vendor umbrella. > > Also updated the MAINTAINERS file to reflect the correct > directory structure for phy drivers. > > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > Acked-by: Heiko Stuebner <heiko@sntech.de> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Jaehoon Chung <jh80.chung@samsung.com> > Cc: Stephen Boyd <stephen.boyd@linaro.org> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-usb@vger.kernel.org > --- > > Changes since v4: > - Reprepared the patch based on latest torvalds/master. > - Added new directory for amlogic, since there's a new patch [1] > coming in for amlogic platforms. I don't prefer placeholder directories but this is not a placeholder directory since phy-meson8b-usb2.c is already added in amlogic. Btw, thank you for sending this patch. Will queue this once -rc1 is tagged. Cheers Kishon
[toc] | [prev] | [next] | [standalone]
| From | Vivek Gautam <vivek.gautam@codeaurora.org> |
|---|---|
| Date | 2017-05-12 11:40 +0200 |
| Subject | Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers |
| Message-ID | <tGfdg-2rg-17@gated-at.bofh.it> |
| In reply to | #1640321 |
On 05/12/2017 02:15 PM, Kishon Vijay Abraham I wrote: > Hi Vivek, > > On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: >> Adding vendor specific directories in phy to group >> phy drivers under their respective vendor umbrella. >> >> Also updated the MAINTAINERS file to reflect the correct >> directory structure for phy drivers. >> >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> Acked-by: Heiko Stuebner <heiko@sntech.de> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> >> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> >> Cc: Kishon Vijay Abraham I <kishon@ti.com> >> Cc: David S. Miller <davem@davemloft.net> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Cc: Guenter Roeck <linux@roeck-us.net> >> Cc: Heiko Stuebner <heiko@sntech.de> >> Cc: Viresh Kumar <viresh.kumar@linaro.org> >> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> >> Cc: Chen-Yu Tsai <wens@csie.org> >> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> >> Cc: Krzysztof Kozlowski <krzk@kernel.org> >> Cc: Jaehoon Chung <jh80.chung@samsung.com> >> Cc: Stephen Boyd <stephen.boyd@linaro.org> >> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-arm-msm@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-omap@vger.kernel.org >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: linux-rockchip@lists.infradead.org >> Cc: linux-samsung-soc@vger.kernel.org >> Cc: linux-usb@vger.kernel.org >> --- >> >> Changes since v4: >> - Reprepared the patch based on latest torvalds/master. >> - Added new directory for amlogic, since there's a new patch [1] >> coming in for amlogic platforms. > I don't prefer placeholder directories but this is not a placeholder directory > since phy-meson8b-usb2.c is already added in amlogic. Right, since phy-meson8b-usb2.c was already there and phy-meson-gxl-usb2.c is also coming, i decided to add this directory. > Btw, thank you for sending this patch. Will queue this once -rc1 is tagged. Cool. Thanks Kishon. Regards Vivek > > Cheers > Kishon > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [prev] | [next] | [standalone]
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Date | 2017-05-16 12:10 +0200 |
| Message-ID | <tHHAt-4eO-13@gated-at.bofh.it> |
| In reply to | #1639207 |
Hi Vivek, On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: > Ulpi phy header is not used for anything. Remove the same > from qcom-hs and qcom-hsic phy drivers. > > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > Suggested-by: Stephen Boyd <stephen.boyd@linaro.org> > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-usb@vger.kernel.org this patch introduced a bunch of compiler errors because of missing "#include <linux/phy/phy.h>". I fixed it and merged to linux-phy fixes. Thanks Kishon
[toc] | [prev] | [next] | [standalone]
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Date | 2017-05-16 12:20 +0200 |
| Subject | Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers |
| Message-ID | <tHHKb-4hW-29@gated-at.bofh.it> |
| In reply to | #1639207 |
Hi Vivek, On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: > Adding vendor specific directories in phy to group > phy drivers under their respective vendor umbrella. > > Also updated the MAINTAINERS file to reflect the correct > directory structure for phy drivers. > > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > Acked-by: Heiko Stuebner <heiko@sntech.de> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> > Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Maxime Ripard <maxime.ripard@free-electrons.com> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Jaehoon Chung <jh80.chung@samsung.com> > Cc: Stephen Boyd <stephen.boyd@linaro.org> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-usb@vger.kernel.org > --- > > Changes since v4: > - Reprepared the patch based on latest torvalds/master. > - Added new directory for amlogic, since there's a new patch [1] > coming in for amlogic platforms. > > Changes since v3: > - Added 'Acked-by' and 'Reviewed by' tags received for this patch. > - No functional change. > > Changes since v2: > - Rebased on linux-phy/next. > - Took care of drivers added/removed for each vendors since v2. > - Updated the 'Signed-off-by' tag with my current email id. > > Changes from v1: > - Updated the MAINTAINERS file to reflect the same change > in directory structure. > - Removed PHY_PLAT config as pointed out by Kishon. > So we don't require the second patch in the v1 of this series: > [PATCH 2/2] arm: mach-spear: Enable PHY_PLAT to meet dependency > - Renamed sunxi --> allwinner; rcar --> renesas. > - Fixed error coming with qcom Makefile. > > * Build tested multi_v7_defconfig. > * Build tested arm64 defconfig with all the involved configs enabled. > > [1] https://patchwork.kernel.org/patch/9684303/ > . . <snip> . . > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index afaf7b643eeb..b353ac603ea0 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -15,73 +15,6 @@ config GENERIC_PHY > phy users can obtain reference to the PHY. All the users of this . . <snip> . . > - > +menu "Platform Phy drivers" I don't think creating a new menu is required. I removed it and merged into linux-phy. Thanks Kishon
[toc] | [prev] | [next] | [standalone]
| From | Vivek Gautam <vivek.gautam@codeaurora.org> |
|---|---|
| Date | 2017-05-17 05:50 +0200 |
| Subject | Re: [PATCH v5 3/3] phy: Group vendor specific phy drivers |
| Message-ID | <tHY8h-6fJ-7@gated-at.bofh.it> |
| In reply to | #1642391 |
On 05/16/2017 03:40 PM, Kishon Vijay Abraham I wrote: > Hi Vivek, > > On Thursday 11 May 2017 12:17 PM, Vivek Gautam wrote: >> Adding vendor specific directories in phy to group >> phy drivers under their respective vendor umbrella. >> >> Also updated the MAINTAINERS file to reflect the correct >> directory structure for phy drivers. >> >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> Acked-by: Heiko Stuebner <heiko@sntech.de> >> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> >> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> >> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> >> Cc: Kishon Vijay Abraham I <kishon@ti.com> >> Cc: David S. Miller <davem@davemloft.net> >> Cc: Geert Uytterhoeven <geert+renesas@glider.be> >> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> >> Cc: Guenter Roeck <linux@roeck-us.net> >> Cc: Heiko Stuebner <heiko@sntech.de> >> Cc: Viresh Kumar <viresh.kumar@linaro.org> >> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> >> Cc: Chen-Yu Tsai <wens@csie.org> >> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> >> Cc: Krzysztof Kozlowski <krzk@kernel.org> >> Cc: Jaehoon Chung <jh80.chung@samsung.com> >> Cc: Stephen Boyd <stephen.boyd@linaro.org> >> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-arm-msm@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-omap@vger.kernel.org >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: linux-rockchip@lists.infradead.org >> Cc: linux-samsung-soc@vger.kernel.org >> Cc: linux-usb@vger.kernel.org >> --- >> >> Changes since v4: >> - Reprepared the patch based on latest torvalds/master. >> - Added new directory for amlogic, since there's a new patch [1] >> coming in for amlogic platforms. >> >> Changes since v3: >> - Added 'Acked-by' and 'Reviewed by' tags received for this patch. >> - No functional change. >> >> Changes since v2: >> - Rebased on linux-phy/next. >> - Took care of drivers added/removed for each vendors since v2. >> - Updated the 'Signed-off-by' tag with my current email id. >> >> Changes from v1: >> - Updated the MAINTAINERS file to reflect the same change >> in directory structure. >> - Removed PHY_PLAT config as pointed out by Kishon. >> So we don't require the second patch in the v1 of this series: >> [PATCH 2/2] arm: mach-spear: Enable PHY_PLAT to meet dependency >> - Renamed sunxi --> allwinner; rcar --> renesas. >> - Fixed error coming with qcom Makefile. >> >> * Build tested multi_v7_defconfig. >> * Build tested arm64 defconfig with all the involved configs enabled. >> >> [1] https://patchwork.kernel.org/patch/9684303/ >> > . > . > <snip> > . > . >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index afaf7b643eeb..b353ac603ea0 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -15,73 +15,6 @@ config GENERIC_PHY >> phy users can obtain reference to the PHY. All the users of this > . > . > <snip> > . > . >> - >> +menu "Platform Phy drivers" > I don't think creating a new menu is required. I removed it and merged into > linux-phy. Right. No need for a new menu. Thank you for fixing it and pushing out. Best Regards Vivek > > Thanks > Kishon > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web