Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1638342 > unrolled thread

[PATCH] staging: ccree: remove trailing whitespace. switch spaces to tabs

Started byConnor Kelleher <connor.r.kelleher@gmail.com>
First post2017-05-09 20:50 +0200
Last post2017-05-12 21:20 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: ccree: remove trailing whitespace. switch spaces to tabs Connor Kelleher <connor.r.kelleher@gmail.com> - 2017-05-09 20:50 +0200
    Re: [PATCH] staging: ccree: remove trailing whitespace. switch  spaces to tabs Greg KH <gregkh@linuxfoundation.org> - 2017-05-12 11:10 +0200
      [PATCH v2 1/2] staging: ccree: switch spaces to tabs Connor Kelleher <connor.r.kelleher@gmail.com> - 2017-05-12 21:20 +0200
        [PATCH v2 2/2] staging: ccree: remove trailing whitespace Connor Kelleher <connor.r.kelleher@gmail.com> - 2017-05-12 21:20 +0200

#1638342 — [PATCH] staging: ccree: remove trailing whitespace. switch spaces to tabs

FromConnor Kelleher <connor.r.kelleher@gmail.com>
Date2017-05-09 20:50 +0200
Subject[PATCH] staging: ccree: remove trailing whitespace. switch spaces to tabs
Message-ID<tFimR-5AC-3@gated-at.bofh.it>
ssi_fips.c:

fixing checkpatch.pl errors:

ERROR: trailing whitespace
+ * $

ERROR: trailing whitespace
+ * $

ERROR: trailing whitespace
+ * $

ERROR: trailing whitespace
+This function returns the REE FIPS state.  $

ERROR: trailing whitespace
+It should be called by kernel module. $

ERROR: code indent should use tabs where possible
+        int rc = 0;$

ERROR: trailing whitespace
+This function returns the REE FIPS error.  $

ERROR: trailing whitespace
+It should be called by kernel module. $

ERROR: code indent should use tabs where possible
+        int rc = 0;$

Signed-off-by: Connor Kelleher <connor.r.kelleher@gmail.com>
---
 drivers/staging/ccree/ssi_fips.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/ccree/ssi_fips.c b/drivers/staging/ccree/ssi_fips.c
index 50f748511979..25ee23a1cecf 100644
--- a/drivers/staging/ccree/ssi_fips.c
+++ b/drivers/staging/ccree/ssi_fips.c
@@ -1,15 +1,15 @@
 /*
  * Copyright (C) 2012-2017 ARM Limited or its affiliates.
- * 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
@@ -27,12 +27,12 @@ extern int ssi_fips_ext_get_state(ssi_fips_state_t *p_state);
 extern int ssi_fips_ext_get_error(ssi_fips_error_t *p_err);
 
 /*
-This function returns the REE FIPS state.  
-It should be called by kernel module. 
+This function returns the REE FIPS state.
+It should be called by kernel module.
 */
 int ssi_fips_get_state(ssi_fips_state_t *p_state)
 {
-        int rc = 0;
+	int rc = 0;
 
 	if (p_state == NULL) {
 		return -EINVAL;
@@ -46,12 +46,12 @@ int ssi_fips_get_state(ssi_fips_state_t *p_state)
 EXPORT_SYMBOL(ssi_fips_get_state);
 
 /*
-This function returns the REE FIPS error.  
-It should be called by kernel module. 
+This function returns the REE FIPS error.
+It should be called by kernel module.
 */
 int ssi_fips_get_error(ssi_fips_error_t *p_err)
 {
-        int rc = 0;
+	int rc = 0;
 
 	if (p_err == NULL) {
 		return -EINVAL;
-- 
2.11.0

[toc] | [next] | [standalone]

#1640334 — Re: [PATCH] staging: ccree: remove trailing whitespace. switch spaces to tabs

FromGreg KH <gregkh@linuxfoundation.org>
Date2017-05-12 11:10 +0200
SubjectRe: [PATCH] staging: ccree: remove trailing whitespace. switch spaces to tabs
Message-ID<tGeKe-2eI-23@gated-at.bofh.it>
In reply to#1638342
On Tue, May 09, 2017 at 11:39:56AM -0700, Connor Kelleher wrote:
> ssi_fips.c:
> 
> fixing checkpatch.pl errors:
> 
> ERROR: trailing whitespace
> + * $
> 
> ERROR: trailing whitespace
> + * $
> 
> ERROR: trailing whitespace
> + * $
> 
> ERROR: trailing whitespace
> +This function returns the REE FIPS state.  $
> 
> ERROR: trailing whitespace
> +It should be called by kernel module. $
> 
> ERROR: code indent should use tabs where possible
> +        int rc = 0;$
> 
> ERROR: trailing whitespace
> +This function returns the REE FIPS error.  $
> 
> ERROR: trailing whitespace
> +It should be called by kernel module. $
> 
> ERROR: code indent should use tabs where possible
> +        int rc = 0;$

Those are different "types" of errors, please only do one type of thing
per patch.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1640706 — [PATCH v2 1/2] staging: ccree: switch spaces to tabs

FromConnor Kelleher <connor.r.kelleher@gmail.com>
Date2017-05-12 21:20 +0200
Subject[PATCH v2 1/2] staging: ccree: switch spaces to tabs
Message-ID<tGogy-Kn-13@gated-at.bofh.it>
In reply to#1640334
ssi_fips.c:

fixing checkpatch.pl errors:

ERROR: code indent should use tabs where possible
+        int rc = 0;$

ERROR: code indent should use tabs where possible
+        int rc = 0;$

Signed-off-by: Connor Kelleher <connor.r.kelleher@gmail.com>
---
 drivers/staging/ccree/ssi_fips.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ccree/ssi_fips.c b/drivers/staging/ccree/ssi_fips.c
index 50f748511979..11a463f5e33c 100644
--- a/drivers/staging/ccree/ssi_fips.c
+++ b/drivers/staging/ccree/ssi_fips.c
@@ -32,7 +32,7 @@ It should be called by kernel module.
 */
 int ssi_fips_get_state(ssi_fips_state_t *p_state)
 {
-        int rc = 0;
+	int rc = 0;
 
 	if (p_state == NULL) {
 		return -EINVAL;
@@ -51,7 +51,7 @@ It should be called by kernel module.
 */
 int ssi_fips_get_error(ssi_fips_error_t *p_err)
 {
-        int rc = 0;
+	int rc = 0;
 
 	if (p_err == NULL) {
 		return -EINVAL;
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1640707 — [PATCH v2 2/2] staging: ccree: remove trailing whitespace

FromConnor Kelleher <connor.r.kelleher@gmail.com>
Date2017-05-12 21:20 +0200
Subject[PATCH v2 2/2] staging: ccree: remove trailing whitespace
Message-ID<tGogy-Kn-15@gated-at.bofh.it>
In reply to#1640706
ssi_fips.c:

fixing checkpatch.pl errors:

ERROR: trailing whitespace
+ * $

ERROR: trailing whitespace
+ * $

ERROR: trailing whitespace
+ * $

ERROR: trailing whitespace
+This function returns the REE FIPS state.  $

ERROR: trailing whitespace
+It should be called by kernel module. $

ERROR: trailing whitespace
+This function returns the REE FIPS error.  $

ERROR: trailing whitespace
+It should be called by kernel module. $

Signed-off-by: Connor Kelleher <connor.r.kelleher@gmail.com>
---
 drivers/staging/ccree/ssi_fips.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/ccree/ssi_fips.c b/drivers/staging/ccree/ssi_fips.c
index 11a463f5e33c..25ee23a1cecf 100644
--- a/drivers/staging/ccree/ssi_fips.c
+++ b/drivers/staging/ccree/ssi_fips.c
@@ -1,15 +1,15 @@
 /*
  * Copyright (C) 2012-2017 ARM Limited or its affiliates.
- * 
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2 as
  * published by the Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
@@ -27,8 +27,8 @@ extern int ssi_fips_ext_get_state(ssi_fips_state_t *p_state);
 extern int ssi_fips_ext_get_error(ssi_fips_error_t *p_err);
 
 /*
-This function returns the REE FIPS state.  
-It should be called by kernel module. 
+This function returns the REE FIPS state.
+It should be called by kernel module.
 */
 int ssi_fips_get_state(ssi_fips_state_t *p_state)
 {
@@ -46,8 +46,8 @@ int ssi_fips_get_state(ssi_fips_state_t *p_state)
 EXPORT_SYMBOL(ssi_fips_get_state);
 
 /*
-This function returns the REE FIPS error.  
-It should be called by kernel module. 
+This function returns the REE FIPS error.
+It should be called by kernel module.
 */
 int ssi_fips_get_error(ssi_fips_error_t *p_err)
 {
-- 
2.11.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web