Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1638462 > unrolled thread
| Started by | Remco Verhoef <remco@dutchcoders.io> |
|---|---|
| First post | 2017-05-10 02:10 +0200 |
| Last post | 2017-05-15 22:40 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: rtl8188eu: Fix one coding style problem Remco Verhoef <remco@dutchcoders.io> - 2017-05-10 02:10 +0200
Re: [PATCH] staging: rtl8188eu: Fix one coding style problem Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-12 11:10 +0200
[PATCH v2] staging: rtl8188eu: fix indentation error Remco Verhoef <remco@dutchcoders.io> - 2017-05-13 03:50 +0200
Re: [PATCH v2] staging: rtl8188eu: fix indentation error Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-15 13:00 +0200
[PATCH v3] staging: rtl8188eu: fix indentation error Remco Verhoef <remco@dutchcoders.io> - 2017-05-15 22:40 +0200
| From | Remco Verhoef <remco@dutchcoders.io> |
|---|---|
| Date | 2017-05-10 02:10 +0200 |
| Subject | [PATCH] staging: rtl8188eu: Fix one coding style problem |
| Message-ID | <tFnmx-F9-11@gated-at.bofh.it> |
Fix code indent should use tabs where possible coding style
error.
Signed-off-by: Remco Verhoef <remco@dutchcoders.io>
---
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
index d9fa290..636f445 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
@@ -58,7 +58,7 @@ static void process_link_qual(struct adapter *padapter,
}
void rtl8188e_process_phy_info(struct adapter *padapter,
- struct recv_frame *precvframe)
+ struct recv_frame *precvframe)
{
/* Check RSSI */
process_rssi(padapter, precvframe);
--
1.9.1
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-12 11:10 +0200 |
| Message-ID | <tGeKe-2eI-17@gated-at.bofh.it> |
| In reply to | #1638462 |
On Tue, May 09, 2017 at 05:07:51PM -0700, Remco Verhoef wrote: > Fix code indent should use tabs where possible coding style > error. Your subject should be a bit better, why, "one"? please fix and resend. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Remco Verhoef <remco@dutchcoders.io> |
|---|---|
| Date | 2017-05-13 03:50 +0200 |
| Subject | [PATCH v2] staging: rtl8188eu: fix indentation error |
| Message-ID | <tGulX-5cj-1@gated-at.bofh.it> |
| In reply to | #1640331 |
Fixes a 'code indent should use tabs where possible' checkpatch code
style error by changing whitespace into tabs.
Signed-off-by: Remco Verhoef <remco@dutchcoders.io>
---
Changes in v2:
- More expressive commit message and subject
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
index d9fa290..636f445 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
@@ -58,7 +58,7 @@ static void process_link_qual(struct adapter *padapter,
}
void rtl8188e_process_phy_info(struct adapter *padapter,
- struct recv_frame *precvframe)
+ struct recv_frame *precvframe)
{
/* Check RSSI */
process_rssi(padapter, precvframe);
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-05-15 13:00 +0200 |
| Subject | Re: [PATCH v2] staging: rtl8188eu: fix indentation error |
| Message-ID | <tHlTk-72L-3@gated-at.bofh.it> |
| In reply to | #1640824 |
On Fri, May 12, 2017 at 06:39:44PM -0700, Remco Verhoef wrote: > Fixes a 'code indent should use tabs where possible' checkpatch code > style error by changing whitespace into tabs. > > Signed-off-by: Remco Verhoef <remco@dutchcoders.io> > --- > Changes in v2: > - More expressive commit message and subject > > drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c > index d9fa290..636f445 100644 > --- a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c > +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c > @@ -58,7 +58,7 @@ static void process_link_qual(struct adapter *padapter, > } > > void rtl8188e_process_phy_info(struct adapter *padapter, > - struct recv_frame *precvframe) > + struct recv_frame *precvframe) Try putting this right under the other "struct" string, to line things up better. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Remco Verhoef <remco@dutchcoders.io> |
|---|---|
| Date | 2017-05-15 22:40 +0200 |
| Subject | [PATCH v3] staging: rtl8188eu: fix indentation error |
| Message-ID | <tHuWD-4t8-35@gated-at.bofh.it> |
| In reply to | #1641534 |
Fixes a 'code indent should use tabs where possible' checkpatch code
style error by changing whitespace into tabs.
Signed-off-by: Remco Verhoef <remco@dutchcoders.io>
---
Changes in v2:
- More expressive commit message and subject
Changes in v3:
- Align with struct, to line things up better
drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
index d9fa290..9f51f54 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c
@@ -58,7 +58,7 @@ static void process_link_qual(struct adapter *padapter,
}
void rtl8188e_process_phy_info(struct adapter *padapter,
- struct recv_frame *precvframe)
+ struct recv_frame *precvframe)
{
/* Check RSSI */
process_rssi(padapter, precvframe);
--
1.9.1
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web