Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1640926 > unrolled thread
| Started by | Andreas Färber <afaerber@suse.de> |
|---|---|
| First post | 2017-05-13 16:40 +0200 |
| Last post | 2017-05-14 12:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 02/18] arm64: dts: amlogic: Sort Makefile Andreas Färber <afaerber@suse.de> - 2017-05-13 16:40 +0200
Re: [PATCH v2 02/18] arm64: dts: amlogic: Sort Makefile Chris Moore <moore@free.fr> - 2017-05-14 06:30 +0200
Re: [PATCH v2 02/18] arm64: dts: amlogic: Sort Makefile Andreas Färber <afaerber@suse.de> - 2017-05-14 12:10 +0200
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2017-05-13 16:40 +0200 |
| Subject | [PATCH v2 02/18] arm64: dts: amlogic: Sort Makefile |
| Message-ID | <tGGn8-4So-15@gated-at.bofh.it> |
Sort the .dtb files alphabetically to make clear where to add new ones. Signed-off-by: Andreas Färber <afaerber@suse.de> --- v1 -> v2: * Rebased (new boards added) * Extended commit message arch/arm64/boot/dts/amlogic/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile index b9ad2db7398b..14fa27ccd589 100644 --- a/arch/arm64/boot/dts/amlogic/Makefile +++ b/arch/arm64/boot/dts/amlogic/Makefile @@ -7,15 +7,15 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-meta.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-telos.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-wetek-hub.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-wetek-play2.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-hwacom-amazetv.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-khadas-vim.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb -dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-hwacom-amazetv.dtb -dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb -dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb always := $(dtb-y) subdir-y := $(dts-dirs) -- 2.12.0
[toc] | [next] | [standalone]
| From | Chris Moore <moore@free.fr> |
|---|---|
| Date | 2017-05-14 06:30 +0200 |
| Message-ID | <tGTkl-5ec-3@gated-at.bofh.it> |
| In reply to | #1640926 |
Le 13/05/2017 à 16:33, Andreas Färber a écrit : > Sort the .dtb files alphabetically to make clear where to add new ones. > > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > v1 -> v2: > * Rebased (new boards added) > * Extended commit message > > arch/arm64/boot/dts/amlogic/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index b9ad2db7398b..14fa27ccd589 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -7,15 +7,15 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-meta.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-telos.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-wetek-hub.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-wetek-play2.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-hwacom-amazetv.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-khadas-vim.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb s905d should be before s905x if you are imposing alphabetical order. > -dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-hwacom-amazetv.dtb > -dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb > -dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb > > always := $(dtb-y) > subdir-y := $(dts-dirs)
[toc] | [prev] | [next] | [standalone]
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2017-05-14 12:10 +0200 |
| Message-ID | <tGYDn-gk-3@gated-at.bofh.it> |
| In reply to | #1641055 |
Am 14.05.2017 um 06:28 schrieb Chris Moore: > Le 13/05/2017 à 16:33, Andreas Färber a écrit : >> Sort the .dtb files alphabetically to make clear where to add new ones. >> >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> v1 -> v2: >> * Rebased (new boards added) >> * Extended commit message >> arch/arm64/boot/dts/amlogic/Makefile | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/amlogic/Makefile >> b/arch/arm64/boot/dts/amlogic/Makefile >> index b9ad2db7398b..14fa27ccd589 100644 >> --- a/arch/arm64/boot/dts/amlogic/Makefile >> +++ b/arch/arm64/boot/dts/amlogic/Makefile >> @@ -7,15 +7,15 @@ dtb-$(CONFIG_ARCH_MESON) += >> meson-gxbb-vega-s95-meta.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-telos.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-wetek-hub.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-wetek-play2.dtb >> +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-hwacom-amazetv.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-khadas-vim.dtb >> +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb > > s905d should be before s905x if you are imposing alphabetical order. True, but the above matches the SoC grouping in patch 01/18, and I'd rather not resend this series more often than necessary. If we need to respin it, we could insert white lines or comments to make it clearer. Or Kevin could just add "grouped by SoC" to the commit message. He had no comment in v1 and wanted to apply them but insisted on a respin. Regards, Andreas >> -dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-hwacom-amazetv.dtb >> -dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb >> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q200.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-q201.dtb >> -dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb >> always := $(dtb-y) >> subdir-y := $(dts-dirs) -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web