Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1640977 > unrolled thread
| Started by | Fabian Frederick <fabf@skynet.be> |
|---|---|
| First post | 2017-05-13 21:10 +0200 |
| Last post | 2017-05-14 01:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH linux-next] device-dax: fix BLOCK dependency Fabian Frederick <fabf@skynet.be> - 2017-05-13 21:10 +0200
Re: [PATCH linux-next] device-dax: fix BLOCK dependency Dan Williams <dan.j.williams@intel.com> - 2017-05-14 01:30 +0200
| From | Fabian Frederick <fabf@skynet.be> |
|---|---|
| Date | 2017-05-13 21:10 +0200 |
| Subject | [PATCH linux-next] device-dax: fix BLOCK dependency |
| Message-ID | <tGKAp-7Ln-1@gated-at.bofh.it> |
commit ef51042472f5 ("block, dax: move "select DAX" from BLOCK to FS_DAX")
uses get_start_sect() which requires CONFIG_BLOCK
make allnoconfig + dax gives the following:
drivers/dax/super.c: In function 'bdev_dax_pgoff':
drivers/dax/super.c:50:26: error: implicit declaration of function
'get_start_sect' [-Werror=implicit-function-declaration]
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/dax/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
index b79aa8f..1806628 100644
--- a/drivers/dax/Kconfig
+++ b/drivers/dax/Kconfig
@@ -1,5 +1,6 @@
menuconfig DAX
tristate "DAX: direct access to differentiated memory"
+ depends on BLOCK
select SRCU
default m if NVDIMM_DAX
--
2.9.3
[toc] | [next] | [standalone]
| From | Dan Williams <dan.j.williams@intel.com> |
|---|---|
| Date | 2017-05-14 01:30 +0200 |
| Message-ID | <tGOE1-1ZD-1@gated-at.bofh.it> |
| In reply to | #1640977 |
On Sat, May 13, 2017 at 11:59 AM, Fabian Frederick <fabf@skynet.be> wrote:
> commit ef51042472f5 ("block, dax: move "select DAX" from BLOCK to FS_DAX")
> uses get_start_sect() which requires CONFIG_BLOCK
>
> make allnoconfig + dax gives the following:
>
> drivers/dax/super.c: In function 'bdev_dax_pgoff':
> drivers/dax/super.c:50:26: error: implicit declaration of function
> 'get_start_sect' [-Werror=implicit-function-declaration]
>
Ah, sorry for this breakage, I guess this is a config that kbuild does
not attempt. I'll fix this up by not compiling the block-related
helpers in the BLOCK=n case.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web