Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637490 > unrolled thread

Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures

Started byPeter Senna Tschudin <peter.senna@collabora.com>
First post2017-05-08 17:10 +0200
Last post2017-05-10 16:20 +0200
Articles 4 on this page of 24 — 6 participants

Back to article view | Back to linux.kernel

Contents

  Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into  host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 17:10 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Joao Pinto <Joao.Pinto@synopsys.com> - 2017-05-08 17:20 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-08 17:30 +0200
        Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Joao Pinto <Joao.Pinto@synopsys.com> - 2017-05-08 17:40 +0200
          Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-08 17:50 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-08 17:50 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-08 18:00 +0200
        Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 19:20 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 18:20 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lucas Stach <l.stach@pengutronix.de> - 2017-05-08 18:40 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 18:50 +0200
        Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lucas Stach <l.stach@pengutronix.de> - 2017-05-08 18:50 +0200
          Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 19:00 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-05-08 20:00 +0200
        Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 22:40 +0200
          Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-05-09 18:30 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-05-08 20:30 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Fabio Estevam <festevam@gmail.com> - 2017-05-09 03:40 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-09 08:40 +0200
        Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Fabio Estevam <festevam@gmail.com> - 2017-05-09 12:30 +0200
          Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-10 15:20 +0200
            Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Fabio Estevam <festevam@gmail.com> - 2017-05-10 15:30 +0200
              Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lucas Stach <l.stach@pengutronix.de> - 2017-05-10 15:40 +0200
                Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-10 16:20 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1638809 — Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures

FromPeter Senna Tschudin <peter.senna@collabora.com>
Date2017-05-10 15:20 +0200
SubjectRe: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures
Message-ID<tFzH4-1cQ-15@gated-at.bofh.it>
In reply to#1638027
On Tue, May 09, 2017 at 07:21:24AM -0300, Fabio Estevam wrote:
> Hi Peter,
> 
> On Tue, May 9, 2017 at 3:34 AM, Peter Senna Tschudin
> <peter.senna@collabora.com> wrote:
> 
> > Something that ocurred to me is that u-boot is initializing the PCI, and
> > the PCI networkd cards.  Ideally this should not affect anything, but
> > can this be related to the issue?
> 
> Yes, in order to narrow things down: please boot 4.11 without PCI
> support in U-Boot.

Yes, removing the PCI code from u-boot makes 4.11 to boot. But latest
next still hangs.

> 
> The problem is that mx6q does not have a way to properly reset the PCI block.
> 
> On the board I tested there is no PCI support in U-Boot.
> 
> Maybe we need the following approach in U-Boot as Lucas did for Barebox:
> https://git.pengutronix.de/cgit/barebox/commit/?id=f1da98da2760c21487bbba8f7fb957c843a22896

Maybe we do need, but the kernel is working on v4.10 for our use case,
and it is not working any longer on v4.11. What is the way to continue
from here?

> 
> According to this patch that went into 4.11 the bootloader must put
> PCI back in a safe state:
> https://patchwork.kernel.org/patch/9528911

[toc] | [prev] | [next] | [standalone]

#1638819 — Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures

FromFabio Estevam <festevam@gmail.com>
Date2017-05-10 15:30 +0200
SubjectRe: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures
Message-ID<tFzQL-1g0-29@gated-at.bofh.it>
In reply to#1638809
On Wed, May 10, 2017 at 10:17 AM, Peter Senna Tschudin
<peter.senna@collabora.com> wrote:
> On Tue, May 09, 2017 at 07:21:24AM -0300, Fabio Estevam wrote:
>> Hi Peter,
>>
>> On Tue, May 9, 2017 at 3:34 AM, Peter Senna Tschudin
>> <peter.senna@collabora.com> wrote:
>>
>> > Something that ocurred to me is that u-boot is initializing the PCI, and
>> > the PCI networkd cards.  Ideally this should not affect anything, but
>> > can this be related to the issue?
>>
>> Yes, in order to narrow things down: please boot 4.11 without PCI
>> support in U-Boot.
>
> Yes, removing the PCI code from u-boot makes 4.11 to boot. But latest
> next still hangs.

Ok, good. At least we see the same behaviour now.

We still need a fix for the mx6q hang on systems with PCI switch for
linux/next or 4.12-rc1.

>> The problem is that mx6q does not have a way to properly reset the PCI block.
>>
>> On the board I tested there is no PCI support in U-Boot.
>>
>> Maybe we need the following approach in U-Boot as Lucas did for Barebox:
>> https://git.pengutronix.de/cgit/barebox/commit/?id=f1da98da2760c21487bbba8f7fb957c843a22896
>
> Maybe we do need, but the kernel is working on v4.10 for our use case,
> and it is not working any longer on v4.11. What is the way to continue
> from here?

There is no other way other than fixing U-Boot on this case.

[toc] | [prev] | [next] | [standalone]

#1638823 — Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures

FromLucas Stach <l.stach@pengutronix.de>
Date2017-05-10 15:40 +0200
SubjectRe: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures
Message-ID<tFA0q-1j1-7@gated-at.bofh.it>
In reply to#1638819
Am Mittwoch, den 10.05.2017, 10:27 -0300 schrieb Fabio Estevam:
> On Wed, May 10, 2017 at 10:17 AM, Peter Senna Tschudin
> <peter.senna@collabora.com> wrote:
> > On Tue, May 09, 2017 at 07:21:24AM -0300, Fabio Estevam wrote:
> >> Hi Peter,
> >>
> >> On Tue, May 9, 2017 at 3:34 AM, Peter Senna Tschudin
> >> <peter.senna@collabora.com> wrote:
> >>
> >> > Something that ocurred to me is that u-boot is initializing the PCI, and
> >> > the PCI networkd cards.  Ideally this should not affect anything, but
> >> > can this be related to the issue?
> >>
> >> Yes, in order to narrow things down: please boot 4.11 without PCI
> >> support in U-Boot.
> >
> > Yes, removing the PCI code from u-boot makes 4.11 to boot. But latest
> > next still hangs.
> 
> Ok, good. At least we see the same behaviour now.
> 
> We still need a fix for the mx6q hang on systems with PCI switch for
> linux/next or 4.12-rc1.

I will take a look at this today.

> 
> >> The problem is that mx6q does not have a way to properly reset the PCI block.
> >>
> >> On the board I tested there is no PCI support in U-Boot.
> >>
> >> Maybe we need the following approach in U-Boot as Lucas did for Barebox:
> >> https://git.pengutronix.de/cgit/barebox/commit/?id=f1da98da2760c21487bbba8f7fb957c843a22896
> >
> > Maybe we do need, but the kernel is working on v4.10 for our use case,
> > and it is not working any longer on v4.11. What is the way to continue
> > from here?
> 
> There is no other way other than fixing U-Boot on this case.

You could also revert the change in the kernel if you are absolutely
sure that this won't cause issues on your system (you are not using the
internal watchdog etc.).

But for the long run and to make sure that _all_ use-cases work
properly, there is no way around fixing your bootloader to behave
correctly.

Regards,
Lucas

[toc] | [prev] | [next] | [standalone]

#1638868 — Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures

FromPeter Senna Tschudin <peter.senna@collabora.com>
Date2017-05-10 16:20 +0200
SubjectRe: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures
Message-ID<tFAD7-1LQ-11@gated-at.bofh.it>
In reply to#1638823
On Wed, May 10, 2017 at 03:32:19PM +0200, Lucas Stach wrote:
> Am Mittwoch, den 10.05.2017, 10:27 -0300 schrieb Fabio Estevam:
> > On Wed, May 10, 2017 at 10:17 AM, Peter Senna Tschudin
> > <peter.senna@collabora.com> wrote:
> > > On Tue, May 09, 2017 at 07:21:24AM -0300, Fabio Estevam wrote:
> > >> Hi Peter,
> > >>
> > >> On Tue, May 9, 2017 at 3:34 AM, Peter Senna Tschudin
> > >> <peter.senna@collabora.com> wrote:
> > >>
> > >> > Something that ocurred to me is that u-boot is initializing the PCI, and
> > >> > the PCI networkd cards.  Ideally this should not affect anything, but
> > >> > can this be related to the issue?
> > >>
> > >> Yes, in order to narrow things down: please boot 4.11 without PCI
> > >> support in U-Boot.
> > >
> > > Yes, removing the PCI code from u-boot makes 4.11 to boot. But latest
> > > next still hangs.
> > 
> > Ok, good. At least we see the same behaviour now.
> > 
> > We still need a fix for the mx6q hang on systems with PCI switch for
> > linux/next or 4.12-rc1.
> 
> I will take a look at this today.

I'll be more than happy to help. Let me know if you need testing or any
other thing.

> 
> > 
> > >> The problem is that mx6q does not have a way to properly reset the PCI block.
> > >>
> > >> On the board I tested there is no PCI support in U-Boot.
> > >>
> > >> Maybe we need the following approach in U-Boot as Lucas did for Barebox:
> > >> https://git.pengutronix.de/cgit/barebox/commit/?id=f1da98da2760c21487bbba8f7fb957c843a22896
> > >
> > > Maybe we do need, but the kernel is working on v4.10 for our use case,
> > > and it is not working any longer on v4.11. What is the way to continue
> > > from here?
> > 
> > There is no other way other than fixing U-Boot on this case.
> 
> You could also revert the change in the kernel if you are absolutely
> sure that this won't cause issues on your system (you are not using the
> internal watchdog etc.).
> 
> But for the long run and to make sure that _all_ use-cases work
> properly, there is no way around fixing your bootloader to behave
> correctly.

Thanks!

> 
> Regards,
> Lucas
>

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web