Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1638030 > unrolled thread

[PATCH v1] ata: sata_rcar: Handle return value of clk_prepare_enable

Back to article view | Back to linux.kernel

Contents

  [PATCH v1] ata: sata_rcar: Handle return value of clk_prepare_enable Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-05-09 12:40 +0200
    Re: [PATCH v1] ata: sata_rcar: Handle return value of  clk_prepare_enable Tejun Heo <tj@kernel.org> - 2017-05-09 16:40 +0200
    Re: [PATCH v1] ata: sata_rcar: Handle return value of  clk_prepare_enable Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-05-10 11:10 +0200

#1638030 — [PATCH v1] ata: sata_rcar: Handle return value of clk_prepare_enable

Here, Clock enable can failed. So adding an error check for
clk_prepare_enable.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/ata/sata_rcar.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
index 5d38245..7e789c1 100644
--- a/drivers/ata/sata_rcar.c
+++ b/drivers/ata/sata_rcar.c
@@ -890,7 +890,9 @@ static int sata_rcar_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "failed to get access to sata clock\n");
 		return PTR_ERR(priv->clk);
 	}
-	clk_prepare_enable(priv->clk);
+	ret = clk_prepare_enable(priv->clk);
+	if (ret)
+		return ret;
 
 	host = ata_host_alloc(&pdev->dev, 1);
 	if (!host) {
@@ -971,7 +973,9 @@ static int sata_rcar_resume(struct device *dev)
 	struct sata_rcar_priv *priv = host->private_data;
 	void __iomem *base = priv->base;
 
-	clk_prepare_enable(priv->clk);
+	int ret = clk_prepare_enable(priv->clk);
+	if (ret)
+		return ret;
 
 	/* ack and mask */
 	iowrite32(0, base + SATAINTSTAT_REG);
@@ -989,7 +993,9 @@ static int sata_rcar_restore(struct device *dev)
 	struct ata_host *host = dev_get_drvdata(dev);
 	struct sata_rcar_priv *priv = host->private_data;
 
-	clk_prepare_enable(priv->clk);
+	int ret = clk_prepare_enable(priv->clk);
+	if (ret)
+		return ret;
 
 	sata_rcar_setup_port(host);
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1638167 — Re: [PATCH v1] ata: sata_rcar: Handle return value of clk_prepare_enable

On Tue, May 09, 2017 at 04:00:28PM +0530, Arvind Yadav wrote:
> Here, Clock enable can failed. So adding an error check for
> clk_prepare_enable.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied to libata/for-4.12-fixes w/ a couple trivial changes.

Thanks.

-- 
tejun

[toc] | [prev] | [next] | [standalone]

#1638695 — Re: [PATCH v1] ata: sata_rcar: Handle return value of clk_prepare_enable

Hello.

On 5/9/2017 1:30 PM, Arvind Yadav wrote:

> Here, Clock enable can failed. So adding an error check for

    Maybe "here enabling the clock can fail"?

> clk_prepare_enable.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

    Other than that:

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

MBR, Sergei

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web