Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1639451 > unrolled thread

[PATCH 2/4] C6X/megamode-pic: Delete an error message for a failed memory allocation in init_megamod_pic()

Started bySF Markus Elfring <elfring@users.sourceforge.net>
First post2017-05-11 15:50 +0200
Last post2017-05-11 15:50 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/4] C6X/megamode-pic: Delete an error message for a failed  memory allocation in init_megamod_pic() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-11 15:50 +0200

#1639451 — [PATCH 2/4] C6X/megamode-pic: Delete an error message for a failed memory allocation in init_megamod_pic()

FromSF Markus Elfring <elfring@users.sourceforge.net>
Date2017-05-11 15:50 +0200
Subject[PATCH 2/4] C6X/megamode-pic: Delete an error message for a failed memory allocation in init_megamod_pic()
Message-ID<tFWDE-6V6-11@gated-at.bofh.it>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 11 May 2017 15:00:30 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/c6x/platforms/megamod-pic.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/c6x/platforms/megamod-pic.c b/arch/c6x/platforms/megamod-pic.c
index 72b5f143c105..cf0ebf25e42f 100644
--- a/arch/c6x/platforms/megamod-pic.c
+++ b/arch/c6x/platforms/megamod-pic.c
@@ -209,7 +209,5 @@ static struct megamod_pic * __init init_megamod_pic(struct device_node *np)
-	if (!pic) {
-		pr_err("%s: Could not alloc PIC structure.\n", np->full_name);
+	if (!pic)
 		return NULL;
-	}
 
 	pic->irqhost = irq_domain_add_linear(np, NR_COMBINERS * 32,
 					     &megamod_domain_ops, pic);
-- 
2.12.3

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web