Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1639353 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-05-11 14:20 +0200 |
| Last post | 2017-05-11 20:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Bluetooth: hci_nokia: select CONFIG_BT_HCIUART_H4 Arnd Bergmann <arnd@arndb.de> - 2017-05-11 14:20 +0200
Re: [PATCH] Bluetooth: hci_nokia: select CONFIG_BT_HCIUART_H4 Sebastian Reichel <sre@kernel.org> - 2017-05-11 20:30 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-05-11 14:20 +0200 |
| Subject | [PATCH] Bluetooth: hci_nokia: select CONFIG_BT_HCIUART_H4 |
| Message-ID | <tFVez-6c7-27@gated-at.bofh.it> |
Like the other H4 variants, this only builds when the base
H4 support is enabled, otherwise we get a build error:
drivers/bluetooth/hci_nokia.c:624:33: error: array type has incomplete element type 'struct h4_recv_pkt'
Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/bluetooth/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 40994d96d151..b2cf0ae6b62d 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
depends on BT_HCIUART
depends on BT_HCIUART_SERDEV
depends on PM
+ select BT_HCIUART_H4
help
Nokia H4+ is serial protocol for communication between Bluetooth
device and host. This protocol is required for Bluetooth devices
--
2.9.0
[toc] | [next] | [standalone]
| From | Sebastian Reichel <sre@kernel.org> |
|---|---|
| Date | 2017-05-11 20:30 +0200 |
| Message-ID | <tG10C-1rf-11@gated-at.bofh.it> |
| In reply to | #1639353 |
[Multipart message — attachments visible in raw view] — view raw
Hi Arnd,
On Thu, May 11, 2017 at 02:11:26PM +0200, Arnd Bergmann wrote:
> Like the other H4 variants, this only builds when the base
> H4 support is enabled, otherwise we get a build error:
>
> drivers/bluetooth/hci_nokia.c:624:33: error: array type has incomplete element type 'struct h4_recv_pkt'
>
> Fixes: 7bb318680e86 ("Bluetooth: add nokia driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This has already been sent by Tobias Regnery some days ago:
http://www.spinics.net/lists/linux-bluetooth/msg70433.html
-- Sebastian
> drivers/bluetooth/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 40994d96d151..b2cf0ae6b62d 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -97,6 +97,7 @@ config BT_HCIUART_NOKIA
> depends on BT_HCIUART
> depends on BT_HCIUART_SERDEV
> depends on PM
> + select BT_HCIUART_H4
> help
> Nokia H4+ is serial protocol for communication between Bluetooth
> device and host. This protocol is required for Bluetooth devices
> --
> 2.9.0
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web