Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1639319 > unrolled thread

[PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS

Started byArnd Bergmann <arnd@arndb.de>
First post2017-05-11 13:40 +0200
Last post2017-05-11 13:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS Arnd Bergmann <arnd@arndb.de> - 2017-05-11 13:40 +0200
    Re: [PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS Fabio Estevam <festevam@gmail.com> - 2017-05-11 13:50 +0200

#1639319 — [PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS

FromArnd Bergmann <arnd@arndb.de>
Date2017-05-11 13:40 +0200
Subject[PATCH] soc: imx: add PM dependency for IMX7_PM_DOMAINS
Message-ID<tFUBQ-5JW-13@gated-at.bofh.it>
The new pm domain driver causes a build failure when CONFIG_PM
is not set:

warning: (IMX7_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
drivers/base/power/domain_governor.c: In function 'default_suspend_ok':
drivers/base/power/domain_governor.c:75:17: error: 'struct dev_pm_info' has no member named 'ignore_children'

This adds a dependency to ensure that we don't attempt to build the
driver without CONFIG_PM.

Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/soc/imx/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 357a5d8f8da0..a5b86a28f343 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -2,8 +2,9 @@ menu "i.MX SoC drivers"
 
 config IMX7_PM_DOMAINS
 	bool "i.MX7 PM domains"
-	select PM_GENERIC_DOMAINS
 	depends on SOC_IMX7D || (COMPILE_TEST && OF)
+	depends on PM
+	select PM_GENERIC_DOMAINS
 	default y if SOC_IMX7D
 
 endmenu
-- 
2.9.0

[toc] | [next] | [standalone]


#1639327

FromFabio Estevam <festevam@gmail.com>
Date2017-05-11 13:50 +0200
Message-ID<tFULv-5Ng-11@gated-at.bofh.it>
In reply to#1639319
On Thu, May 11, 2017 at 8:37 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The new pm domain driver causes a build failure when CONFIG_PM
> is not set:
>
> warning: (IMX7_PM_DOMAINS) selects PM_GENERIC_DOMAINS which has unmet direct dependencies (PM)
> drivers/base/power/domain_governor.c: In function 'default_suspend_ok':
> drivers/base/power/domain_governor.c:75:17: error: 'struct dev_pm_info' has no member named 'ignore_children'
>
> This adds a dependency to ensure that we don't attempt to build the
> driver without CONFIG_PM.
>
> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web