Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1639179 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-05-11 06:00 +0200 |
| Last post | 2017-05-11 10:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] iommu: remove unnecessary code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-11 06:00 +0200
Re: [PATCH] iommu: remove unnecessary code David Woodhouse <dwmw2@infradead.org> - 2017-05-11 10:10 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-05-11 06:00 +0200 |
| Subject | [PATCH] iommu: remove unnecessary code |
| Message-ID | <tFNqG-14Z-9@gated-at.bofh.it> |
did_old is an unsigned variable and, greater-than-or-equal-to-zero
comparison of an unsigned variable is always true.
Addresses-Coverity-ID: 1398477
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/iommu/intel-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index d412a31..98daf4a 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -2050,7 +2050,7 @@ static int domain_context_mapping_one(struct dmar_domain *domain,
if (context_copied(context)) {
u16 did_old = context_domain_id(context);
- if (did_old >= 0 && did_old < cap_ndoms(iommu->cap))
+ if (did_old < cap_ndoms(iommu->cap))
iommu->flush.flush_context(iommu, did_old,
(((u16)bus) << 8) | devfn,
DMA_CCMD_MASK_NOBIT,
--
2.5.0
[toc] | [next] | [standalone]
| From | David Woodhouse <dwmw2@infradead.org> |
|---|---|
| Date | 2017-05-11 10:10 +0200 |
| Message-ID | <tFRkC-3Q2-7@gated-at.bofh.it> |
| In reply to | #1639179 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, 2017-05-10 at 22:49 -0500, Gustavo A. R. Silva wrote:
> did_old is an unsigned variable and, greater-than-or-equal-to-zero
> comparison of an unsigned variable is always true.
>
> Addresses-Coverity-ID: 1398477
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
So... why do you think that check was there? Do you think it's possible
that someone mistakenly *thought* it could be negative? What were they
actually checking for? Have you actually *fixed* a bug here, or have
you just masked it?
Even if you've done all that analysis and it *is* correct just to drop
the comparison rather than fixing it, you need to put verbiage to that
effect into the commit comment.
Never write patches to "fix warnings". Always to fix bugs.
> ---
> drivers/iommu/intel-iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index d412a31..98daf4a 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -2050,7 +2050,7 @@ static int domain_context_mapping_one(struct dmar_domain *domain,
> if (context_copied(context)) {
> u16 did_old = context_domain_id(context);
>
> - if (did_old >= 0 && did_old < cap_ndoms(iommu->cap))
> + if (did_old < cap_ndoms(iommu->cap))
> iommu->flush.flush_context(iommu, did_old,
> (((u16)bus) << 8) | devfn,
> DMA_CCMD_MASK_NOBIT,
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web