Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1638942 > unrolled thread

[PATCH 0/2] acpi/button: revert v4.10 behavior

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] acpi/button: revert v4.10 behavior Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-10 18:20 +0200
    Re: [PATCH 0/2] acpi/button: revert v4.10 behavior "Rafael J. Wysocki" <rafael@kernel.org> - 2017-05-11 02:10 +0200
      Re: [PATCH 0/2] acpi/button: revert v4.10 behavior Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-05-11 11:40 +0200

#1638942 — [PATCH 0/2] acpi/button: revert v4.10 behavior

The new default 'open' behavior for acpi_lid_initialize_state() is just
wrong. It breaks professional laptops with a docking station [1].

Booting the laptop with the LID closed is something common and now there
is no way of knowing the actual state of the LID switch at boot. Please
use a user-space solution as described in 2/2 if you really don't want to
add quirks in the kernel.

Cheers,
Benjamin

[1] https://bugzilla.gnome.org/show_bug.cgi?id=782380

Benjamin Tissoires (2):
  Revert "ACPI / button: Remove lid_init_state=method mode"
  Revert "ACPI / button: Change default behavior to lid_init_state=open"

 Documentation/acpi/acpi-lid.txt | 16 ++++++++++++----
 drivers/acpi/button.c           | 11 ++++++++++-
 2 files changed, 22 insertions(+), 5 deletions(-)

-- 
2.9.3

[toc] | [next] | [standalone]

#1639121

On Wed, May 10, 2017 at 6:12 PM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> The new default 'open' behavior for acpi_lid_initialize_state() is just
> wrong. It breaks professional laptops with a docking station [1].
>
> Booting the laptop with the LID closed is something common and now there
> is no way of knowing the actual state of the LID switch at boot. Please
> use a user-space solution as described in 2/2 if you really don't want to
> add quirks in the kernel.
>
> Cheers,
> Benjamin
>
> [1] https://bugzilla.gnome.org/show_bug.cgi?id=782380
>
> Benjamin Tissoires (2):
>   Revert "ACPI / button: Remove lid_init_state=method mode"
>   Revert "ACPI / button: Change default behavior to lid_init_state=open"
>
>  Documentation/acpi/acpi-lid.txt | 16 ++++++++++++----
>  drivers/acpi/button.c           | 11 ++++++++++-
>  2 files changed, 22 insertions(+), 5 deletions(-)

Well, have you seen the recent series
(http://marc.info/?l=linux-acpi&m=149431335204701&w=2 and the
following) from Lv?

He evidently agrees with you that "ACPI / button: Remove
lid_init_state=method mode" should be reverted, but then there are
differences.

Can you please have a look at that and let me know what's wrong with
it in your view?  I'd like to have a full picture if poss.

Thanks,
Rafael

[toc] | [prev] | [next] | [standalone]

#1639270

Hi Rafael,

On May 11 2017 or thereabouts, Rafael J. Wysocki wrote:
> On Wed, May 10, 2017 at 6:12 PM, Benjamin Tissoires
> <benjamin.tissoires@redhat.com> wrote:
> > The new default 'open' behavior for acpi_lid_initialize_state() is just
> > wrong. It breaks professional laptops with a docking station [1].
> >
> > Booting the laptop with the LID closed is something common and now there
> > is no way of knowing the actual state of the LID switch at boot. Please
> > use a user-space solution as described in 2/2 if you really don't want to
> > add quirks in the kernel.
> >
> > Cheers,
> > Benjamin
> >
> > [1] https://bugzilla.gnome.org/show_bug.cgi?id=782380
> >
> > Benjamin Tissoires (2):
> >   Revert "ACPI / button: Remove lid_init_state=method mode"
> >   Revert "ACPI / button: Change default behavior to lid_init_state=open"
> >
> >  Documentation/acpi/acpi-lid.txt | 16 ++++++++++++----
> >  drivers/acpi/button.c           | 11 ++++++++++-
> >  2 files changed, 22 insertions(+), 5 deletions(-)
> 
> Well, have you seen the recent series
> (http://marc.info/?l=linux-acpi&m=149431335204701&w=2 and the
> following) from Lv?
> 

Yeah, sorry I saw it right after sending mine.

> He evidently agrees with you that "ACPI / button: Remove
> lid_init_state=method mode" should be reverted, but then there are
> differences.

I still believe the second patch should be reverted (I'll try to
convince Lv in the other replies).

> 
> Can you please have a look at that and let me know what's wrong with
> it in your view?  I'd like to have a full picture if poss.

Sure.

A "short" summary could be the following (I'll go in deeper details in
the other replies I'll send):
- it's true that some devices are broken in term of LID switch, but we
  never managed to get an accurate estimate of how many devices are
  affected. Last time we spoke only 3 devices were affected, 1 being 4
  years old or more, one other having a in-kernel solution already.
- the change in the default setting breaks many more devices (all the
  thinkpads from Lenovo, most professional Dell laptops too), and the
  distributions solution would be to set the default setting back to
  "method", so we are back to square one
- changing the default setting to "open" prevents user space to fix the
  kernel by adding heuristics
- the only viable solution is to have a list of problematic devices that
  don't report the correct LID switch state at boot (and later). Whether
  this list is in the kernel or in user-space, I don't care, but the
  current v4.11 code (and probably the second series Lv sent) prevents a
  user-space database to be set.

Cheers,
Benjamin

> 
> Thanks,
> Rafael

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web