Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1637357 > unrolled thread

[PATCH] thermal: core: make thermal_emergency_poweroff static

Started byColin King <colin.king@canonical.com>
First post2017-05-08 12:40 +0200
Last post2017-05-09 05:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] thermal: core: make thermal_emergency_poweroff static Colin King <colin.king@canonical.com> - 2017-05-08 12:40 +0200
    Re: [PATCH] thermal: core: make thermal_emergency_poweroff static Keerthy <j-keerthy@ti.com> - 2017-05-09 05:40 +0200

#1637357 — [PATCH] thermal: core: make thermal_emergency_poweroff static

FromColin King <colin.king@canonical.com>
Date2017-05-08 12:40 +0200
Subject[PATCH] thermal: core: make thermal_emergency_poweroff static
Message-ID<tEOf7-2KW-15@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

Making thermal_emergency_poweroff static fixes sparse warning:

  drivers/thermal/thermal_core.c:6: warning: symbol
  'thermal_emergency_poweroff' was not declared. Should it be static?

Fixes: ef1d87e06ab4 ("thermal: core: Add a back up thermal shutdown mechanism")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/thermal/thermal_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index b21b9cc2c8d6..5a51c740e372 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -359,7 +359,7 @@ static DECLARE_DELAYED_WORK(thermal_emergency_poweroff_work,
  * This may be called from any critical situation to trigger a system shutdown
  * after a known period of time. By default this is not scheduled.
  */
-void thermal_emergency_poweroff(void)
+static void thermal_emergency_poweroff(void)
 {
 	int poweroff_delay_ms = CONFIG_THERMAL_EMERGENCY_POWEROFF_DELAY_MS;
 	/*
-- 
2.11.0

[toc] | [next] | [standalone]


#1637851

FromKeerthy <j-keerthy@ti.com>
Date2017-05-09 05:40 +0200
Message-ID<tF4ad-4v9-1@gated-at.bofh.it>
In reply to#1637357

On Monday 08 May 2017 04:06 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Making thermal_emergency_poweroff static fixes sparse warning:
> 
>   drivers/thermal/thermal_core.c:6: warning: symbol
>   'thermal_emergency_poweroff' was not declared. Should it be static?

Acked-by: Keerthy <j-keerthy@ti.com>

> 
> Fixes: ef1d87e06ab4 ("thermal: core: Add a back up thermal shutdown mechanism")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/thermal/thermal_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index b21b9cc2c8d6..5a51c740e372 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -359,7 +359,7 @@ static DECLARE_DELAYED_WORK(thermal_emergency_poweroff_work,
>   * This may be called from any critical situation to trigger a system shutdown
>   * after a known period of time. By default this is not scheduled.
>   */
> -void thermal_emergency_poweroff(void)
> +static void thermal_emergency_poweroff(void)
>  {
>  	int poweroff_delay_ms = CONFIG_THERMAL_EMERGENCY_POWEROFF_DELAY_MS;
>  	/*
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web