Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1636998 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-05-07 00:20 +0200 |
| Last post | 2017-05-09 04:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] scsi: lpfc: ensure els_wq is being checked before destroying it Colin King <colin.king@canonical.com> - 2017-05-07 00:20 +0200
Re: [PATCH] scsi: lpfc: ensure els_wq is being checked before destroying it "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-05-09 04:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-05-07 00:20 +0200 |
| Subject | [PATCH] scsi: lpfc: ensure els_wq is being checked before destroying it |
| Message-ID | <tEgdr-5m9-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
I believe there is a typo on the wq destroy of els_wq, currently
the driver is checking if els_cq is not null and I think this
should be a check on els_wq instead.
Detected by CoverityScan, CID#1411629 ("Copy-paste error")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 90ae354a9c45..c925bbe9b35d 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -8847,7 +8847,7 @@ lpfc_sli4_queue_unset(struct lpfc_hba *phba)
lpfc_wq_destroy(phba, phba->sli4_hba.nvmels_wq);
/* Unset ELS work queue */
- if (phba->sli4_hba.els_cq)
+ if (phba->sli4_hba.els_wq)
lpfc_wq_destroy(phba, phba->sli4_hba.els_wq);
/* Unset unsolicited receive queue */
--
2.11.0
[toc] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2017-05-09 04:20 +0200 |
| Message-ID | <tF2UN-3QW-5@gated-at.bofh.it> |
| In reply to | #1636998 |
Colin, > I believe there is a typo on the wq destroy of els_wq, currently the > driver is checking if els_cq is not null and I think this should be a > check on els_wq instead. Applied to 4.12/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web