Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1636940 > unrolled thread
| Started by | Jörg Otte <jrg.otte@gmail.com> |
|---|---|
| First post | 2017-05-06 17:50 +0200 |
| Last post | 2017-05-06 21:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[4.12.0-rc0]: compile error in initramfs.c Jörg Otte <jrg.otte@gmail.com> - 2017-05-06 17:50 +0200
Re: [4.12.0-rc0]: compile error in initramfs.c Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-06 19:30 +0200
Re: [4.12.0-rc0]: compile error in initramfs.c Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-06 19:50 +0200
Re: [4.12.0-rc0]: compile error in initramfs.c Stafford Horne <shorne@gmail.com> - 2017-05-06 21:00 +0200
| From | Jörg Otte <jrg.otte@gmail.com> |
|---|---|
| Date | 2017-05-06 17:50 +0200 |
| Subject | [4.12.0-rc0]: compile error in initramfs.c |
| Message-ID | <tEa82-1tT-25@gated-at.bofh.it> |
In kernel 4.11.0-10502-g3ef2bc0 I get following compile error: /kernel/linux/init/initramfs.c: In function 'populate_rootfs': /kernel/linux/init/initramfs.c:644:2: error: label at end of compound statement done: the compile error goes away if I revert commit 17a9be31747535184f2af156b1f080ec4c92a952 "initramfs: Always do fput() and load modules after rootfs populate" Thanks Jörg
[toc] | [next] | [standalone]
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Date | 2017-05-06 19:30 +0200 |
| Message-ID | <tEbGN-2tu-1@gated-at.bofh.it> |
| In reply to | #1636940 |
On Sat, May 6, 2017 at 8:40 AM, Jörg Otte <jrg.otte@gmail.com> wrote:
> In kernel 4.11.0-10502-g3ef2bc0 I get following compile error:
>
> /kernel/linux/init/initramfs.c: In function 'populate_rootfs':
> /kernel/linux/init/initramfs.c:644:2: error: label at end of compound statement
> done:
Ok,need to add an empty statement there.
I wonder why I didn't see that warning.
.. oh, it's because even my allmodconfig build just ends up having
CONFIG_BLK_DEV_RAM=m
rather than the built-in case.
Will fix.
Linus
[toc] | [prev] | [next] | [standalone]
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Date | 2017-05-06 19:50 +0200 |
| Message-ID | <tEc09-2C6-7@gated-at.bofh.it> |
| In reply to | #1636940 |
On Sat, May 6, 2017 at 10:28 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> A fix was posted here:
> http://marc.info/?l=linux-kernel&m=149405418520059&w=2
That looks like it will just cause a warning instead ("unused label").
The proper fix is to just add an empty statement. Pushing that out.
Linus
[toc] | [prev] | [next] | [standalone]
| From | Stafford Horne <shorne@gmail.com> |
|---|---|
| Date | 2017-05-06 21:00 +0200 |
| Message-ID | <tEd5T-3hy-1@gated-at.bofh.it> |
| In reply to | #1636957 |
On Sat, May 06, 2017 at 10:39:01AM -0700, Linus Torvalds wrote:
> On Sat, May 6, 2017 at 10:28 AM, Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > A fix was posted here:
> > http://marc.info/?l=linux-kernel&m=149405418520059&w=2
>
> That looks like it will just cause a warning instead ("unused label").
>
> The proper fix is to just add an empty statement. Pushing that out.
Thanks for getting that pushed out already, I was just about to send out my
patch. Yours is better as I didnt like moving that label out of the block
and being an unused label.
I guess this is my first brown paper bag bug,
Thanks again,
-Stafford
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web