Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1637409 > unrolled thread

Re: [PATCH] powerpc: fix distclean with Makefile.postlink

Started byMichael Ellerman <mpe@ellerman.id.au>
First post2017-05-08 14:00 +0200
Last post2017-05-08 23:40 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] powerpc: fix distclean with Makefile.postlink Michael Ellerman <mpe@ellerman.id.au> - 2017-05-08 14:00 +0200
    Re: [PATCH] powerpc: fix distclean with Makefile.postlink Horia Geantă <horia.geanta@nxp.com> - 2017-05-08 16:00 +0200
      Re: [PATCH] powerpc: fix distclean with Makefile.postlink Justin Forbes <jmforbes@linuxtx.org> - 2017-05-08 23:40 +0200

#1637409 — Re: [PATCH] powerpc: fix distclean with Makefile.postlink

FromMichael Ellerman <mpe@ellerman.id.au>
Date2017-05-08 14:00 +0200
SubjectRe: [PATCH] powerpc: fix distclean with Makefile.postlink
Message-ID<tEPuy-3tj-17@gated-at.bofh.it>
Horia Geantă <horia.geanta@nxp.com> writes:

> Makefile.postlink always includes include/config/auto.conf, however
> this file is not present in a clean kernel tree, causing make to fail:
>
> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
> make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
> make: *** [vmlinuxclean] Error 2
>
> Change the inclusion such that file not being found does not trigger
> an error.
>
> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")

I can't reproduce this. What exact steps are you doing? And what version
of Make?

cheers

[toc] | [next] | [standalone]


#1637454

FromHoria Geantă <horia.geanta@nxp.com>
Date2017-05-08 16:00 +0200
Message-ID<tERmG-4Cr-5@gated-at.bofh.it>
In reply to#1637409
On 5/8/2017 2:57 PM, Michael Ellerman wrote:
> Horia Geantă <horia.geanta@nxp.com> writes:
> 
>> Makefile.postlink always includes include/config/auto.conf, however
>> this file is not present in a clean kernel tree, causing make to fail:
>>
>> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
>> make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
>> make: *** [vmlinuxclean] Error 2
>>
>> Change the inclusion such that file not being found does not trigger
>> an error.
>>
>> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
> 
> I can't reproduce this. What exact steps are you doing? And what version
> of Make?
> 
Start with a clean kernel tree and then
make distclean
arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such
file or directory
make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
make: *** [vmlinuxclean] Error 2

make --version
GNU Make 3.82
Built for x86_64-redhat-linux-gnu
Copyright (C) 2010  Free Software Foundation, Inc.
[...]

The fix is basically the same as:
6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink

Regards,
Horia

[toc] | [prev] | [next] | [standalone]


#1637744

FromJustin Forbes <jmforbes@linuxtx.org>
Date2017-05-08 23:40 +0200
Message-ID<tEYxQ-SB-17@gated-at.bofh.it>
In reply to#1637454
On Mon, May 8, 2017 at 8:50 AM, Horia Geantă <horia.geanta@nxp.com> wrote:
> On 5/8/2017 2:57 PM, Michael Ellerman wrote:
>> Horia Geantă <horia.geanta@nxp.com> writes:
>>
>>> Makefile.postlink always includes include/config/auto.conf, however
>>> this file is not present in a clean kernel tree, causing make to fail:
>>>
>>> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or directory
>>> make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
>>> make: *** [vmlinuxclean] Error 2
>>>
>>> Change the inclusion such that file not being found does not trigger
>>> an error.
>>>
>>> Fixes: f188d0524d7e ("powerpc: Use the new post-link pass to check relocations")
>>
>> I can't reproduce this. What exact steps are you doing? And what version
>> of Make?
>>
> Start with a clean kernel tree and then
> make distclean
> arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such
> file or directory
> make[1]: *** No rule to make target `include/config/auto.conf'.  Stop.
> make: *** [vmlinuxclean] Error 2
>
> make --version
> GNU Make 3.82
> Built for x86_64-redhat-linux-gnu
> Copyright (C) 2010  Free Software Foundation, Inc.
> [...]
>
> The fix is basically the same as:
> 6e5b95cdbd0e MIPS: Fix distclean with Makefile.postlink
>

Noticed it on the Fedora builds as well today.  This patch fixes it.

Tested-by: Justin M. Forbes <jforbes@fedoraproject.org>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web