Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1637108 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2017-05-08 00:30 +0200 |
| Last post | 2017-05-08 22:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] xtensa: Use seq_puts() in c_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-08 00:30 +0200
Re: [PATCH] xtensa: Use seq_puts() in c_show() Max Filippov <jcmvbkbc@gmail.com> - 2017-05-08 22:20 +0200
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2017-05-08 00:30 +0200 |
| Subject | [PATCH] xtensa: Use seq_puts() in c_show() |
| Message-ID | <tECQG-3x1-7@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 7 May 2017 21:24:51 +0200 A string which did not contain a data format specification should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- arch/xtensa/kernel/setup.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c index 23ac2a205e97..44632a20f3d9 100644 --- a/arch/xtensa/kernel/setup.c +++ b/arch/xtensa/kernel/setup.c @@ -593,8 +593,7 @@ c_show(struct seq_file *f, void *slot) (ccount_freq/10000) % 100, loops_per_jiffy/(500000/HZ), (loops_per_jiffy/(5000/HZ)) % 100); - - seq_printf(f,"flags\t\t: " + seq_puts(f, "flags\t\t: " #if XCHAL_HAVE_NMI "nmi " #endif -- 2.12.2
[toc] | [next] | [standalone]
| From | Max Filippov <jcmvbkbc@gmail.com> |
|---|---|
| Date | 2017-05-08 22:20 +0200 |
| Message-ID | <tEXiq-8Y-13@gated-at.bofh.it> |
| In reply to | #1637108 |
On Sun, May 7, 2017 at 12:33 PM, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 7 May 2017 21:24:51 +0200 > > A string which did not contain a data format specification should be put > into a sequence. Thus use the corresponding function "seq_puts". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > arch/xtensa/kernel/setup.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks, applied to my xtensa-fixes branch. -- Max
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web