Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1637171 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-05-08 02:10 +0200 |
| Last post | 2017-05-08 17:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ipmi_ssif: remove redundant null check on array client->adapter->name Colin King <colin.king@canonical.com> - 2017-05-08 02:10 +0200
Re: [PATCH] ipmi_ssif: remove redundant null check on array client->adapter->name Corey Minyard <minyard@acm.org> - 2017-05-08 17:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-05-08 02:10 +0200 |
| Subject | [PATCH] ipmi_ssif: remove redundant null check on array client->adapter->name |
| Message-ID | <tEEpr-4L8-1@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The null check on client->adapter->name is redundant as name is an
array of I2C_NAME_SIZE chars and hence can never be null. We may as
well remove this redundant check.
Detected by CoverityScan, CID#1375918 ("Array compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/char/ipmi/ipmi_ssif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index 0b22a9be5029..d9243c5d2647 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1417,8 +1417,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr)
list_for_each_entry(info, &ssif_infos, link) {
if (info->binfo.addr != client->addr)
continue;
- if (info->adapter_name && client->adapter->name &&
- strcmp_nospace(info->adapter_name,
+ if (info->adapter_name && strcmp_nospace(info->adapter_name,
client->adapter->name))
continue;
if (info->slave_addr) {
--
2.11.0
[toc] | [next] | [standalone]
| From | Corey Minyard <minyard@acm.org> |
|---|---|
| Date | 2017-05-08 17:20 +0200 |
| Subject | Re: [PATCH] ipmi_ssif: remove redundant null check on array client->adapter->name |
| Message-ID | <tESC6-5Ad-25@gated-at.bofh.it> |
| In reply to | #1637171 |
On 05/07/2017 01:05 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The null check on client->adapter->name is redundant as name is an
> array of I2C_NAME_SIZE chars and hence can never be null. We may as
> well remove this redundant check.
Thanks Colin,
Queued for next merge window.
-corey
> Detected by CoverityScan, CID#1375918 ("Array compared against 0")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/char/ipmi/ipmi_ssif.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 0b22a9be5029..d9243c5d2647 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1417,8 +1417,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr)
> list_for_each_entry(info, &ssif_infos, link) {
> if (info->binfo.addr != client->addr)
> continue;
> - if (info->adapter_name && client->adapter->name &&
> - strcmp_nospace(info->adapter_name,
> + if (info->adapter_name && strcmp_nospace(info->adapter_name,
> client->adapter->name))
> continue;
> if (info->slave_addr) {
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web