Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637149 > unrolled thread

[PATCH 1/3] thermal: tegra: Combine two function calls into one in regs_show()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 1/3] thermal: tegra: Combine two function calls into one in  regs_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-08 01:30 +0200

#1637149 — [PATCH 1/3] thermal: tegra: Combine two function calls into one in regs_show()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 May 2017 10:50:35 +0200

A bit of data was put into a sequence by two separate function calls
at two places. Print the same data by single function calls instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/thermal/tegra/soctherm.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index 7d2db23d71a3..c5871f9b6596 100644
--- a/drivers/thermal/tegra/soctherm.c
+++ b/drivers/thermal/tegra/soctherm.c
@@ -706,9 +706,7 @@ static int regs_show(struct seq_file *s, void *data)
 	seq_printf(s, "PDIV: 0x%x\n", r);
 
 	r = readl(ts->regs + SENSOR_HOTSPOT_OFF);
-	seq_printf(s, "HOTSPOT: 0x%x\n", r);
-
-	seq_puts(s, "\n");
+	seq_printf(s, "HOTSPOT: 0x%x\n\n", r);
 	seq_puts(s, "-----SOC_THERM-----\n");
 
 	r = readl(ts->regs + SENSOR_TEMP1);
@@ -809,9 +807,7 @@ static int regs_show(struct seq_file *s, void *data)
 	}
 
 	r = readl(ts->regs + THROT_GLOBAL_CFG);
-	seq_puts(s, "\n");
-	seq_printf(s, "GLOBAL THROTTLE CONFIG: 0x%08x\n", r);
-
+	seq_printf(s, "\nGLOBAL THROTTLE CONFIG: 0x%08x\n", r);
 	seq_puts(s, "---------------------------------------------------\n");
 	r = readl(ts->regs + THROT_STATUS);
 	state = REG_GET_MASK(r, THROT_STATUS_BREACH_MASK);
-- 
2.12.2

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web