Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634033 > unrolled thread

[PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered

Started byEduardo Molinas <edu.molinas@gmail.com>
First post2017-05-02 00:50 +0200
Last post2017-05-08 00:10 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered Eduardo Molinas <edu.molinas@gmail.com> - 2017-05-02 00:50 +0200
    [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF devices are registered Eduardo Molinas <edu.molinas@gmail.com> - 2017-05-02 00:50 +0200
      Re: [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module  autoload when OF devices are registered Chen-Yu Tsai <wens@csie.org> - 2017-05-02 04:20 +0200
        Re: [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module  autoload when OF devices are registered Jonathan Cameron <jic23@kernel.org> - 2017-05-08 00:10 +0200
    Re: [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module  autoload when PLATFORM devices are registered Chen-Yu Tsai <wens@csie.org> - 2017-05-02 04:20 +0200
      Re: [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module  autoload when PLATFORM devices are registered Jonathan Cameron <jic23@kernel.org> - 2017-05-08 00:10 +0200

#1634033 — [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered

FromEduardo Molinas <edu.molinas@gmail.com>
Date2017-05-02 00:50 +0200
Subject[PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered
Message-ID<tCsiJ-6wM-7@gated-at.bofh.it>
If the driver is built as a module, it won't be autloaded if the devices
are registered via PLATFORM code because the PLATFORM device table
entries are not exported as aliases

Before the patch:
$ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
$

After th patch:
$ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
alias:          platform:sun6i-a31-gpadc-iio
alias:          platform:sun5i-a13-gpadc-iio
alias:          platform:sun4i-a10-gpadc-iio

Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>
---
---
 drivers/iio/adc/sun4i-gpadc-iio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c
index b23527309088..c3d7ba100a48 100644
--- a/drivers/iio/adc/sun4i-gpadc-iio.c
+++ b/drivers/iio/adc/sun4i-gpadc-iio.c
@@ -700,6 +700,7 @@ static const struct platform_device_id sun4i_gpadc_id[] = {
 	{ "sun6i-a31-gpadc-iio", (kernel_ulong_t)&sun6i_gpadc_data },
 	{ /* sentinel */ },
 };
+MODULE_DEVICE_TABLE(platform, sun4i_gpadc_id);
 
 static struct platform_driver sun4i_gpadc_driver = {
 	.driver = {
-- 
2.11.0

[toc] | [next] | [standalone]

#1634040 — [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF devices are registered

FromEduardo Molinas <edu.molinas@gmail.com>
Date2017-05-02 00:50 +0200
Subject[PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF devices are registered
Message-ID<tCsiK-6wM-25@gated-at.bofh.it>
In reply to#1634033
If the driver is built as a module, it won't be autloaded if the devices
are registered via OF code because the OF device table
entries are not exported as aliases

Before the patch:
$ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
alias:          platform:sun6i-a31-gpadc-iio
alias:          platform:sun5i-a13-gpadc-iio
alias:          platform:sun4i-a10-gpadc-iio

After the patch:
$ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
alias:          of:N*T*Callwinner,sun8i-a33-thsC*
alias:          of:N*T*Callwinner,sun8i-a33-ths
alias:          platform:sun6i-a31-gpadc-iio
alias:          platform:sun5i-a13-gpadc-iio
alias:          platform:sun4i-a10-gpadc-iio

Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>
---
---
 drivers/iio/adc/sun4i-gpadc-iio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c
index c3d7ba100a48..1c83b45043bf 100644
--- a/drivers/iio/adc/sun4i-gpadc-iio.c
+++ b/drivers/iio/adc/sun4i-gpadc-iio.c
@@ -712,6 +712,7 @@ static struct platform_driver sun4i_gpadc_driver = {
 	.probe = sun4i_gpadc_probe,
 	.remove = sun4i_gpadc_remove,
 };
+MODULE_DEVICE_TABLE(of, sun4i_gpadc_of_id);
 
 module_platform_driver(sun4i_gpadc_driver);
 
-- 
2.11.0

[toc] | [prev] | [next] | [standalone]

#1634083 — Re: [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF devices are registered

FromChen-Yu Tsai <wens@csie.org>
Date2017-05-02 04:20 +0200
SubjectRe: [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF devices are registered
Message-ID<tCvzY-hZ-5@gated-at.bofh.it>
In reply to#1634040
On Tue, May 2, 2017 at 6:45 AM, Eduardo Molinas <edu.molinas@gmail.com> wrote:
> If the driver is built as a module, it won't be autloaded if the devices
> are registered via OF code because the OF device table
> entries are not exported as aliases
>
> Before the patch:
> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
> alias:          platform:sun6i-a31-gpadc-iio
> alias:          platform:sun5i-a13-gpadc-iio
> alias:          platform:sun4i-a10-gpadc-iio
>
> After the patch:
> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
> alias:          of:N*T*Callwinner,sun8i-a33-thsC*
> alias:          of:N*T*Callwinner,sun8i-a33-ths
> alias:          platform:sun6i-a31-gpadc-iio
> alias:          platform:sun5i-a13-gpadc-iio
> alias:          platform:sun4i-a10-gpadc-iio
>
> Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

Can we merge this as a fix for 4.12?

[toc] | [prev] | [next] | [standalone]

#1637070 — Re: [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF devices are registered

FromJonathan Cameron <jic23@kernel.org>
Date2017-05-08 00:10 +0200
SubjectRe: [PATCH 2/2] [PATCH 2/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when OF devices are registered
Message-ID<tECxk-3oj-23@gated-at.bofh.it>
In reply to#1634083
On 02/05/17 03:09, Chen-Yu Tsai wrote:
> On Tue, May 2, 2017 at 6:45 AM, Eduardo Molinas <edu.molinas@gmail.com> wrote:
>> If the driver is built as a module, it won't be autloaded if the devices
>> are registered via OF code because the OF device table
>> entries are not exported as aliases
>>
>> Before the patch:
>> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
>> alias:          platform:sun6i-a31-gpadc-iio
>> alias:          platform:sun5i-a13-gpadc-iio
>> alias:          platform:sun4i-a10-gpadc-iio
>>
>> After the patch:
>> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
>> alias:          of:N*T*Callwinner,sun8i-a33-thsC*
>> alias:          of:N*T*Callwinner,sun8i-a33-ths
>> alias:          platform:sun6i-a31-gpadc-iio
>> alias:          platform:sun5i-a13-gpadc-iio
>> alias:          platform:sun4i-a10-gpadc-iio
>>
>> Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>
> 
> Can we merge this as a fix for 4.12?
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

[toc] | [prev] | [next] | [standalone]

#1634081 — Re: [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered

FromChen-Yu Tsai <wens@csie.org>
Date2017-05-02 04:20 +0200
SubjectRe: [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered
Message-ID<tCvzY-hZ-3@gated-at.bofh.it>
In reply to#1634033
On Tue, May 2, 2017 at 6:45 AM, Eduardo Molinas <edu.molinas@gmail.com> wrote:
> If the driver is built as a module, it won't be autloaded if the devices
> are registered via PLATFORM code because the PLATFORM device table
> entries are not exported as aliases
>
> Before the patch:
> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
> $
>
> After th patch:

        ^^ the

> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
> alias:          platform:sun6i-a31-gpadc-iio
> alias:          platform:sun5i-a13-gpadc-iio
> alias:          platform:sun4i-a10-gpadc-iio
>
> Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>

Can we merge this as a fix for 4.12?

[toc] | [prev] | [next] | [standalone]

#1637087 — Re: [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered

FromJonathan Cameron <jic23@kernel.org>
Date2017-05-08 00:10 +0200
SubjectRe: [PATCH 1/2] [PATCH 1/2] iio: adc: sun4i-gpadc-iio: Fix module autoload when PLATFORM devices are registered
Message-ID<tECxl-3oj-61@gated-at.bofh.it>
In reply to#1634081
On 02/05/17 03:10, Chen-Yu Tsai wrote:
> On Tue, May 2, 2017 at 6:45 AM, Eduardo Molinas <edu.molinas@gmail.com> wrote:
>> If the driver is built as a module, it won't be autloaded if the devices
>> are registered via PLATFORM code because the PLATFORM device table
>> entries are not exported as aliases
>>
>> Before the patch:
>> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
>> $
>>
>> After th patch:
> 
>         ^^ the
> 
>> $ modinfo drivers/iio/adc/sun4i-gpadc-iio.ko | grep alias
>> alias:          platform:sun6i-a31-gpadc-iio
>> alias:          platform:sun5i-a13-gpadc-iio
>> alias:          platform:sun4i-a10-gpadc-iio
>>
>> Signed-off-by: Eduardo Molinas <edu.molinas@gmail.com>
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>
> 
> Can we merge this as a fix for 4.12?
Applied to fixes-togreg branch of iio.git.

Thanks,

Jonathan
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web