Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637031 > unrolled thread

Re: [PATCH] char: random: casting prevents missing calculations

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] char: random: casting prevents missing calculations Arnd Bergmann <arnd@arndb.de> - 2017-05-07 23:50 +0200

#1637031 — Re: [PATCH] char: random: casting prevents missing calculations

On Sun, May 7, 2017 at 2:47 PM, Karim Eshapa <karim.eshapa@gmail.com> wrote:
> Cast (long)jiffies and (long)state->last_time beacause
> they tends to unsigned long. may cause a problem specially
> when comparison happens (< 0).
>
> Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>

I don't understand what you are saying above, and the patch does not
appear to have any effect since the destination variable is already of
type 'long'.

What problem did you observe?

       Arnd

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web