Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637008 > unrolled thread

Re: [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be called only once

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be  called only once Pavel Machek <pavel@ucw.cz> - 2017-05-07 23:40 +0200
    Re: [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be called  only once Keerthy <j-keerthy@ti.com> - 2017-05-08 06:30 +0200

#1637008 — Re: [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be called only once

> thermal_zone_device_check --> thermal_zone_device_update -->
> handle_thermal_trip --> handle_critical_trips --> orderly_poweroff
> 
> The above sequence happens every 250/500 mS based on the configuration.
> The orderly_poweroff function is getting called every 250/500 mS.
> With a full fledged file system it takes at least 5-10 Seconds to
> power off gracefully.
> 
> In that period due to the thermal_zone_device_check triggering
> periodically the thermal work queues bombard with
> orderly_poweroff calls multiple times eventually leading to
> failures in gracefully powering off the system.
> 
> Make sure that orderly_poweroff is called only once.

Pretty please, can we do it in the core code, not in thermal/? There
are other reasons kernel may want to shut the system down, like for
example critical battery, and if both thermal _and_ bad battery
happen, we want just one shutdown...

> Reported-by: Keerthy <j-keerthy@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>

And here probably we need your full name.

Thanks,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [next] | [standalone]

#1637205 — Re: [PATCH v3 1/2] thermal: core: Allow orderly_poweroff to be called only once

On Monday 08 May 2017 02:32 AM, Pavel Machek wrote:
>> thermal_zone_device_check --> thermal_zone_device_update -->
>> handle_thermal_trip --> handle_critical_trips --> orderly_poweroff
>>
>> The above sequence happens every 250/500 mS based on the configuration.
>> The orderly_poweroff function is getting called every 250/500 mS.
>> With a full fledged file system it takes at least 5-10 Seconds to
>> power off gracefully.
>>
>> In that period due to the thermal_zone_device_check triggering
>> periodically the thermal work queues bombard with
>> orderly_poweroff calls multiple times eventually leading to
>> failures in gracefully powering off the system.
>>
>> Make sure that orderly_poweroff is called only once.
> 
> Pretty please, can we do it in the core code, not in thermal/? There
> are other reasons kernel may want to shut the system down, like for
> example critical battery, and if both thermal _and_ bad battery
> happen, we want just one shutdown...

Pavel,

Thermal fix is still valid. As it is having multiple calls.
I can work on fixing the core code as well.

BTW the latest of this series is v6:

https://patchwork.kernel.org/patch/9684929/


- Keerthy

> 
>> Reported-by: Keerthy <j-keerthy@ti.com>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
> 
> And here probably we need your full name.
> 
> Thanks,
> 								Pavel
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web