Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1636014 > unrolled thread

[PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with COMPILE_TEST

Started byCyrille Pitchen <cyrille.pitchen@wedev4u.fr>
First post2017-05-04 22:20 +0200
Last post2017-05-10 12:30 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with COMPILE_TEST Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> - 2017-05-04 22:20 +0200
    Re: [PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with  COMPILE_TEST Ludovic BARRE <ludovic.barre@st.com> - 2017-05-05 09:40 +0200
    Re: [PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with  COMPILE_TEST Cyrille Pitchen <cyrille.pitchen@wedev4u.fr> - 2017-05-10 12:30 +0200

#1636014 — [PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with COMPILE_TEST

FromCyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Date2017-05-04 22:20 +0200
Subject[PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with COMPILE_TEST
Message-ID<tDvoe-8mr-3@gated-at.bofh.it>
This patch fixes some compiler errors:
- change format strings to use %zx for size_t
- add missing #include <linux/sizes.h>

Cc: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
---
 drivers/mtd/spi-nor/stm32-quadspi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
index 1056e7408d2a..86c0931543c5 100644
--- a/drivers/mtd/spi-nor/stm32-quadspi.c
+++ b/drivers/mtd/spi-nor/stm32-quadspi.c
@@ -19,6 +19,7 @@
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/reset.h>
+#include <linux/sizes.h>
 
 #define QUADSPI_CR		0x00
 #define CR_EN			BIT(0)
@@ -375,7 +376,7 @@ static ssize_t stm32_qspi_read(struct spi_nor *nor, loff_t from, size_t len,
 	struct stm32_qspi_cmd cmd;
 	int err;
 
-	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#x\n",
+	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#zx\n",
 		nor->read_opcode, buf, (u32)from, len);
 
 	memset(&cmd, 0, sizeof(cmd));
@@ -402,7 +403,7 @@ static ssize_t stm32_qspi_write(struct spi_nor *nor, loff_t to, size_t len,
 	struct stm32_qspi_cmd cmd;
 	int err;
 
-	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#x\n",
+	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#zx\n",
 		nor->program_opcode, buf, (u32)to, len);
 
 	memset(&cmd, 0, sizeof(cmd));
-- 
2.9.3

[toc] | [next] | [standalone]


#1636214 — Re: [PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with COMPILE_TEST

FromLudovic BARRE <ludovic.barre@st.com>
Date2017-05-05 09:40 +0200
SubjectRe: [PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with COMPILE_TEST
Message-ID<tDG0i-75x-27@gated-at.bofh.it>
In reply to#1636014
On 05/04/2017 09:39 PM, Cyrille Pitchen wrote:
> This patch fixes some compiler errors:
> - change format strings to use %zx for size_t
> - add missing #include <linux/sizes.h>
>
> Cc: Ludovic Barre <ludovic.barre@st.com>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
> ---
>   drivers/mtd/spi-nor/stm32-quadspi.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
> index 1056e7408d2a..86c0931543c5 100644
> --- a/drivers/mtd/spi-nor/stm32-quadspi.c
> +++ b/drivers/mtd/spi-nor/stm32-quadspi.c
> @@ -19,6 +19,7 @@
>   #include <linux/of_device.h>
>   #include <linux/platform_device.h>
>   #include <linux/reset.h>
> +#include <linux/sizes.h>
>   
>   #define QUADSPI_CR		0x00
>   #define CR_EN			BIT(0)
> @@ -375,7 +376,7 @@ static ssize_t stm32_qspi_read(struct spi_nor *nor, loff_t from, size_t len,
>   	struct stm32_qspi_cmd cmd;
>   	int err;
>   
> -	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#x\n",
> +	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#zx\n",
>   		nor->read_opcode, buf, (u32)from, len);
>   
>   	memset(&cmd, 0, sizeof(cmd));
> @@ -402,7 +403,7 @@ static ssize_t stm32_qspi_write(struct spi_nor *nor, loff_t to, size_t len,
>   	struct stm32_qspi_cmd cmd;
>   	int err;
>   
> -	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#x\n",
> +	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#zx\n",
>   		nor->program_opcode, buf, (u32)to, len);
>   
>   	memset(&cmd, 0, sizeof(cmd));
Reviewed-by: Ludovic Barre <ludovic.barre@st.com>

[toc] | [prev] | [next] | [standalone]


#1638733 — Re: [PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with COMPILE_TEST

FromCyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Date2017-05-10 12:30 +0200
SubjectRe: [PATCH] mtd: spi-nor: stm32-quadspi: fix compiler errors with COMPILE_TEST
Message-ID<tFx2y-7VY-7@gated-at.bofh.it>
In reply to#1636014
Le 04/05/2017 à 21:39, Cyrille Pitchen a écrit :
> This patch fixes some compiler errors:
> - change format strings to use %zx for size_t
> - add missing #include <linux/sizes.h>
> 
> Cc: Ludovic Barre <ludovic.barre@st.com>
> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>

Applied to the github/spi-nor tree


> ---
>  drivers/mtd/spi-nor/stm32-quadspi.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
> index 1056e7408d2a..86c0931543c5 100644
> --- a/drivers/mtd/spi-nor/stm32-quadspi.c
> +++ b/drivers/mtd/spi-nor/stm32-quadspi.c
> @@ -19,6 +19,7 @@
>  #include <linux/of_device.h>
>  #include <linux/platform_device.h>
>  #include <linux/reset.h>
> +#include <linux/sizes.h>
>  
>  #define QUADSPI_CR		0x00
>  #define CR_EN			BIT(0)
> @@ -375,7 +376,7 @@ static ssize_t stm32_qspi_read(struct spi_nor *nor, loff_t from, size_t len,
>  	struct stm32_qspi_cmd cmd;
>  	int err;
>  
> -	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#x\n",
> +	dev_dbg(qspi->dev, "read(%#.2x): buf:%p from:%#.8x len:%#zx\n",
>  		nor->read_opcode, buf, (u32)from, len);
>  
>  	memset(&cmd, 0, sizeof(cmd));
> @@ -402,7 +403,7 @@ static ssize_t stm32_qspi_write(struct spi_nor *nor, loff_t to, size_t len,
>  	struct stm32_qspi_cmd cmd;
>  	int err;
>  
> -	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#x\n",
> +	dev_dbg(dev, "write(%#.2x): buf:%p to:%#.8x len:%#zx\n",
>  		nor->program_opcode, buf, (u32)to, len);
>  
>  	memset(&cmd, 0, sizeof(cmd));
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web