Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634060 > unrolled thread

[PATCH v2 0/7] staging: rtl8732: Various checkpatch fixes

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/7] staging: rtl8732: Various checkpatch fixes Justin Vreeland <justin@jvreeland.com> - 2017-05-02 03:00 +0200
    [PATCH v2 5/7] staging: rtl8723bs: Fix pointer style Justin Vreeland <justin@jvreeland.com> - 2017-05-02 03:00 +0200
    Re: [PATCH v2 0/7] staging: rtl8732: Various checkpatch fixes Bastien Nocera <hadess@hadess.net> - 2017-05-04 14:00 +0200

#1634060 — [PATCH v2 0/7] staging: rtl8732: Various checkpatch fixes

v2:
  Added commit messages
  Fixed overly long lines
  Added Bastien Nocera's Reviewed-by tag
    - Also fixed commit messages marked reviewed, hope that's OK. The patch
      contents are identical.

Justin Vreeland (7):
  staging: rtl8723bs: Fix initialization of static variables
  staging: rtl8723bs: Wrap multi-line macros in do-while loop
  staging: rtl8723bs: Macros with complex values should be enclosed in
    parentheses
  staging: rtl8723bs: Move braces to same line as conditional
  staging: rtl8723bs: Fix pointer style
  staging: rtl8723bs: Fix spacing around '<'
  staging: rtl8723bs: Do not use assignment in if condition

 drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c |  8 +--
 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c |  4 +-
 drivers/staging/rtl8723bs/hal/hal_btcoex.c      |  2 +-
 drivers/staging/rtl8723bs/hal/odm.h             |  5 +-
 drivers/staging/rtl8723bs/hal/odm_DIG.c         |  2 +-
 drivers/staging/rtl8723bs/hal/odm_debug.h       | 81 ++++++++++++++-----------
 drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 18 +++---
 drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 12 ++--
 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c  | 20 +++---
 9 files changed, 81 insertions(+), 71 deletions(-)

-- 
2.12.2

[toc] | [next] | [standalone]

#1634061 — [PATCH v2 5/7] staging: rtl8723bs: Fix pointer style

Fix "(foo*)" should be "(foo *)"
Fix "foo * bar" should be "foo *bar"

Signed-off-by: Justin Vreeland <justin@jvreeland.com>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
---
v2:
  - Added Reviewed-by tag

 drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
index 505e122bdfb5..7978a987b31c 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
@@ -58,7 +58,7 @@ static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
 	struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
 	struct dvobj_priv *pdvobjpriv = adapter_to_dvobj(padapter);
 	struct xmit_buf *pxmitbuf;
-	struct adapter * pri_padapter = padapter;
+	struct adapter *pri_padapter = padapter;
 	s32 ret = 0;
 	u8 PageIdx = 0;
 	u32 deviceId;
@@ -301,7 +301,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
 						if (pxmitbuf->len > 0 &&
 						    pxmitbuf->priv_data) {
 							struct xmit_frame *pframe;
-							pframe = (struct xmit_frame*)pxmitbuf->priv_data;
+							pframe = (struct xmit_frame *)pxmitbuf->priv_data;
 							pframe->agg_num = k;
 							pxmitbuf->agg_num = k;
 							rtl8723b_update_txdesc(pframe, pframe->buf_addr);
@@ -392,7 +392,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, struct xmit_priv *pxmitpriv
 
 			if (pxmitbuf->len > 0) {
 				struct xmit_frame *pframe;
-				pframe = (struct xmit_frame*)pxmitbuf->priv_data;
+				pframe = (struct xmit_frame *)pxmitbuf->priv_data;
 				pframe->agg_num = k;
 				pxmitbuf->agg_num = k;
 				rtl8723b_update_txdesc(pframe, pframe->buf_addr);
-- 
2.12.2

[toc] | [prev] | [next] | [standalone]

#1635678

On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
> v2:
>   Added commit messages
>   Fixed overly long lines
>   Added Bastien Nocera's Reviewed-by tag
>     - Also fixed commit messages marked reviewed, hope that's OK. The
> patch
>       contents are identical.
> 
> Justin Vreeland (7):
>   staging: rtl8723bs: Fix initialization of static variables
>   staging: rtl8723bs: Wrap multi-line macros in do-while loop

You can add:
Reviewed-by: Bastien Nocera <hadess@hadess.net>
for those 2.

Cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web