Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1635103 > unrolled thread
| Started by | Chao Yu <chao@kernel.org> |
|---|---|
| First post | 2017-05-03 18:10 +0200 |
| Last post | 2017-05-04 03:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/3] f2fs: enhance scalability of trace macro Chao Yu <chao@kernel.org> - 2017-05-03 18:10 +0200
Re: [PATCH 3/3] f2fs: enhance scalability of trace macro Jaegeuk Kim <jaegeuk@kernel.org> - 2017-05-03 20:50 +0200
Re: [PATCH 3/3] f2fs: enhance scalability of trace macro Chao Yu <yuchao0@huawei.com> - 2017-05-04 03:30 +0200
| From | Chao Yu <chao@kernel.org> |
|---|---|
| Date | 2017-05-03 18:10 +0200 |
| Subject | [PATCH 3/3] f2fs: enhance scalability of trace macro |
| Message-ID | <tD50J-7GP-11@gated-at.bofh.it> |
From: Chao Yu <yuchao0@huawei.com>
Use __print_flags in show_bio_op_flags and show_cpreason instead of
__print_symbolic, it enables tracer function traverses and shows all
bits in the flag.
Additionally, add missing REQ_FUA into F2FS_OP_FLAGS.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
include/trace/events/f2fs.h | 29 ++++++++++++++---------------
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
index c78a223a0d9c..ad4cbeeeef44 100644
--- a/include/trace/events/f2fs.h
+++ b/include/trace/events/f2fs.h
@@ -59,8 +59,8 @@ TRACE_DEFINE_ENUM(CP_TRIMMED);
{ IPU, "IN-PLACE" }, \
{ OPU, "OUT-OF-PLACE" })
-#define F2FS_OP_FLAGS (REQ_RAHEAD | REQ_SYNC | REQ_PREFLUSH | REQ_META |\
- REQ_PRIO)
+#define F2FS_OP_FLAGS (REQ_RAHEAD | REQ_SYNC | REQ_META | REQ_PRIO | \
+ REQ_PREFLUSH | REQ_FUA)
#define F2FS_BIO_FLAG_MASK(t) (t & F2FS_OP_FLAGS)
#define show_bio_type(op,op_flags) show_bio_op(op), \
@@ -79,15 +79,13 @@ TRACE_DEFINE_ENUM(CP_TRIMMED);
{ REQ_OP_WRITE_ZEROES, "WRITE_ZEROES" })
#define show_bio_op_flags(flags) \
- __print_symbolic(F2FS_BIO_FLAG_MASK(flags), \
- { REQ_RAHEAD, "(RA)" }, \
- { REQ_SYNC, "(S)" }, \
- { REQ_SYNC | REQ_PRIO, "(SP)" }, \
- { REQ_META, "(M)" }, \
- { REQ_META | REQ_PRIO, "(MP)" }, \
- { REQ_SYNC | REQ_PREFLUSH , "(SF)" }, \
- { REQ_SYNC | REQ_META | REQ_PRIO, "(SMP)" }, \
- { REQ_PREFLUSH | REQ_META | REQ_PRIO, "(FMP)" }, \
+ __print_flags(F2FS_BIO_FLAG_MASK(flags), "|", \
+ { REQ_RAHEAD, "R" }, \
+ { REQ_SYNC, "S" }, \
+ { REQ_META, "M" }, \
+ { REQ_PRIO, "P" }, \
+ { REQ_PREFLUSH, "PF" }, \
+ { REQ_FUA, "FUA" }, \
{ 0, " \b" })
#define show_data_type(type) \
@@ -121,13 +119,14 @@ TRACE_DEFINE_ENUM(CP_TRIMMED);
{ GC_CB, "Cost-Benefit" })
#define show_cpreason(type) \
- __print_symbolic(type, \
+ __print_flags(type, "|", \
{ CP_UMOUNT, "Umount" }, \
{ CP_FASTBOOT, "Fastboot" }, \
{ CP_SYNC, "Sync" }, \
{ CP_RECOVERY, "Recovery" }, \
{ CP_DISCARD, "Discard" }, \
- { CP_UMOUNT | CP_TRIMMED, "Umount,Trimmed" })
+ { CP_UMOUNT, "Umount" }, \
+ { CP_TRIMMED, "Trimmed" })
struct victim_sel_policy;
struct f2fs_map_blocks;
@@ -774,7 +773,7 @@ DECLARE_EVENT_CLASS(f2fs__submit_page_bio,
),
TP_printk("dev = (%d,%d), ino = %lu, page_index = 0x%lx, "
- "oldaddr = 0x%llx, newaddr = 0x%llx, rw = %s%s, type = %s",
+ "oldaddr = 0x%llx, newaddr = 0x%llx, rw = %s,%s, type = %s",
show_dev_ino(__entry),
(unsigned long)__entry->index,
(unsigned long long)__entry->old_blkaddr,
@@ -827,7 +826,7 @@ DECLARE_EVENT_CLASS(f2fs__bio,
__entry->size = bio->bi_iter.bi_size;
),
- TP_printk("dev = (%d,%d)/(%d,%d), rw = %s%s, %s, sector = %lld, size = %u",
+ TP_printk("dev = (%d,%d)/(%d,%d), rw = %s,%s, %s, sector = %lld, size = %u",
show_dev(__entry->target),
show_dev(__entry->dev),
show_bio_type(__entry->op, __entry->op_flags),
--
2.12.2.575.gb14f27f
[toc] | [next] | [standalone]
| From | Jaegeuk Kim <jaegeuk@kernel.org> |
|---|---|
| Date | 2017-05-03 20:50 +0200 |
| Message-ID | <tD7vA-Hg-11@gated-at.bofh.it> |
| In reply to | #1635103 |
Hi Chao,
On 05/03, Chao Yu wrote:
> From: Chao Yu <yuchao0@huawei.com>
>
> Use __print_flags in show_bio_op_flags and show_cpreason instead of
> __print_symbolic, it enables tracer function traverses and shows all
> bits in the flag.
>
> Additionally, add missing REQ_FUA into F2FS_OP_FLAGS.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> include/trace/events/f2fs.h | 29 ++++++++++++++---------------
> 1 file changed, 14 insertions(+), 15 deletions(-)
>
> diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
> index c78a223a0d9c..ad4cbeeeef44 100644
> --- a/include/trace/events/f2fs.h
> +++ b/include/trace/events/f2fs.h
> @@ -59,8 +59,8 @@ TRACE_DEFINE_ENUM(CP_TRIMMED);
> { IPU, "IN-PLACE" }, \
> { OPU, "OUT-OF-PLACE" })
>
> -#define F2FS_OP_FLAGS (REQ_RAHEAD | REQ_SYNC | REQ_PREFLUSH | REQ_META |\
> - REQ_PRIO)
> +#define F2FS_OP_FLAGS (REQ_RAHEAD | REQ_SYNC | REQ_META | REQ_PRIO | \
> + REQ_PREFLUSH | REQ_FUA)
> #define F2FS_BIO_FLAG_MASK(t) (t & F2FS_OP_FLAGS)
>
> #define show_bio_type(op,op_flags) show_bio_op(op), \
> @@ -79,15 +79,13 @@ TRACE_DEFINE_ENUM(CP_TRIMMED);
> { REQ_OP_WRITE_ZEROES, "WRITE_ZEROES" })
>
> #define show_bio_op_flags(flags) \
> - __print_symbolic(F2FS_BIO_FLAG_MASK(flags), \
> - { REQ_RAHEAD, "(RA)" }, \
> - { REQ_SYNC, "(S)" }, \
> - { REQ_SYNC | REQ_PRIO, "(SP)" }, \
> - { REQ_META, "(M)" }, \
> - { REQ_META | REQ_PRIO, "(MP)" }, \
> - { REQ_SYNC | REQ_PREFLUSH , "(SF)" }, \
> - { REQ_SYNC | REQ_META | REQ_PRIO, "(SMP)" }, \
> - { REQ_PREFLUSH | REQ_META | REQ_PRIO, "(FMP)" }, \
> + __print_flags(F2FS_BIO_FLAG_MASK(flags), "|", \
> + { REQ_RAHEAD, "R" }, \
> + { REQ_SYNC, "S" }, \
> + { REQ_META, "M" }, \
> + { REQ_PRIO, "P" }, \
> + { REQ_PREFLUSH, "PF" }, \
> + { REQ_FUA, "FUA" }, \
> { 0, " \b" })
We don't need the above last entry.
>
> #define show_data_type(type) \
> @@ -121,13 +119,14 @@ TRACE_DEFINE_ENUM(CP_TRIMMED);
> { GC_CB, "Cost-Benefit" })
>
> #define show_cpreason(type) \
> - __print_symbolic(type, \
> + __print_flags(type, "|", \
> { CP_UMOUNT, "Umount" }, \
> { CP_FASTBOOT, "Fastboot" }, \
> { CP_SYNC, "Sync" }, \
> { CP_RECOVERY, "Recovery" }, \
> { CP_DISCARD, "Discard" }, \
> - { CP_UMOUNT | CP_TRIMMED, "Umount,Trimmed" })
> + { CP_UMOUNT, "Umount" }, \
> + { CP_TRIMMED, "Trimmed" })
>
> struct victim_sel_policy;
> struct f2fs_map_blocks;
> @@ -774,7 +773,7 @@ DECLARE_EVENT_CLASS(f2fs__submit_page_bio,
> ),
>
> TP_printk("dev = (%d,%d), ino = %lu, page_index = 0x%lx, "
> - "oldaddr = 0x%llx, newaddr = 0x%llx, rw = %s%s, type = %s",
> + "oldaddr = 0x%llx, newaddr = 0x%llx, rw = %s,%s, type = %s",
How about showing this like %s(%s) ?
> show_dev_ino(__entry),
> (unsigned long)__entry->index,
> (unsigned long long)__entry->old_blkaddr,
> @@ -827,7 +826,7 @@ DECLARE_EVENT_CLASS(f2fs__bio,
> __entry->size = bio->bi_iter.bi_size;
> ),
>
> - TP_printk("dev = (%d,%d)/(%d,%d), rw = %s%s, %s, sector = %lld, size = %u",
> + TP_printk("dev = (%d,%d)/(%d,%d), rw = %s,%s, %s, sector = %lld, size = %u",
ditto.
Thanks,
> show_dev(__entry->target),
> show_dev(__entry->dev),
> show_bio_type(__entry->op, __entry->op_flags),
> --
> 2.12.2.575.gb14f27f
[toc] | [prev] | [next] | [standalone]
| From | Chao Yu <yuchao0@huawei.com> |
|---|---|
| Date | 2017-05-04 03:30 +0200 |
| Message-ID | <tDdKG-4Wr-7@gated-at.bofh.it> |
| In reply to | #1635205 |
Hi Jaegeuk,
On 2017/5/4 2:47, Jaegeuk Kim wrote:
> Hi Chao,
>
> On 05/03, Chao Yu wrote:
>> From: Chao Yu <yuchao0@huawei.com>
>>
>> Use __print_flags in show_bio_op_flags and show_cpreason instead of
>> __print_symbolic, it enables tracer function traverses and shows all
>> bits in the flag.
>>
>> Additionally, add missing REQ_FUA into F2FS_OP_FLAGS.
>>
>> Signed-off-by: Chao Yu <yuchao0@huawei.com>
>> ---
>> include/trace/events/f2fs.h | 29 ++++++++++++++---------------
>> 1 file changed, 14 insertions(+), 15 deletions(-)
>>
>> diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
>> index c78a223a0d9c..ad4cbeeeef44 100644
>> --- a/include/trace/events/f2fs.h
>> +++ b/include/trace/events/f2fs.h
>> @@ -59,8 +59,8 @@ TRACE_DEFINE_ENUM(CP_TRIMMED);
>> { IPU, "IN-PLACE" }, \
>> { OPU, "OUT-OF-PLACE" })
>>
>> -#define F2FS_OP_FLAGS (REQ_RAHEAD | REQ_SYNC | REQ_PREFLUSH | REQ_META |\
>> - REQ_PRIO)
>> +#define F2FS_OP_FLAGS (REQ_RAHEAD | REQ_SYNC | REQ_META | REQ_PRIO | \
>> + REQ_PREFLUSH | REQ_FUA)
>> #define F2FS_BIO_FLAG_MASK(t) (t & F2FS_OP_FLAGS)
>>
>> #define show_bio_type(op,op_flags) show_bio_op(op), \
>> @@ -79,15 +79,13 @@ TRACE_DEFINE_ENUM(CP_TRIMMED);
>> { REQ_OP_WRITE_ZEROES, "WRITE_ZEROES" })
>>
>> #define show_bio_op_flags(flags) \
>> - __print_symbolic(F2FS_BIO_FLAG_MASK(flags), \
>> - { REQ_RAHEAD, "(RA)" }, \
>> - { REQ_SYNC, "(S)" }, \
>> - { REQ_SYNC | REQ_PRIO, "(SP)" }, \
>> - { REQ_META, "(M)" }, \
>> - { REQ_META | REQ_PRIO, "(MP)" }, \
>> - { REQ_SYNC | REQ_PREFLUSH , "(SF)" }, \
>> - { REQ_SYNC | REQ_META | REQ_PRIO, "(SMP)" }, \
>> - { REQ_PREFLUSH | REQ_META | REQ_PRIO, "(FMP)" }, \
>> + __print_flags(F2FS_BIO_FLAG_MASK(flags), "|", \
>> + { REQ_RAHEAD, "R" }, \
>> + { REQ_SYNC, "S" }, \
>> + { REQ_META, "M" }, \
>> + { REQ_PRIO, "P" }, \
>> + { REQ_PREFLUSH, "PF" }, \
>> + { REQ_FUA, "FUA" }, \
>> { 0, " \b" })
>
> We don't need the above last entry.
Agreed.
>
>>
>> #define show_data_type(type) \
>> @@ -121,13 +119,14 @@ TRACE_DEFINE_ENUM(CP_TRIMMED);
>> { GC_CB, "Cost-Benefit" })
>>
>> #define show_cpreason(type) \
>> - __print_symbolic(type, \
>> + __print_flags(type, "|", \
>> { CP_UMOUNT, "Umount" }, \
>> { CP_FASTBOOT, "Fastboot" }, \
>> { CP_SYNC, "Sync" }, \
>> { CP_RECOVERY, "Recovery" }, \
>> { CP_DISCARD, "Discard" }, \
>> - { CP_UMOUNT | CP_TRIMMED, "Umount,Trimmed" })
>> + { CP_UMOUNT, "Umount" }, \
>> + { CP_TRIMMED, "Trimmed" })
>>
>> struct victim_sel_policy;
>> struct f2fs_map_blocks;
>> @@ -774,7 +773,7 @@ DECLARE_EVENT_CLASS(f2fs__submit_page_bio,
>> ),
>>
>> TP_printk("dev = (%d,%d), ino = %lu, page_index = 0x%lx, "
>> - "oldaddr = 0x%llx, newaddr = 0x%llx, rw = %s%s, type = %s",
>> + "oldaddr = 0x%llx, newaddr = 0x%llx, rw = %s,%s, type = %s",
>
> How about showing this like %s(%s) ?
OK, let do the change in next version.
thanks,
>
>> show_dev_ino(__entry),
>> (unsigned long)__entry->index,
>> (unsigned long long)__entry->old_blkaddr,
>> @@ -827,7 +826,7 @@ DECLARE_EVENT_CLASS(f2fs__bio,
>> __entry->size = bio->bi_iter.bi_size;
>> ),
>>
>> - TP_printk("dev = (%d,%d)/(%d,%d), rw = %s%s, %s, sector = %lld, size = %u",
>> + TP_printk("dev = (%d,%d)/(%d,%d), rw = %s,%s, %s, sector = %lld, size = %u",
>
> ditto.
>
> Thanks,
>
>> show_dev(__entry->target),
>> show_dev(__entry->dev),
>> show_bio_type(__entry->op, __entry->op_flags),
>> --
>> 2.12.2.575.gb14f27f
>
> .
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web