Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1636362 > unrolled thread

[V1] staging : media : fixed macro expansion error

Back to article view | Back to linux.kernel

Contents

  [V1] staging : media : fixed macro expansion error Surender Polsani <surenderpolsani@gmail.com> - 2017-05-05 15:00 +0200
    Re: [V1] staging : media : fixed macro expansion error Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-05 15:10 +0200

#1636362 — [V1] staging : media : fixed macro expansion error

enclosing complex macro expansion with parentheses is
meaningfull according kernel coding style

Signed-off-by: Surender Polsani <surenderpolsani@gmail.com>
---
 drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 375c617..b9cafbb 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2001,8 +2001,8 @@ static irqreturn_t bcm2048_handler(int irq, void *dev)
 }
 
 #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check)		\
-property_write(prop, signal size, mask, check)				\
-property_read(prop, size, mask)
+(property_write(prop, signal size, mask, check)				\
+property_read(prop, size, mask))
 
 #define property_str_read(prop, size)					\
 static ssize_t bcm2048_##prop##_read(struct device *dev,		\
-- 
1.9.1

[toc] | [next] | [standalone]

#1636367

>  #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check)		\
> -property_write(prop, signal size, mask, check)				\
> -property_read(prop, size, mask)
> +(property_write(prop, signal size, mask, check)				\
> +property_read(prop, size, mask))

breaks the build.

regards,
dan carpenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web