Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1636129 > unrolled thread

[GIT PULL] liblockdep for 4.12

Back to article view | Back to linux.kernel

Contents

  [GIT PULL] liblockdep for 4.12 alexander.levin@verizon.com - 2017-05-05 05:00 +0200
    Re: [GIT PULL] liblockdep for 4.12 Ingo Molnar <mingo@kernel.org> - 2017-05-05 08:20 +0200
      Re: [GIT PULL] liblockdep for 4.12 alexander.levin@verizon.com - 2017-05-08 01:10 +0200
        Re: [GIT PULL] liblockdep for 4.12 Ingo Molnar <mingo@kernel.org> - 2017-05-08 08:20 +0200

#1636129 — [GIT PULL] liblockdep for 4.12

Hi Ingo,

Please pull fixes for liblockdep.

===

The following changes since commit a351e9b9fc24e982ec2f0e76379a49826036da12:

  Linux 4.11 (2017-04-30 19:47:48 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes

for you to fetch changes up to ec3cedc646ea697c849fe651f62ed448760ea569:

  tools: liblockdep: Use LDFLAGS (2017-05-04 21:34:07 -0400)

----------------------------------------------------------------
Alexander Sverdlin (2):
      tools: add install make target for liblockdep
      tools: liblockdep: Don't mix fd-based and stream IO

Ben Hutchings (10):
      liblockdep: Fix undefined symbol prandom_u32
      liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain::depth
      liblockdep: Define the ARRAY_SIZE() macro
      liblockdep: Enable -Wall by default
      liblockdep: Fix 'unused value' warnings
      liblockdep: Fix 'set but not used' warnings
      liblockdep: Fix 'defined but not used' warning for init_utsname()
      tools: liblockdep: Fix object file paths used in an out-of-tree build
      tools: liblockdep: Remove double-quotes from soname
      tools: liblockdep: Use LDFLAGS

Sasha Levin (2):
      MAINTAINERS: update email for Sasha Levin
      tools: liblockdep: fix compilation for 4.11

Vishal Thanki (1):
      liblockdep: Remove -lpthread compiler option

 MAINTAINERS                                    |   2 +-
 tools/Makefile                                 |   8 +-
 tools/include/linux/bitops.h                   |  10 ++
 tools/include/linux/jhash.h                    | 125 +++++++++++++++++++++++
 tools/include/linux/sched/clock.h              |   0
 tools/include/linux/sched/task.h               |   0
 tools/include/linux/unaligned/packed_struct.h  |   0
 tools/lib/lockdep/Makefile                     |   9 +-
 tools/lib/lockdep/lockdep.c                    |  17 +++
 tools/lib/lockdep/preload.c                    |   3 +-
 tools/lib/lockdep/run_tests.sh                 |   4 +-
 tools/lib/lockdep/uinclude/linux/bitops.h      |   3 -
 tools/lib/lockdep/uinclude/linux/debug_locks.h |   2 +-
 tools/lib/lockdep/uinclude/linux/irqflags.h    |   8 +-
 tools/lib/lockdep/uinclude/linux/kallsyms.h    |   3 +-
 tools/lib/lockdep/uinclude/linux/kernel.h      |  16 ++-
 tools/lib/lockdep/uinclude/linux/lockdep.h     |  21 ++--
 tools/lib/lockdep/uinclude/linux/rcu.h         |   2 +
 18 files changed, 198 insertions(+), 35 deletions(-)
 create mode 100644 tools/include/linux/jhash.h
 create mode 100644 tools/include/linux/sched/clock.h
 create mode 100644 tools/include/linux/sched/task.h
 create mode 100644 tools/include/linux/unaligned/packed_struct.h
 delete mode 100644 tools/lib/lockdep/uinclude/linux/bitops.h

-- 

Thanks,
Sasha

[toc] | [next] | [standalone]

#1636182

* alexander.levin@verizon.com <alexander.levin@verizon.com> wrote:

> Hi Ingo,
> 
> Please pull fixes for liblockdep.
> 
> ===
> 
> The following changes since commit a351e9b9fc24e982ec2f0e76379a49826036da12:
> 
>   Linux 4.11 (2017-04-30 19:47:48 -0700)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux.git liblockdep-fixes
> 
> for you to fetch changes up to ec3cedc646ea697c849fe651f62ed448760ea569:
> 
>   tools: liblockdep: Use LDFLAGS (2017-05-04 21:34:07 -0400)
> 
> ----------------------------------------------------------------
> Alexander Sverdlin (2):
>       tools: add install make target for liblockdep
>       tools: liblockdep: Don't mix fd-based and stream IO
> 
> Ben Hutchings (10):
>       liblockdep: Fix undefined symbol prandom_u32
>       liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain::depth
>       liblockdep: Define the ARRAY_SIZE() macro
>       liblockdep: Enable -Wall by default
>       liblockdep: Fix 'unused value' warnings
>       liblockdep: Fix 'set but not used' warnings
>       liblockdep: Fix 'defined but not used' warning for init_utsname()
>       tools: liblockdep: Fix object file paths used in an out-of-tree build
>       tools: liblockdep: Remove double-quotes from soname
>       tools: liblockdep: Use LDFLAGS
> 
> Sasha Levin (2):
>       MAINTAINERS: update email for Sasha Levin
>       tools: liblockdep: fix compilation for 4.11
> 
> Vishal Thanki (1):
>       liblockdep: Remove -lpthread compiler option

Could you please include all the patches as part of the pull request, so that 
individual patches can be discussed?

In particular I'm wondering about:

>  tools/include/linux/jhash.h                    | 125 +++++++++++++++++++++++

include/linux/jhash.h is 175 lines long - why not make an exact copy and keep it 
synchronized the way perf does it?

Thanks,

	Ingo

[toc] | [prev] | [next] | [standalone]

#1637142

On Fri, May 05, 2017 at 08:11:38AM +0200, Ingo Molnar wrote:
> * alexander.levin@verizon.com <alexander.levin@verizon.com> wrote:
> Could you please include all the patches as part of the pull request, so that 
> individual patches can be discussed?

Sure, I'll resend.
 
> In particular I'm wondering about:
> 
> >  tools/include/linux/jhash.h                    | 125 +++++++++++++++++++++++
> 
> include/linux/jhash.h is 175 lines long - why not make an exact copy and keep it 
> synchronized the way perf does it?

Including jhash() vs only jhash2() required pulling additional headers in.
Since we don't need jhash() I preferred to drop it.

Let me know if you'd prefer to do it the other way and include everything.

-- 

Thanks,
Sasha

[toc] | [prev] | [next] | [standalone]

#1637230

* alexander.levin@verizon.com <alexander.levin@verizon.com> wrote:

> On Fri, May 05, 2017 at 08:11:38AM +0200, Ingo Molnar wrote:
> > * alexander.levin@verizon.com <alexander.levin@verizon.com> wrote:
> > Could you please include all the patches as part of the pull request, so that 
> > individual patches can be discussed?
> 
> Sure, I'll resend.
>  
> > In particular I'm wondering about:
> > 
> > >  tools/include/linux/jhash.h                    | 125 +++++++++++++++++++++++
> > 
> > include/linux/jhash.h is 175 lines long - why not make an exact copy and keep it 
> > synchronized the way perf does it?
> 
> Including jhash() vs only jhash2() required pulling additional headers in.
> Since we don't need jhash() I preferred to drop it.
> 
> Let me know if you'd prefer to do it the other way and include everything.

How many headers would that be? We already have tools/include/../bitops.h, so we'd 
only need include/linux/unaligned/packed_struct.h, which looks straightforward and 
smallish.

( That header includes kernel.h, but we have that in tools as well, so in theory 
  it could work. )

The principle would be to 'COW-share' as much code as possible, at least for 
obvious arithmetics helpers - which hashes do appear to be.

Thanks,

	Ingo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web