Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635034 > unrolled thread

[PATCHv2 0/4] Motorola Droid 4: Add WL1285C support

Started bySebastian Reichel <sebastian.reichel@collabora.co.uk>
First post2017-05-03 16:30 +0200
Last post2017-05-04 02:20 +0200
Articles 5 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCHv2 0/4] Motorola Droid 4: Add WL1285C support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-03 16:30 +0200
    Re: [PATCHv2 0/4] Motorola Droid 4: Add WL1285C support Rob Herring <robh+dt@kernel.org> - 2017-05-03 16:50 +0200
      Re: [PATCHv2 0/4] Motorola Droid 4: Add WL1285C support Marcel Holtmann <marcel@holtmann.org> - 2017-05-03 17:10 +0200
        Re: [PATCHv2 0/4] Motorola Droid 4: Add WL1285C support Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-03 18:10 +0200
          Re: [PATCHv2 0/4] Motorola Droid 4: Add WL1285C support Tony Lindgren <tony@atomide.com> - 2017-05-04 02:20 +0200

#1635034 — [PATCHv2 0/4] Motorola Droid 4: Add WL1285C support

FromSebastian Reichel <sebastian.reichel@collabora.co.uk>
Date2017-05-03 16:30 +0200
Subject[PATCHv2 0/4] Motorola Droid 4: Add WL1285C support
Message-ID<tD3rX-6Af-3@gated-at.bofh.it>
Hi,

Motorola Droid 4 uses a WL1285C, as visible on iFixit [0]. This
fixes the DT file to use correct compatible for the wifi node
and adds the bluetooth node.

[0] https://www.ifixit.com/Teardown/Motorola+Droid+4+Teardown/7759#s31961

Changes to PATCHv1:
 - use proper compatible value for bluetooth / shared transport
 - add patches fixing wlcore compatible for Droid 4

-- Sebastian

Sebastian Reichel (4):
  wlcore: add wl1285 compatible
  ARM: dts: omap4-droid4: Use wl1285 for wifi compatible
  Bluetooth: hci_ll: Add compatible values for more WL chips
  ARM: dts: omap4-droid4: Add bluetooth

 .../devicetree/bindings/net/ti,wilink-st.txt       |  6 ++++++
 .../devicetree/bindings/net/wireless/ti,wlcore.txt |  1 +
 arch/arm/boot/dts/omap4-droid4-xt894.dts           | 22 +++++++++++++++++++++-
 drivers/bluetooth/hci_ll.c                         |  8 ++++++++
 drivers/net/wireless/ti/wlcore/sdio.c              |  1 +
 drivers/net/wireless/ti/wlcore/spi.c               |  1 +
 6 files changed, 38 insertions(+), 1 deletion(-)

-- 
2.11.0

[toc] | [next] | [standalone]

#1635039

FromRob Herring <robh+dt@kernel.org>
Date2017-05-03 16:50 +0200
Message-ID<tD3Lj-6H8-1@gated-at.bofh.it>
In reply to#1635034
On Wed, May 3, 2017 at 9:22 AM, Sebastian Reichel
<sebastian.reichel@collabora.co.uk> wrote:
> Hi,
>
> Motorola Droid 4 uses a WL1285C, as visible on iFixit [0]. This
> fixes the DT file to use correct compatible for the wifi node
> and adds the bluetooth node.
>
> [0] https://www.ifixit.com/Teardown/Motorola+Droid+4+Teardown/7759#s31961
>
> Changes to PATCHv1:
>  - use proper compatible value for bluetooth / shared transport
>  - add patches fixing wlcore compatible for Droid 4
>
> -- Sebastian
>
> Sebastian Reichel (4):
>   wlcore: add wl1285 compatible
>   ARM: dts: omap4-droid4: Use wl1285 for wifi compatible
>   Bluetooth: hci_ll: Add compatible values for more WL chips
>   ARM: dts: omap4-droid4: Add bluetooth

For the series,

Reviewed-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [next] | [standalone]

#1635057

FromMarcel Holtmann <marcel@holtmann.org>
Date2017-05-03 17:10 +0200
Message-ID<tD44G-73B-17@gated-at.bofh.it>
In reply to#1635039
Hi Rob,

>> Motorola Droid 4 uses a WL1285C, as visible on iFixit [0]. This
>> fixes the DT file to use correct compatible for the wifi node
>> and adds the bluetooth node.
>> 
>> [0] https://www.ifixit.com/Teardown/Motorola+Droid+4+Teardown/7759#s31961
>> 
>> Changes to PATCHv1:
>> - use proper compatible value for bluetooth / shared transport
>> - add patches fixing wlcore compatible for Droid 4
>> 
>> -- Sebastian
>> 
>> Sebastian Reichel (4):
>>  wlcore: add wl1285 compatible
>>  ARM: dts: omap4-droid4: Use wl1285 for wifi compatible
>>  Bluetooth: hci_ll: Add compatible values for more WL chips
>>  ARM: dts: omap4-droid4: Add bluetooth
> 
> For the series,
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

so now the question is if we merge this through a single maintainer or have each maintainer take the pieces? I would almost suggest that Dave Miller takes this directly into net-next to make this smoother.

Regards

Marcel

[toc] | [prev] | [next] | [standalone]

#1635110

FromSebastian Reichel <sebastian.reichel@collabora.co.uk>
Date2017-05-03 18:10 +0200
Message-ID<tD50K-7GP-23@gated-at.bofh.it>
In reply to#1635057

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Wed, May 03, 2017 at 05:02:13PM +0200, Marcel Holtmann wrote:
> >> Motorola Droid 4 uses a WL1285C, as visible on iFixit [0]. This
> >> fixes the DT file to use correct compatible for the wifi node
> >> and adds the bluetooth node.
> >> 
> >> [0] https://www.ifixit.com/Teardown/Motorola+Droid+4+Teardown/7759#s31961
> >> 
> >> Changes to PATCHv1:
> >> - use proper compatible value for bluetooth / shared transport
> >> - add patches fixing wlcore compatible for Droid 4
> >> 
> >> -- Sebastian
> >> 
> >> Sebastian Reichel (4):
> >>  wlcore: add wl1285 compatible
> >>  ARM: dts: omap4-droid4: Use wl1285 for wifi compatible
> >>  Bluetooth: hci_ll: Add compatible values for more WL chips
> >>  ARM: dts: omap4-droid4: Add bluetooth
> > 
> > For the series,
> > 
> > Reviewed-by: Rob Herring <robh@kernel.org>
> 
> so now the question is if we merge this through a single
> maintainer or have each maintainer take the pieces? I would almost
> suggest that Dave Miller takes this directly into net-next to make
> this smoother.

I think the only complex thing is, that patch 2 should only be
applied after patch 1. So maybe patch 1 could be applied via
wireless/net-next for 4.12 and the other ones go through the
individual subsystems for 4.13?

-- Sebastian

[toc] | [prev] | [next] | [standalone]

#1635348

FromTony Lindgren <tony@atomide.com>
Date2017-05-04 02:20 +0200
Message-ID<tDcEW-4gn-13@gated-at.bofh.it>
In reply to#1635110
* Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170503 09:11]:
> Hi,
> 
> On Wed, May 03, 2017 at 05:02:13PM +0200, Marcel Holtmann wrote:
> > >> Motorola Droid 4 uses a WL1285C, as visible on iFixit [0]. This
> > >> fixes the DT file to use correct compatible for the wifi node
> > >> and adds the bluetooth node.
> > >> 
> > >> [0] https://www.ifixit.com/Teardown/Motorola+Droid+4+Teardown/7759#s31961
> > >> 
> > >> Changes to PATCHv1:
> > >> - use proper compatible value for bluetooth / shared transport
> > >> - add patches fixing wlcore compatible for Droid 4
> > >> 
> > >> -- Sebastian
> > >> 
> > >> Sebastian Reichel (4):
> > >>  wlcore: add wl1285 compatible
> > >>  ARM: dts: omap4-droid4: Use wl1285 for wifi compatible
> > >>  Bluetooth: hci_ll: Add compatible values for more WL chips
> > >>  ARM: dts: omap4-droid4: Add bluetooth
> > > 
> > > For the series,
> > > 
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > 
> > so now the question is if we merge this through a single
> > maintainer or have each maintainer take the pieces? I would almost
> > suggest that Dave Miller takes this directly into net-next to make
> > this smoother.
> 
> I think the only complex thing is, that patch 2 should only be
> applied after patch 1. So maybe patch 1 could be applied via
> wireless/net-next for 4.12 and the other ones go through the
> individual subsystems for 4.13?

Yeah removing dependencies where possible avoids pointless
merge conflicts later on.

Please send patches 1 and 2 together as a single patch to
Dave Miller and describe why it's needed for v4.12. The rest
can then get merged via the BT and DT trees.

Regards,

Tony

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web