Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1634940 > unrolled thread
| Started by | Kim Phillips <kim.phillips@arm.com> |
|---|---|
| First post | 2017-05-03 14:20 +0200 |
| Last post | 2017-05-04 20:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 2/3] perf annotate: fix AArch64 comment char Kim Phillips <kim.phillips@arm.com> - 2017-05-03 14:20 +0200
[tip:perf/urgent] perf annotate: Fix AArch64 comment char tip-bot for Kim Phillips <tipbot@zytor.com> - 2017-05-04 20:00 +0200
| From | Kim Phillips <kim.phillips@arm.com> |
|---|---|
| Date | 2017-05-03 14:20 +0200 |
| Subject | [PATCH 2/3] perf annotate: fix AArch64 comment char |
| Message-ID | <tD1qa-5fK-21@gated-at.bofh.it> |
commit 0fcb1da4aba "perf annotate: AArch64
support" blindly copied the comment character from the original:
https://lkml.org/lkml/2016/5/19/461
whereas that same commit shows objdump output utilizing the C++ style
"//" as the comment delimeter. Since '/' doesn't occur elsewhere in
objdump output, we retain the single character check, but fix it to be
'/'.
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
---
tools/perf/arch/arm64/annotate/instructions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/arch/arm64/annotate/instructions.c b/tools/perf/arch/arm64/annotate/instructions.c
index 44eafd6..8f19087 100644
--- a/tools/perf/arch/arm64/annotate/instructions.c
+++ b/tools/perf/arch/arm64/annotate/instructions.c
@@ -50,7 +50,7 @@ static int arm64__annotate_init(struct arch *arch)
arch->initialized = true;
arch->priv = arm;
arch->associate_instruction_ops = arm64__associate_instruction_ops;
- arch->objdump.comment_char = ';';
+ arch->objdump.comment_char = '/';
arch->objdump.skip_functions_char = '+';
return 0;
--
2.10.2
[toc] | [next] | [standalone]
| From | tip-bot for Kim Phillips <tipbot@zytor.com> |
|---|---|
| Date | 2017-05-04 20:00 +0200 |
| Subject | [tip:perf/urgent] perf annotate: Fix AArch64 comment char |
| Message-ID | <tDtcK-6Nc-13@gated-at.bofh.it> |
| In reply to | #1634940 |
Commit-ID: d1f7b0234ec7743899321aaaba379b2f5f9d0500
Gitweb: http://git.kernel.org/tip/d1f7b0234ec7743899321aaaba379b2f5f9d0500
Author: Kim Phillips <kim.phillips@arm.com>
AuthorDate: Wed, 3 May 2017 13:13:56 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 4 May 2017 10:03:00 -0300
perf annotate: Fix AArch64 comment char
The commit 0fcb1da4aba "perf annotate: AArch64 support" blindly copied
the comment character from the original:
https://lkml.org/lkml/2016/5/19/461
whereas that same commit shows objdump output utilizing the C++ style
"//" as the comment delimeter. Since '/' doesn't occur elsewhere in
objdump output, we retain the single character check, but fix it to be
'/'.
Signed-off-by: Kim Phillips <kim.phillips@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Chris Riyder <chris.ryder@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: 0fcb1da4aba6 ("perf annotate: AArch64 support")
Link: http://lkml.kernel.org/r/20170503131356.be88f977094fb3fa0f49b99d@arm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/arch/arm64/annotate/instructions.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/arch/arm64/annotate/instructions.c b/tools/perf/arch/arm64/annotate/instructions.c
index 44eafd6..8f19087 100644
--- a/tools/perf/arch/arm64/annotate/instructions.c
+++ b/tools/perf/arch/arm64/annotate/instructions.c
@@ -50,7 +50,7 @@ static int arm64__annotate_init(struct arch *arch)
arch->initialized = true;
arch->priv = arm;
arch->associate_instruction_ops = arm64__associate_instruction_ops;
- arch->objdump.comment_char = ';';
+ arch->objdump.comment_char = '/';
arch->objdump.skip_functions_char = '+';
return 0;
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web