Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1634758 > unrolled thread
| Started by | Surender Polsani <surenderpolsani@gmail.com> |
|---|---|
| First post | 2017-05-03 08:00 +0200 |
| Last post | 2017-05-03 12:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging : rtl8188eu : remove void function return Surender Polsani <surenderpolsani@gmail.com> - 2017-05-03 08:00 +0200
Re: [PATCH] staging : rtl8188eu : remove void function return Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-03 12:50 +0200
| From | Surender Polsani <surenderpolsani@gmail.com> |
|---|---|
| Date | 2017-05-03 08:00 +0200 |
| Subject | [PATCH] staging : rtl8188eu : remove void function return |
| Message-ID | <tCVuq-DT-15@gated-at.bofh.it> |
kernel coding style doesn't allow the return statement in void function. Signed-off-by: Surender Polsani <surenderpolsani@gmail.com> --- Changes for v2: corrected subject line as suggested Changes for v3: modified from line as suggested by Greg KH placed a semicolon in label for fixing build error --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c index d04b7fb..428996e 100644 --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c @@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) skip_dm: /* Check GPIO to determine current RF on/off and Pbc status. */ /* Check Hardware Radio ON/OFF or not */ - return; + ; } void rtw_hal_dm_init(struct adapter *Adapter) -- 1.9.1
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-05-03 12:50 +0200 |
| Message-ID | <tD014-46P-17@gated-at.bofh.it> |
| In reply to | #1634758 |
On Wed, May 03, 2017 at 11:29:00AM +0530, Surender Polsani wrote: > kernel coding style doesn't allow the return statement > in void function. > > Signed-off-by: Surender Polsani <surenderpolsani@gmail.com> > --- > Changes for v2: > corrected subject line as suggested > Changes for v3: > modified from line as suggested by Greg KH > placed a semicolon in label for fixing build error > --- > drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > index d04b7fb..428996e 100644 > --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c > @@ -165,7 +165,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) > skip_dm: > /* Check GPIO to determine current RF on/off and Pbc status. */ > /* Check Hardware Radio ON/OFF or not */ > - return; > + ; Just get rid of the label. regards, dan carpenter
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web