Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1631555 > unrolled thread
| Started by | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| First post | 2017-04-26 18:00 +0200 |
| Last post | 2017-05-01 18:40 +0200 |
| Articles | 4 on this page of 44 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
[PATCH net-next 02/18] net: dsa: mv88e6xxx: split VTU entry data member Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 02/18] net: dsa: mv88e6xxx: split VTU entry data member Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:30 +0200
[PATCH net-next 11/18] net: dsa: mv88e6xxx: get STU entry on VTU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 11/18] net: dsa: mv88e6xxx: get STU entry on VTU GetNext Andrew Lunn <andrew@lunn.ch> - 2017-04-27 22:20 +0200
[PATCH net-next 13/18] net: dsa: mv88e6xxx: add VTU GetNext operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 13/18] net: dsa: mv88e6xxx: add VTU GetNext operation Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:20 +0200
[PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit Andrew Lunn <andrew@lunn.ch> - 2017-04-28 15:00 +0200
Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-28 16:30 +0200
Re: [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit Andrew Lunn <andrew@lunn.ch> - 2017-04-28 17:00 +0200
[PATCH net-next 04/18] net: dsa: mv88e6xxx: move VTU flush Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 04/18] net: dsa: mv88e6xxx: move VTU flush Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
[PATCH net-next 14/18] net: dsa: mv88e6xxx: add VTU Load/Purge operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 14/18] net: dsa: mv88e6xxx: add VTU Load/Purge operation Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:20 +0200
[PATCH net-next 09/18] net: dsa: mv88e6xxx: move VTU Data accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 09/18] net: dsa: mv88e6xxx: move VTU Data accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:20 +0200
[PATCH net-next 01/18] net: dsa: mv88e6xxx: add max VID to info Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 01/18] net: dsa: mv88e6xxx: add max VID to info Andrew Lunn <andrew@lunn.ch> - 2017-04-26 18:10 +0200
[PATCH net-next 10/18] net: dsa: mv88e6xxx: move STU GetNext operation Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 10/18] net: dsa: mv88e6xxx: move STU GetNext operation Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:50 +0200
[PATCH net-next 03/18] net: dsa: mv88e6xxx: move VTU Operation accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 03/18] net: dsa: mv88e6xxx: move VTU Operation accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
Re: [PATCH net-next 03/18] net: dsa: mv88e6xxx: move VTU Operation accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
[PATCH net-next 07/18] net: dsa: mv88e6xxx: move VTU VID accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:00 +0200
Re: [PATCH net-next 07/18] net: dsa: mv88e6xxx: move VTU VID accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:00 +0200
[PATCH net-next 16/18] net: dsa: mv88e6xxx: simplify VTU entry getter Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
Re: [PATCH net-next 16/18] net: dsa: mv88e6xxx: simplify VTU entry getter Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:30 +0200
[PATCH net-next 06/18] net: dsa: mv88e6xxx: move VTU SID accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
Re: [PATCH net-next 06/18] net: dsa: mv88e6xxx: move VTU SID accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
[PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
Re: [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext Andrew Lunn <andrew@lunn.ch> - 2017-04-27 21:00 +0200
Re: [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-28 17:10 +0200
[PATCH net-next 12/18] net: dsa: mv88e6xxx: load STU entry with VTU entry Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
Re: [PATCH net-next 12/18] net: dsa: mv88e6xxx: load STU entry with VTU entry Andrew Lunn <andrew@lunn.ch> - 2017-04-28 04:10 +0200
[PATCH net-next 05/18] net: dsa: mv88e6xxx: move VTU FID accessors Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-04-26 18:10 +0200
Re: [PATCH net-next 05/18] net: dsa: mv88e6xxx: move VTU FID accessors Andrew Lunn <andrew@lunn.ch> - 2017-04-27 20:40 +0200
Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 18:00 +0200
Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU David Miller <davem@davemloft.net> - 2017-05-01 18:10 +0200
Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Andrew Lunn <andrew@lunn.ch> - 2017-05-01 18:30 +0200
Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 19:20 +0200
Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 18:30 +0200
Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU David Miller <davem@davemloft.net> - 2017-05-01 18:30 +0200
Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-01 18:40 +0200
Page 3 of 3 — ← Prev page 1 2 [3]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2017-05-01 19:20 +0200 |
| Message-ID | <tCn9n-3uH-9@gated-at.bofh.it> |
| In reply to | #1633733 |
Andrew,
Andrew Lunn <andrew@lunn.ch> writes:
> I actually pointed out a typo in one of the change log message. And i
> requested some additional comments.
I can respin this patch series to correct the nitpicks on 8/18 but, what
I want most is a Tested-by tag. As you have this hardware, can you give
it a try?
Note that 17/18 is missing your Reviewed-by as agreed.
Vivien
[toc] | [prev] | [next] | [standalone]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2017-05-01 18:30 +0200 |
| Message-ID | <tCmmZ-2Xx-3@gated-at.bofh.it> |
| In reply to | #1633725 |
Hi David,
David Miller <davem@davemloft.net> writes:
> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> Date: Mon, 01 May 2017 11:51:05 -0400
>
>> Hi David,
>>
>> Vivien Didelot <vivien.didelot@savoirfairelinux.com> writes:
>>
>>> Vivien Didelot (18):
>>> net: dsa: mv88e6xxx: add max VID to info
>>> net: dsa: mv88e6xxx: split VTU entry data member
>>> net: dsa: mv88e6xxx: move VTU Operation accessors
>>> net: dsa: mv88e6xxx: move VTU flush
>>> net: dsa: mv88e6xxx: move VTU FID accessors
>>> net: dsa: mv88e6xxx: move VTU SID accessors
>>> net: dsa: mv88e6xxx: move VTU VID accessors
>>> net: dsa: mv88e6xxx: move generic VTU GetNext
>>> net: dsa: mv88e6xxx: move VTU Data accessors
>>> net: dsa: mv88e6xxx: move STU GetNext operation
>>> net: dsa: mv88e6xxx: get STU entry on VTU GetNext
>>> net: dsa: mv88e6xxx: load STU entry with VTU entry
>>> net: dsa: mv88e6xxx: add VTU GetNext operation
>>> net: dsa: mv88e6xxx: add VTU Load/Purge operation
>>> net: dsa: mv88e6xxx: make VTU helpers static
>>> net: dsa: mv88e6xxx: simplify VTU entry getter
>>> net: dsa: mv88e6xxx: support the VTU Page bit
>>> net: dsa: mv88e6xxx: add VTU support for 88E6390
>>>
>>> drivers/net/dsa/mv88e6xxx/Makefile | 1 +
>>> drivers/net/dsa/mv88e6xxx/chip.c | 568 +++++++++-----------------------
>>> drivers/net/dsa/mv88e6xxx/global1.h | 14 +
>>> drivers/net/dsa/mv88e6xxx/global1_vtu.c | 505 ++++++++++++++++++++++++++++
>>> drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 31 +-
>>> 5 files changed, 684 insertions(+), 435 deletions(-)
>>> create mode 100644 drivers/net/dsa/mv88e6xxx/global1_vtu.c
>>
>> I don't see the patchset in net-next. Can you pick it?
>
> This had feedback which you must address, therefore the state in
> patchwork is "changes requested" which you could have checked before
> asking me this.
>
> If the patch set is fine and you got ACKs for all of your patches
> then please resubmit.
>
> Otherwise, make the changes you were asked to make or explain to
> the person who asked for them why they are not appropriate.
We did discuss the patchset and everything is good as is. Can someone
change the state in patchwork afterwards? It feels weird to resend the
patch with no changes.
Thanks,
Vivien
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-05-01 18:30 +0200 |
| Subject | Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU |
| Message-ID | <tCmn0-2Xx-21@gated-at.bofh.it> |
| In reply to | #1633735 |
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Date: Mon, 01 May 2017 12:21:31 -0400 > Hi David, > > David Miller <davem@davemloft.net> writes: > >> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com> >> Date: Mon, 01 May 2017 11:51:05 -0400 >> >>> Hi David, >>> >>> Vivien Didelot <vivien.didelot@savoirfairelinux.com> writes: >>> >>>> Vivien Didelot (18): >>>> net: dsa: mv88e6xxx: add max VID to info >>>> net: dsa: mv88e6xxx: split VTU entry data member >>>> net: dsa: mv88e6xxx: move VTU Operation accessors >>>> net: dsa: mv88e6xxx: move VTU flush >>>> net: dsa: mv88e6xxx: move VTU FID accessors >>>> net: dsa: mv88e6xxx: move VTU SID accessors >>>> net: dsa: mv88e6xxx: move VTU VID accessors >>>> net: dsa: mv88e6xxx: move generic VTU GetNext >>>> net: dsa: mv88e6xxx: move VTU Data accessors >>>> net: dsa: mv88e6xxx: move STU GetNext operation >>>> net: dsa: mv88e6xxx: get STU entry on VTU GetNext >>>> net: dsa: mv88e6xxx: load STU entry with VTU entry >>>> net: dsa: mv88e6xxx: add VTU GetNext operation >>>> net: dsa: mv88e6xxx: add VTU Load/Purge operation >>>> net: dsa: mv88e6xxx: make VTU helpers static >>>> net: dsa: mv88e6xxx: simplify VTU entry getter >>>> net: dsa: mv88e6xxx: support the VTU Page bit >>>> net: dsa: mv88e6xxx: add VTU support for 88E6390 >>>> >>>> drivers/net/dsa/mv88e6xxx/Makefile | 1 + >>>> drivers/net/dsa/mv88e6xxx/chip.c | 568 +++++++++----------------------- >>>> drivers/net/dsa/mv88e6xxx/global1.h | 14 + >>>> drivers/net/dsa/mv88e6xxx/global1_vtu.c | 505 ++++++++++++++++++++++++++++ >>>> drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 31 +- >>>> 5 files changed, 684 insertions(+), 435 deletions(-) >>>> create mode 100644 drivers/net/dsa/mv88e6xxx/global1_vtu.c >>> >>> I don't see the patchset in net-next. Can you pick it? >> >> This had feedback which you must address, therefore the state in >> patchwork is "changes requested" which you could have checked before >> asking me this. >> >> If the patch set is fine and you got ACKs for all of your patches >> then please resubmit. >> >> Otherwise, make the changes you were asked to make or explain to >> the person who asked for them why they are not appropriate. > > We did discuss the patchset and everything is good as is. Can someone > change the state in patchwork afterwards? It feels weird to resend the > patch with no changes. Once I set the state to "changes requested", that's basically permanent. Please simply resubmit your patch series, ACKs added if necessary. Thanks.
[toc] | [prev] | [next] | [standalone]
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Date | 2017-05-01 18:40 +0200 |
| Message-ID | <tCmwF-32J-3@gated-at.bofh.it> |
| In reply to | #1633737 |
Hi David,
David Miller <davem@davemloft.net> writes:
> Once I set the state to "changes requested", that's basically permanent.
>
> Please simply resubmit your patch series, ACKs added if necessary.
OK good to know, I respin this series in a few minutes.
Thanks,
Vivien
[toc] | [prev] | [standalone]
Page 3 of 3 — ← Prev page 1 2 [3]
Back to top | Article view | linux.kernel
csiph-web