Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1633697 > unrolled thread

[PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter

Back to article view | Back to linux.kernel

Contents

  [PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter Martin Kepplinger <martink@posteo.de> - 2017-05-01 17:00 +0200
    Re: [PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X  parameter Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-05-01 19:20 +0200

#1633697 — [PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter

The recent change

commit 2098cc15d9a0 ("Input: ar1021_i2c - enable touch mode during open")

also removed the ABS_X input code to be set. This must have been done
by mistake; so we bring back the X axis!

Signed-off-by: Martin Kepplinger <martink@posteo.de>
---

Dmitry,

this must have slipped in somehow. I didn't have this mistake included:
https://www.spinics.net/lists/linux-input/msg51103.html

thanks
                         martin


 drivers/input/touchscreen/ar1021_i2c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
index ff59c3a383d6..3f55f673f661 100644
--- a/drivers/input/touchscreen/ar1021_i2c.c
+++ b/drivers/input/touchscreen/ar1021_i2c.c
@@ -118,6 +118,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
 	input->close = ar1021_i2c_close;
 
 	input_set_capability(input, EV_KEY, BTN_TOUCH);
+	input_set_abs_params(input, ABS_X, 0, AR1021_MAX_X, 0, 0);
 	input_set_abs_params(input, ABS_Y, 0, AR1021_MAX_Y, 0, 0);
 
 	input_set_drvdata(input, ar1021);
-- 
2.11.0

[toc] | [next] | [standalone]

#1633755 — Re: [PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter

On Mon, May 01, 2017 at 04:57:09PM +0200, Martin Kepplinger wrote:
> The recent change
> 
> commit 2098cc15d9a0 ("Input: ar1021_i2c - enable touch mode during open")
> 
> also removed the ABS_X input code to be set. This must have been done
> by mistake; so we bring back the X axis!
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> 
> Dmitry,
> 
> this must have slipped in somehow. I didn't have this mistake included:
> https://www.spinics.net/lists/linux-input/msg51103.html

I must have fat-fingered it somehow. I fixed up the original commit
since it wasn't buried too deep.

Thanks.

> 
> thanks
>                          martin
> 
> 
>  drivers/input/touchscreen/ar1021_i2c.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
> index ff59c3a383d6..3f55f673f661 100644
> --- a/drivers/input/touchscreen/ar1021_i2c.c
> +++ b/drivers/input/touchscreen/ar1021_i2c.c
> @@ -118,6 +118,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
>  	input->close = ar1021_i2c_close;
>  
>  	input_set_capability(input, EV_KEY, BTN_TOUCH);
> +	input_set_abs_params(input, ABS_X, 0, AR1021_MAX_X, 0, 0);
>  	input_set_abs_params(input, ABS_Y, 0, AR1021_MAX_Y, 0, 0);
>  
>  	input_set_drvdata(input, ar1021);
> -- 
> 2.11.0
> 

-- 
Dmitry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web