Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1633601 > unrolled thread

[PATCH] staging: rtl8723bs: Fix coding style issues

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: rtl8723bs: Fix coding style issues Adheer Chandravanshi <adheerchandravanshi@gmail.com> - 2017-05-01 13:00 +0200
    Re: [PATCH] staging: rtl8723bs: Fix coding style issues Greg KH <gregkh@linuxfoundation.org> - 2017-05-01 14:20 +0200
      Re: [PATCH] staging: rtl8723bs: Fix coding style issues adheer chandravanshi <adheerchandravanshi@gmail.com> - 2017-05-02 06:40 +0200

#1633601 — [PATCH] staging: rtl8723bs: Fix coding style issues

Fix style issues as reported by checkpatch.pl

Signed-off-by: Adheer Chandravanshi <adheerchandravanshi@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtl8192c_recv.h |  9 +++++----
 drivers/staging/rtl8723bs/include/rtl8192c_rf.h   | 22 +++++++++-------------
 2 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
index 3e1be00..09e3c49 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
@@ -21,8 +21,7 @@
 
 #define MAX_RECVBUF_SZ (10240)
 
-struct phy_stat
-{
+struct phy_stat {
 	unsigned int phydw0;
 
 	unsigned int phydw1;
@@ -44,7 +43,9 @@ struct phy_stat
 #define	Rx_Smooth_Factor (20)
 
 
-void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
-void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
+void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe,
+					struct phy_stat *pphy_status);
+void rtl8192c_query_rx_desc_status(union recv_frame *precvframe,
+				   struct recv_stat *pdesc);
 
 #endif
diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_rf.h b/drivers/staging/rtl8723bs/include/rtl8192c_rf.h
index 0dbee56..d3105c0 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_rf.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_rf.h
@@ -19,19 +19,15 @@
 /*  */
 /*  RF RL6052 Series API */
 /*  */
-void 	rtl8192c_RF_ChangeTxPath(struct adapter *Adapter,
-				u16 	DataRate);
-void 	rtl8192c_PHY_RF6052SetBandwidth(
-				struct adapter *			Adapter,
-				enum CHANNEL_WIDTH		Bandwidth);
-void rtl8192c_PHY_RF6052SetCckTxPower(
-				struct adapter *Adapter,
-				u8*	pPowerlevel);
-void rtl8192c_PHY_RF6052SetOFDMTxPower(
-				struct adapter *Adapter,
-				u8*	pPowerLevel,
-				u8 Channel);
-int	PHY_RF6052_Config8192C(struct adapter *	Adapter	);
+void rtl8192c_RF_ChangeTxPath(struct adapter *Adapter,
+			      u16 DataRate);
+void rtl8192c_PHY_RF6052SetBandwidth(struct adapter *Adapter,
+				     enum CHANNEL_WIDTH Bandwidth);
+void rtl8192c_PHY_RF6052SetCckTxPower(struct adapter *Adapter,
+				      u8 *pPowerlevel);
+void rtl8192c_PHY_RF6052SetOFDMTxPower(struct adapter *Adapter,
+				       u8 *pPowerLevel, u8 Channel);
+int PHY_RF6052_Config8192C(struct adapter *Adapter);
 
 /*--------------------------Exported Function prototype---------------------*/
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1633633

On Mon, May 01, 2017 at 04:19:48PM +0530, Adheer Chandravanshi wrote:
> Fix style issues as reported by checkpatch.pl

That's really vague, you need to be specific, and only fix one type of
thing per patch.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1634130

On Mon, May 1, 2017 at 5:40 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, May 01, 2017 at 04:19:48PM +0530, Adheer Chandravanshi wrote:
>> Fix style issues as reported by checkpatch.pl
>
> That's really vague, you need to be specific, and only fix one type of
> thing per patch.
>
> thanks,
>
> greg k-h

Thanks for the quick review, will re-send the patch.

--
Adheer

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web