Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1633611 > unrolled thread

Re: [PATCH v3 3/3] drivers:power:twl4030-charger: remove nonstandard max_current sysfs attribute

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v3 3/3] drivers:power:twl4030-charger: remove nonstandard  max_current sysfs attribute Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-01 13:30 +0200
    Re: [PATCH v3 3/3] drivers:power:twl4030-charger: remove nonstandard max_current sysfs attribute "H. Nikolaus Schaller" <hns@goldelico.com> - 2017-05-03 14:30 +0200

#1633611 — Re: [PATCH v3 3/3] drivers:power:twl4030-charger: remove nonstandard max_current sysfs attribute

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Fri, Apr 14, 2017 at 08:25:57PM +0200, H. Nikolaus Schaller wrote:
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>

I'm not queuing this. Please change the following things for the
v4 of this patch:

 - Kernel patches should always have a long description
 - Patch needs to update Documentation/ABI/testing/sysfs-class-power-twl4030
 - Make sure to use recent MAINTAINERS file for getting patch
   destination (Dmitry and David are no longer listed).
 - And for this case: please also Cc NeilBrown <neil@brown.name>. If
   the ABI is in use we cannot simply remove it. If its unlikely,
   that its used I will queue the patch and revert if any problems
   are reported.

-- Sebastian

[toc] | [next] | [standalone]

#1634948 — Re: [PATCH v3 3/3] drivers:power:twl4030-charger: remove nonstandard max_current sysfs attribute

[Multipart message — attachments visible in raw view] — view raw

Hi,

> Am 01.05.2017 um 13:26 schrieb Sebastian Reichel <sebastian.reichel@collabora.co.uk>:
> 
> Hi,
> 
> On Fri, Apr 14, 2017 at 08:25:57PM +0200, H. Nikolaus Schaller wrote:
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> 
> I'm not queuing this. Please change the following things for the
> v4 of this patch:
> 
> - Kernel patches should always have a long description

Ok.

> - Patch needs to update Documentation/ABI/testing/sysfs-class-power-twl4030

Ok, forgot about this.

> - Make sure to use recent MAINTAINERS file for getting patch
>   destination (Dmitry and David are no longer listed).
> - And for this case: please also Cc NeilBrown <neil@brown.name>. If
>   the ABI is in use we cannot simply remove it. If its unlikely,
>   that its used I will queue the patch and revert if any problems
>   are reported.

Well, Neil did also work for the GTA04 project, so it is the same project.
But I will add him for V4 so that he can comment himself.

> 
> -- Sebastian


BR and thanks,
Nikolaus

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web