Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1633158 > unrolled thread

[PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD

Started by"Darren Hart (VMware)" <dvhart@infradead.org>
First post2017-04-28 23:10 +0200
Last post2017-05-03 08:30 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD "Darren Hart (VMware)" <dvhart@infradead.org> - 2017-04-28 23:10 +0200
    Re: [PATCH] platform/x86: Make SILEAD_DMI depend on  TOUCHSCREEN_SILEAD Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-04-28 23:10 +0200
      Re: [PATCH] platform/x86: Make SILEAD_DMI depend on  TOUCHSCREEN_SILEAD Darren Hart <dvhart@infradead.org> - 2017-04-29 00:20 +0200
    Re: [PATCH] platform/x86: Make SILEAD_DMI depend on  TOUCHSCREEN_SILEAD Jean Delvare <jdelvare@suse.de> - 2017-05-03 08:30 +0200

#1633158 — [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD

From"Darren Hart (VMware)" <dvhart@infradead.org>
Date2017-04-28 23:10 +0200
Subject[PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD
Message-ID<tBljj-4Iv-5@gated-at.bofh.it>
SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
driver. Make this explicitly clear in the Kconfig depends.

Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy@infradead.org>
Cc: Jean Delvare <jdelvare@suse.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/platform/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 9e5b2c2..5690664 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
 
 config SILEAD_DMI
 	bool "Tablets with Silead touchscreens"
-	depends on ACPI && DMI && I2C=y && INPUT
+	depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
 	---help---
 	  Certain ACPI based tablets with Silead touchscreens do not have
 	  enough data in ACPI tables for the touchscreen driver to handle
-- 
2.9.3


-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [next] | [standalone]


#1633163 — Re: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD

FromDmitry Torokhov <dmitry.torokhov@gmail.com>
Date2017-04-28 23:10 +0200
SubjectRe: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD
Message-ID<tBljk-4Iv-29@gated-at.bofh.it>
In reply to#1633158
On Fri, Apr 28, 2017 at 02:00:19PM -0700, Darren Hart (VMware) wrote:
> SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
> driver. Make this explicitly clear in the Kconfig depends.
> 
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Andy Shevchenko <andy@infradead.org>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/platform/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 9e5b2c2..5690664 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
>  
>  config SILEAD_DMI
>  	bool "Tablets with Silead touchscreens"
> -	depends on ACPI && DMI && I2C=y && INPUT
> +	depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD

Bikeshed: TOUCHSCREEN_SILEAD already depends on INPUT, so you can drop
INPUT dependency.

Otherwise

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

-- 
Dmitry

[toc] | [prev] | [next] | [standalone]


#1633182 — Re: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD

FromDarren Hart <dvhart@infradead.org>
Date2017-04-29 00:20 +0200
SubjectRe: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD
Message-ID<tBmp4-5t5-7@gated-at.bofh.it>
In reply to#1633163
On Fri, Apr 28, 2017 at 02:09:00PM -0700, Dmitry Torokhov wrote:
> On Fri, Apr 28, 2017 at 02:00:19PM -0700, Darren Hart (VMware) wrote:
> > SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
> > driver. Make this explicitly clear in the Kconfig depends.
> > 
> > Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Andy Shevchenko <andy@infradead.org>
> > Cc: Jean Delvare <jdelvare@suse.de>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> >  drivers/platform/x86/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index 9e5b2c2..5690664 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
> >  
> >  config SILEAD_DMI
> >  	bool "Tablets with Silead touchscreens"
> > -	depends on ACPI && DMI && I2C=y && INPUT
> > +	depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
> 
> Bikeshed: TOUCHSCREEN_SILEAD already depends on INPUT, so you can drop
> INPUT dependency.
> 

Done, thanks.

> Otherwise
> 
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> -- 
> Dmitry
> 

-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [prev] | [next] | [standalone]


#1634769 — Re: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD

FromJean Delvare <jdelvare@suse.de>
Date2017-05-03 08:30 +0200
SubjectRe: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD
Message-ID<tCVXs-19m-3@gated-at.bofh.it>
In reply to#1633158
On Fri, 28 Apr 2017 14:00:19 -0700, Darren Hart (VMware) wrote:
> SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
> driver. Make this explicitly clear in the Kconfig depends.
> 
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Andy Shevchenko <andy@infradead.org>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/platform/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 9e5b2c2..5690664 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
>  
>  config SILEAD_DMI
>  	bool "Tablets with Silead touchscreens"
> -	depends on ACPI && DMI && I2C=y && INPUT
> +	depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
>  	---help---
>  	  Certain ACPI based tablets with Silead touchscreens do not have
>  	  enough data in ACPI tables for the touchscreen driver to handle

Reviewed-by: Jean Delvare <jdelvare@suse.de>

Thanks Darren,
-- 
Jean Delvare
SUSE L3 Support

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web