Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1634125 > unrolled thread

linux-next: manual merge of the drivers-x86 tree with the watchdog tree

Back to article view | Back to linux.kernel

Contents

  linux-next: manual merge of the drivers-x86 tree with the watchdog  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-02 06:10 +0200
    Re: linux-next: manual merge of the drivers-x86 tree with the  watchdog tree Darren Hart <dvhart@infradead.org> - 2017-05-02 20:10 +0200
      Re: linux-next: manual merge of the drivers-x86 tree with the  watchdog tree Guenter Roeck <linux@roeck-us.net> - 2017-05-02 21:20 +0200
        Re: linux-next: manual merge of the drivers-x86 tree with the  watchdog tree Darren Hart <dvhart@infradead.org> - 2017-05-02 22:30 +0200
          Re: linux-next: manual merge of the drivers-x86 tree with the  watchdog tree Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-02 23:00 +0200
            Re: linux-next: manual merge of the drivers-x86 tree with the  watchdog tree Darren Hart <dvhart@infradead.org> - 2017-05-02 23:40 +0200
              Re: linux-next: manual merge of the drivers-x86 tree with the  watchdog tree Guenter Roeck <linux@roeck-us.net> - 2017-05-03 00:00 +0200
                Re: linux-next: manual merge of the drivers-x86 tree with the  watchdog tree Darren Hart <dvhart@infradead.org> - 2017-05-03 00:40 +0200
                  Re: linux-next: manual merge of the drivers-x86 tree with the  watchdog tree Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-03 16:50 +0200
                  Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree Wim Van Sebroeck <wim@iguana.be> - 2017-05-03 17:00 +0200

#1634125 — linux-next: manual merge of the drivers-x86 tree with the watchdog tree

Hi all,

Today's linux-next merge of the drivers-x86 tree got a conflict in:

  drivers/watchdog/iTCO_wdt.c

between commit:

  38a700fa1df9 ("watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions")
(which also appears in the drivers-x86 tree as commit f583a884afec)

from the watchdog tree and commit:

  140c91b26ebc ("watchdog: iTCO_wdt: Add PMC specific noreboot update api")

from the drivers-x86 tree.

I fixed it up and can carry the fix as necessary. This is now fixed as
far as linux-next is concerned, but any non trivial conflicts should be
mentioned to your upstream maintainer when your tree is submitted for
merging.  You may also want to consider cooperating with the maintainer
of the conflicting tree to minimise any particularly complex conflicts.

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]

#1634562 — Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree

On Tue, May 02, 2017 at 02:04:03PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next merge of the drivers-x86 tree got a conflict in:
> 
>   drivers/watchdog/iTCO_wdt.c
> 
> between commit:
> 
>   38a700fa1df9 ("watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions")
> (which also appears in the drivers-x86 tree as commit f583a884afec)
> 

Andy and Guenter, I presume the two of you discussed how this patch would get
submitted as I see the following in the platform driver x86 for-next branch:

    Acked-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

for both:

140c91b2 watchdog: iTCO_wdt: Add PMC specific noreboot update api
f583a88 watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions

This suggests these were deliberately added to our tree and not accidentally
included through a rebase without --preserve-merges or something like that.

Guenter, if you prefer/need to submit this through your tree, can you provide
us with an immutable branch to merge for the dependencies of our later patches?
If you can drop these two patches without a dependency problem in your tree,
that would be the cleanest solution as we could avoid an additional merge.

Thanks,

Darren



> from the watchdog tree and commit:
> 
>   140c91b26ebc ("watchdog: iTCO_wdt: Add PMC specific noreboot update api")
> 
> from the drivers-x86 tree.
> 
> I fixed it up and can carry the fix as necessary. This is now fixed as
> far as linux-next is concerned, but any non trivial conflicts should be
> mentioned to your upstream maintainer when your tree is submitted for
> merging.  You may also want to consider cooperating with the maintainer
> of the conflicting tree to minimise any particularly complex conflicts.
> 
> -- 
> Cheers,
> Stephen Rothwell
> 

-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1634587 — Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree

On Tue, May 02, 2017 at 11:09:40AM -0700, Darren Hart wrote:
> On Tue, May 02, 2017 at 02:04:03PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Today's linux-next merge of the drivers-x86 tree got a conflict in:
> > 
> >   drivers/watchdog/iTCO_wdt.c
> > 
> > between commit:
> > 
> >   38a700fa1df9 ("watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions")
> > (which also appears in the drivers-x86 tree as commit f583a884afec)
> > 
> 
> Andy and Guenter, I presume the two of you discussed how this patch would get
> submitted as I see the following in the platform driver x86 for-next branch:
> 
>     Acked-by: Guenter Roeck <linux@roeck-us.net>
>     Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> for both:
> 
> 140c91b2 watchdog: iTCO_wdt: Add PMC specific noreboot update api
> f583a88 watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions
> 

I did not expect f583a88/38a700fa1df9 to show up in some other tree, sorry.
I don't recall discussing how to handle it either, though my memory may defeat
me. If so, my apologies.

> This suggests these were deliberately added to our tree and not accidentally
> included through a rebase without --preserve-merges or something like that.
> 
> Guenter, if you prefer/need to submit this through your tree, can you provide
> us with an immutable branch to merge for the dependencies of our later patches?
> If you can drop these two patches without a dependency problem in your tree,
> that would be the cleanest solution as we could avoid an additional merge.
> 

Please check with Wim.

Thanks,
Guenter

> Thanks,
> 
> Darren
> 
> 
> 
> > from the watchdog tree and commit:
> > 
> >   140c91b26ebc ("watchdog: iTCO_wdt: Add PMC specific noreboot update api")
> > 
> > from the drivers-x86 tree.
> > 
> > I fixed it up and can carry the fix as necessary. This is now fixed as
> > far as linux-next is concerned, but any non trivial conflicts should be
> > mentioned to your upstream maintainer when your tree is submitted for
> > merging.  You may also want to consider cooperating with the maintainer
> > of the conflicting tree to minimise any particularly complex conflicts.
> > 
> > -- 
> > Cheers,
> > Stephen Rothwell
> > 
> 
> -- 
> Darren Hart
> VMware Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1634610 — Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree

On Tue, May 02, 2017 at 12:12:17PM -0700, Guenter Roeck wrote:
> On Tue, May 02, 2017 at 11:09:40AM -0700, Darren Hart wrote:
> > On Tue, May 02, 2017 at 02:04:03PM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > Today's linux-next merge of the drivers-x86 tree got a conflict in:
> > > 
> > >   drivers/watchdog/iTCO_wdt.c
> > > 
> > > between commit:
> > > 
> > >   38a700fa1df9 ("watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions")
> > > (which also appears in the drivers-x86 tree as commit f583a884afec)
> > > 
> > 
> > Andy and Guenter, I presume the two of you discussed how this patch would get
> > submitted as I see the following in the platform driver x86 for-next branch:
> > 
> >     Acked-by: Guenter Roeck <linux@roeck-us.net>
> >     Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > 
> > for both:
> > 
> > 140c91b2 watchdog: iTCO_wdt: Add PMC specific noreboot update api
> > f583a88 watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions
> > 
> 
> I did not expect f583a88/38a700fa1df9 to show up in some other tree, sorry.
> I don't recall discussing how to handle it either, though my memory may defeat
> me. If so, my apologies.
> 
> > This suggests these were deliberately added to our tree and not accidentally
> > included through a rebase without --preserve-merges or something like that.
> > 
> > Guenter, if you prefer/need to submit this through your tree, can you provide
> > us with an immutable branch to merge for the dependencies of our later patches?
> > If you can drop these two patches without a dependency problem in your tree,
> > that would be the cleanest solution as we could avoid an additional merge.
> > 
> 
> Please check with Wim.

Thanks Guenter.

Wim, for context, this was a 6 patch series, with 4 patches to the platform
driver x86 tree and 2patches to the watchdog tree. The series was reviewed by
Guenter and Andy, and in v7 Andy replied that he had pushed the series to
testing (the testing branch of the platform driver x86 tree).

https://lkml.org/lkml/2017/4/25/666

From my perspective, the most direct solution would be to drop these two patches
from the watchdog tree and let them go through the platform driver x86 tree with
Guenter's Acked-by. If you have additional patches which depend on these two,
then if you will provide an immutable branch we can merge, we can do that too
(but I try to keep the number of external merges to a minimum - which is
becoming increasingly difficult lately for some reason).

Thanks,

-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1634620 — Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree

On Tue, May 2, 2017 at 11:21 PM, Darren Hart <dvhart@infradead.org> wrote:
> On Tue, May 02, 2017 at 12:12:17PM -0700, Guenter Roeck wrote:
>> On Tue, May 02, 2017 at 11:09:40AM -0700, Darren Hart wrote:
>> > On Tue, May 02, 2017 at 02:04:03PM +1000, Stephen Rothwell wrote:

> From my perspective, the most direct solution would be to drop these two patches
> from the watchdog tree and let them go through the platform driver x86 tree with
> Guenter's Acked-by. If you have additional patches which depend on these two,
> then if you will provide an immutable branch we can merge, we can do that too
> (but I try to keep the number of external merges to a minimum - which is
> becoming increasingly difficult lately for some reason).

Sorry for not being in doubt, I just decided that Ack from Guenter
means that default case is to go through PDx86 tree without any
additional agreement.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1634631 — Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree

On Tue, May 02, 2017 at 11:57:18PM +0300, Andy Shevchenko wrote:
> On Tue, May 2, 2017 at 11:21 PM, Darren Hart <dvhart@infradead.org> wrote:
> > On Tue, May 02, 2017 at 12:12:17PM -0700, Guenter Roeck wrote:
> >> On Tue, May 02, 2017 at 11:09:40AM -0700, Darren Hart wrote:
> >> > On Tue, May 02, 2017 at 02:04:03PM +1000, Stephen Rothwell wrote:
> 
> > From my perspective, the most direct solution would be to drop these two patches
> > from the watchdog tree and let them go through the platform driver x86 tree with
> > Guenter's Acked-by. If you have additional patches which depend on these two,
> > then if you will provide an immutable branch we can merge, we can do that too
> > (but I try to keep the number of external merges to a minimum - which is
> > becoming increasingly difficult lately for some reason).
> 
> Sorry for not being in doubt, I just decided that Ack from Guenter
> means that default case is to go through PDx86 tree without any
> additional agreement.

I assumed that was the case, yes. I read through the thread and would have
thought the same. As Guenter is directing us to Wim, I think the MAINTAINERS
file doesn't really capture the logistics of the watchdog maintainer model, as a
Reviewed-by from a listed maintainer wouldn't be typical unless they expected
someone else to merge it - in this case, I suppose Guenter meant Wim and not us
:-)

-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1634638 — Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree

On Tue, May 02, 2017 at 02:30:46PM -0700, Darren Hart wrote:
> On Tue, May 02, 2017 at 11:57:18PM +0300, Andy Shevchenko wrote:
> > On Tue, May 2, 2017 at 11:21 PM, Darren Hart <dvhart@infradead.org> wrote:
> > > On Tue, May 02, 2017 at 12:12:17PM -0700, Guenter Roeck wrote:
> > >> On Tue, May 02, 2017 at 11:09:40AM -0700, Darren Hart wrote:
> > >> > On Tue, May 02, 2017 at 02:04:03PM +1000, Stephen Rothwell wrote:
> > 
> > > From my perspective, the most direct solution would be to drop these two patches
> > > from the watchdog tree and let them go through the platform driver x86 tree with
> > > Guenter's Acked-by. If you have additional patches which depend on these two,
> > > then if you will provide an immutable branch we can merge, we can do that too
> > > (but I try to keep the number of external merges to a minimum - which is
> > > becoming increasingly difficult lately for some reason).
> > 
> > Sorry for not being in doubt, I just decided that Ack from Guenter
> > means that default case is to go through PDx86 tree without any
> > additional agreement.
> 
> I assumed that was the case, yes. I read through the thread and would have
> thought the same. As Guenter is directing us to Wim, I think the MAINTAINERS
> file doesn't really capture the logistics of the watchdog maintainer model, as a

Now I am confused. Please apologize my lack of understanding.

I am listed as "Reviewer", not "Maintainer", for watchdog drivers.
Please let me know how that does not capture the logistics of the watchdog
(or any other) maintainer model, and how to better reflect that I review
watchdog patches and Wim, as maintainer, sends them to Linus. I thought that
is what "R:" and "M:" is for ?

The only possibly unusual detail is that I maintain a branch with all patches
I have reviewed. This branch is picked up by Wim and either accepted as-is or,
if he does not agree with some patch, modified accordingly. This branch is
not in linux-next and thus not part of any official maintainer model,
but exists for convenience and to enable additional testing through 0day
and my own test farm.

> Reviewed-by from a listed maintainer wouldn't be typical unless they expected
> someone else to merge it - in this case, I suppose Guenter meant Wim and not us
> :-)
> 

You are correct, "Reviewed-by:" typically is intended for Wim, as I thought
it would be expected for a designated reviewer. I tend to use "Acked-by:"
if I assume or expect that a patch will be picked up by a different maintainer,
though I typically add a note saying that this is the case (no idea if I did
that here). Is there some different set of tags I should use ?

On a side note, it appears that I tagged "watchdog: iTCO_wdt: cleanup
set/unset no_reboot_bit functions" with "Reviewed-by:", not with "Acked-by:".

Thanks,
Guenter

[toc] | [prev] | [next] | [standalone]

#1634657 — Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree

On Tue, May 02, 2017 at 02:58:22PM -0700, Guenter Roeck wrote:
> On Tue, May 02, 2017 at 02:30:46PM -0700, Darren Hart wrote:
> > On Tue, May 02, 2017 at 11:57:18PM +0300, Andy Shevchenko wrote:
> > > On Tue, May 2, 2017 at 11:21 PM, Darren Hart <dvhart@infradead.org> wrote:
> > > > On Tue, May 02, 2017 at 12:12:17PM -0700, Guenter Roeck wrote:
> > > >> On Tue, May 02, 2017 at 11:09:40AM -0700, Darren Hart wrote:
> > > >> > On Tue, May 02, 2017 at 02:04:03PM +1000, Stephen Rothwell wrote:
> > > 
> > > > From my perspective, the most direct solution would be to drop these two patches
> > > > from the watchdog tree and let them go through the platform driver x86 tree with
> > > > Guenter's Acked-by. If you have additional patches which depend on these two,
> > > > then if you will provide an immutable branch we can merge, we can do that too
> > > > (but I try to keep the number of external merges to a minimum - which is
> > > > becoming increasingly difficult lately for some reason).
> > > 
> > > Sorry for not being in doubt, I just decided that Ack from Guenter
> > > means that default case is to go through PDx86 tree without any
> > > additional agreement.
> > 
> > I assumed that was the case, yes. I read through the thread and would have
> > thought the same. As Guenter is directing us to Wim, I think the MAINTAINERS
> > file doesn't really capture the logistics of the watchdog maintainer model, as a
> 
> Now I am confused. Please apologize my lack of understanding.
> 
> I am listed as "Reviewer", not "Maintainer", for watchdog drivers.

:facepalm:

Yes you are, I misread the get_maintainer.pl output ... somehow.

> Please let me know how that does not capture the logistics of the watchdog
> (or any other) maintainer model, and how to better reflect that I review
> watchdog patches and Wim, as maintainer, sends them to Linus. I thought that
> is what "R:" and "M:" is for ?

Nope, it's right, I messed up.

> 
> The only possibly unusual detail is that I maintain a branch with all patches
> I have reviewed. This branch is picked up by Wim and either accepted as-is or,
> if he does not agree with some patch, modified accordingly. This branch is
> not in linux-next and thus not part of any official maintainer model,
> but exists for convenience and to enable additional testing through 0day
> and my own test farm.
> 
> > Reviewed-by from a listed maintainer wouldn't be typical unless they expected
> > someone else to merge it - in this case, I suppose Guenter meant Wim and not us
> > :-)
> > 
> 
> You are correct, "Reviewed-by:" typically is intended for Wim, as I thought
> it would be expected for a designated reviewer. I tend to use "Acked-by:"
> if I assume or expect that a patch will be picked up by a different maintainer,
> though I typically add a note saying that this is the case (no idea if I did
> that here). Is there some different set of tags I should use ?

Nope, we just should have confirmed with Wim.

> On a side note, it appears that I tagged "watchdog: iTCO_wdt: cleanup
> set/unset no_reboot_bit functions" with "Reviewed-by:", not with "Acked-by:".

I noticed this as well. If Wim drops these, we'll correct that in our branch.

-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [prev] | [next] | [standalone]

#1635044 — Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree

On Wed, May 3, 2017 at 5:24 PM, Wim Van Sebroeck <wim@iguana.be> wrote:
>> On Tue, May 02, 2017 at 02:58:22PM -0700, Guenter Roeck wrote:
>> > On Tue, May 02, 2017 at 02:30:46PM -0700, Darren Hart wrote:

>> > On a side note, it appears that I tagged "watchdog: iTCO_wdt: cleanup
>> > set/unset no_reboot_bit functions" with "Reviewed-by:", not with "Acked-by:".
>>
>> I noticed this as well. If Wim drops these, we'll correct that in our branch.
>
> It makes sence to keep the patches together. I will drop the patches from the watchdog tree.

Thanks, Wim.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1635047 — Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree

Hi All,

> On Tue, May 02, 2017 at 02:58:22PM -0700, Guenter Roeck wrote:
> > On Tue, May 02, 2017 at 02:30:46PM -0700, Darren Hart wrote:
> > > On Tue, May 02, 2017 at 11:57:18PM +0300, Andy Shevchenko wrote:
> > > > On Tue, May 2, 2017 at 11:21 PM, Darren Hart <dvhart@infradead.org> wrote:
> > > > > On Tue, May 02, 2017 at 12:12:17PM -0700, Guenter Roeck wrote:
> > > > >> On Tue, May 02, 2017 at 11:09:40AM -0700, Darren Hart wrote:
> > > > >> > On Tue, May 02, 2017 at 02:04:03PM +1000, Stephen Rothwell wrote:
> > > > 
> > > > > From my perspective, the most direct solution would be to drop these two patches
> > > > > from the watchdog tree and let them go through the platform driver x86 tree with
> > > > > Guenter's Acked-by. If you have additional patches which depend on these two,
> > > > > then if you will provide an immutable branch we can merge, we can do that too
> > > > > (but I try to keep the number of external merges to a minimum - which is
> > > > > becoming increasingly difficult lately for some reason).
> > > > 
> > > > Sorry for not being in doubt, I just decided that Ack from Guenter
> > > > means that default case is to go through PDx86 tree without any
> > > > additional agreement.
> > > 
> > > I assumed that was the case, yes. I read through the thread and would have
> > > thought the same. As Guenter is directing us to Wim, I think the MAINTAINERS
> > > file doesn't really capture the logistics of the watchdog maintainer model, as a
> > 
> > Now I am confused. Please apologize my lack of understanding.
> > 
> > I am listed as "Reviewer", not "Maintainer", for watchdog drivers.
> 
> :facepalm:
> 
> Yes you are, I misread the get_maintainer.pl output ... somehow.
> 
> > Please let me know how that does not capture the logistics of the watchdog
> > (or any other) maintainer model, and how to better reflect that I review
> > watchdog patches and Wim, as maintainer, sends them to Linus. I thought that
> > is what "R:" and "M:" is for ?
> 
> Nope, it's right, I messed up.
> 
> > 
> > The only possibly unusual detail is that I maintain a branch with all patches
> > I have reviewed. This branch is picked up by Wim and either accepted as-is or,
> > if he does not agree with some patch, modified accordingly. This branch is
> > not in linux-next and thus not part of any official maintainer model,
> > but exists for convenience and to enable additional testing through 0day
> > and my own test farm.
> > 
> > > Reviewed-by from a listed maintainer wouldn't be typical unless they expected
> > > someone else to merge it - in this case, I suppose Guenter meant Wim and not us
> > > :-)
> > > 
> > 
> > You are correct, "Reviewed-by:" typically is intended for Wim, as I thought
> > it would be expected for a designated reviewer. I tend to use "Acked-by:"
> > if I assume or expect that a patch will be picked up by a different maintainer,
> > though I typically add a note saying that this is the case (no idea if I did
> > that here). Is there some different set of tags I should use ?
> 
> Nope, we just should have confirmed with Wim.
> 
> > On a side note, it appears that I tagged "watchdog: iTCO_wdt: cleanup
> > set/unset no_reboot_bit functions" with "Reviewed-by:", not with "Acked-by:".
> 
> I noticed this as well. If Wim drops these, we'll correct that in our branch.

It makes sence to keep the patches together. I will drop the patches from the watchdog tree.

Kind regards,
Wim.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web