Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1634498 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-05-02 18:10 +0200 |
| Last post | 2017-05-02 20:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] usb: host: remove unnecessary null check "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-02 18:10 +0200
Re: [PATCH] usb: host: remove unnecessary null check Alan Stern <stern@rowland.harvard.edu> - 2017-05-02 20:30 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-05-02 18:10 +0200 |
| Subject | [PATCH] usb: host: remove unnecessary null check |
| Message-ID | <tCIxc-wA-11@gated-at.bofh.it> |
Remove unnecessary null check. udev->tt cannot ever be NULL when this section of code runs. Addresses-Coverity-ID: 100828 Cc: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- drivers/usb/host/ehci-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c index 980a6b3..6bc6304 100644 --- a/drivers/usb/host/ehci-sched.c +++ b/drivers/usb/host/ehci-sched.c @@ -1105,7 +1105,7 @@ iso_stream_init( addr |= epnum << 8; addr |= dev->devnum; stream->ps.usecs = HS_USECS_ISO(maxp); - think_time = dev->tt ? dev->tt->think_time : 0; + think_time = dev->tt->think_time; stream->ps.tt_usecs = NS_TO_US(think_time + usb_calc_bus_time( dev->speed, is_input, 1, maxp)); hs_transfers = max(1u, (maxp + 187) / 188); -- 2.5.0
[toc] | [next] | [standalone]
| From | Alan Stern <stern@rowland.harvard.edu> |
|---|---|
| Date | 2017-05-02 20:30 +0200 |
| Message-ID | <tCKIF-1NJ-1@gated-at.bofh.it> |
| In reply to | #1634498 |
On Tue, 2 May 2017, Gustavo A. R. Silva wrote: > Remove unnecessary null check. udev->tt cannot ever be NULL when this > section of code runs. > > Addresses-Coverity-ID: 100828 > Cc: Alan Stern <stern@rowland.harvard.edu> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > --- > drivers/usb/host/ehci-sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c > index 980a6b3..6bc6304 100644 > --- a/drivers/usb/host/ehci-sched.c > +++ b/drivers/usb/host/ehci-sched.c > @@ -1105,7 +1105,7 @@ iso_stream_init( > addr |= epnum << 8; > addr |= dev->devnum; > stream->ps.usecs = HS_USECS_ISO(maxp); > - think_time = dev->tt ? dev->tt->think_time : 0; > + think_time = dev->tt->think_time; > stream->ps.tt_usecs = NS_TO_US(think_time + usb_calc_bus_time( > dev->speed, is_input, 1, maxp)); > hs_transfers = max(1u, (maxp + 187) / 188); Acked-by: Alan Stern <stern@rowland.harvard.edu>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web