Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1632896 > unrolled thread
| Started by | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| First post | 2017-04-28 15:40 +0200 |
| Last post | 2017-05-03 17:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 06/14] sched/topology,debug: Verify the first group matches the child domain Peter Zijlstra <peterz@infradead.org> - 2017-04-28 15:40 +0200
Re: [PATCH 06/14] sched/topology,debug: Verify the first group matches the child domain Rik van Riel <riel@redhat.com> - 2017-05-01 23:20 +0200
Re: [PATCH 06/14] sched/topology,debug: Verify the first group matches the child domain Peter Zijlstra <peterz@infradead.org> - 2017-05-02 17:00 +0200
Re: [PATCH 06/14] sched/topology,debug: Verify the first group matches the child domain Rik van Riel <riel@redhat.com> - 2017-05-03 17:10 +0200
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2017-04-28 15:40 +0200 |
| Subject | [PATCH 06/14] sched/topology,debug: Verify the first group matches the child domain |
| Message-ID | <tBehR-7VW-55@gated-at.bofh.it> |
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
kernel/sched/topology.c | 6 ++++++
1 file changed, 6 insertions(+)
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -93,6 +93,12 @@ static int sched_domain_debug_one(struct
group->sgc->capacity);
}
+ if (group == sd->groups && sd->child &&
+ !cpumask_equal(sched_domain_span(sd->child),
+ sched_group_cpus(group))) {
+ printk(KERN_ERR "ERROR: domain->groups does not match domain->child\n");
+ }
+
group = group->next;
if (group != sd->groups)
[toc] | [next] | [standalone]
| From | Rik van Riel <riel@redhat.com> |
|---|---|
| Date | 2017-05-01 23:20 +0200 |
| Subject | Re: [PATCH 06/14] sched/topology,debug: Verify the first group matches the child domain |
| Message-ID | <tCqTD-5JW-7@gated-at.bofh.it> |
| In reply to | #1632896 |
On Fri, 2017-04-28 at 15:20 +0200, Peter Zijlstra wrote: > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> This could use a changelog.
[toc] | [prev] | [next] | [standalone]
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2017-05-02 17:00 +0200 |
| Subject | Re: [PATCH 06/14] sched/topology,debug: Verify the first group matches the child domain |
| Message-ID | <tCHrs-7Ws-17@gated-at.bofh.it> |
| In reply to | #1633864 |
On Mon, May 01, 2017 at 05:13:26PM -0400, Rik van Riel wrote:
> On Fri, 2017-04-28 at 15:20 +0200, Peter Zijlstra wrote:
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>
> This could use a changelog.
Yes indeed... I put off writing one because $hard, and clearly I forgot
entirely :-/
How's this?
---
Subject: sched/topology,debug: Verify the first group matches the child domain
From: Peter Zijlstra <peterz@infradead.org>
Date: Fri Apr 14 18:20:48 CEST 2017
We want sched_groups to be sibling child domains (or individual CPUs
when there are no child domains). Furthermore, since the first group
of a domain should include the CPU of that domain, the first group of
each domain should match the child domain.
Verify this is indeed so.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
kernel/sched/topology.c | 6 ++++++
1 file changed, 6 insertions(+)
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -93,6 +93,12 @@ static int sched_domain_debug_one(struct
group->sgc->capacity);
}
+ if (group == sd->groups && sd->child &&
+ !cpumask_equal(sched_domain_span(sd->child),
+ sched_group_cpus(group))) {
+ printk(KERN_ERR "ERROR: domain->groups does not match domain->child\n");
+ }
+
group = group->next;
if (group != sd->groups)
[toc] | [prev] | [next] | [standalone]
| From | Rik van Riel <riel@redhat.com> |
|---|---|
| Date | 2017-05-03 17:10 +0200 |
| Subject | Re: [PATCH 06/14] sched/topology,debug: Verify the first group matches the child domain |
| Message-ID | <tD44G-73B-11@gated-at.bofh.it> |
| In reply to | #1634470 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, 2017-05-02 at 16:52 +0200, Peter Zijlstra wrote: > On Mon, May 01, 2017 at 05:13:26PM -0400, Rik van Riel wrote: > > On Fri, 2017-04-28 at 15:20 +0200, Peter Zijlstra wrote: > > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > > > > This could use a changelog. > > Yes indeed... I put off writing one because $hard, and clearly I > forgot > entirely :-/ > > How's this? Looks good to me. > --- > Subject: sched/topology,debug: Verify the first group matches the > child domain > From: Peter Zijlstra <peterz@infradead.org> > Date: Fri Apr 14 18:20:48 CEST 2017 > > We want sched_groups to be sibling child domains (or individual CPUs > when there are no child domains). Furthermore, since the first group > of a domain should include the CPU of that domain, the first group of > each domain should match the child domain. > > Verify this is indeed so. > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > Acked-by: Rik van Riel <riel@redhat.com> -- All rights reversed
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web