Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1633308 > unrolled thread
| Started by | Stuart Yoder <stuyoder@gmail.com> |
|---|---|
| First post | 2017-04-29 18:40 +0200 |
| Last post | 2017-04-30 07:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd Stuart Yoder <stuyoder@gmail.com> - 2017-04-29 18:40 +0200
Re: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd Horia Geantă <horia.geanta@nxp.com> - 2017-04-29 19:20 +0200
Re: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-30 07:30 +0200
| From | Stuart Yoder <stuyoder@gmail.com> |
|---|---|
| Date | 2017-04-29 18:40 +0200 |
| Subject | Re: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd |
| Message-ID | <tBDzz-8w-1@gated-at.bofh.it> |
On Fri, Apr 28, 2017 at 9:38 AM, Horia Geantă <horia.geanta@nxp.com> wrote:
>
> While dpaa2_fd.simple structure fields are marked __leXX,
> corresponding cpu_to_leXX / leXX_to_cpu conversions are missing.
>
> While here, fix dpaa2_fd_{get,set}_bpid such that BMT, IVP bits
> sharing the 16-bit field with BPID are not affected.
Please split this into 2 separate patches. Don't fix other misc things "while
you are at it" in the same patch.
Thanks,
Stuart
[toc] | [next] | [standalone]
| From | Horia Geantă <horia.geanta@nxp.com> |
|---|---|
| Date | 2017-04-29 19:20 +0200 |
| Subject | Re: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd |
| Message-ID | <tBEci-Ax-5@gated-at.bofh.it> |
| In reply to | #1633308 |
On 4/29/2017 7:32 PM, Stuart Yoder wrote:
> On Fri, Apr 28, 2017 at 9:38 AM, Horia Geantă <horia.geanta@nxp.com> wrote:
>>
>> While dpaa2_fd.simple structure fields are marked __leXX,
>> corresponding cpu_to_leXX / leXX_to_cpu conversions are missing.
>>
>> While here, fix dpaa2_fd_{get,set}_bpid such that BMT, IVP bits
>> sharing the 16-bit field with BPID are not affected.
>
> Please split this into 2 separate patches. Don't fix other misc things "while
> you are at it" in the same patch.
>
I thought that having 2 issues on the same line would allow for this
approach.
Now that the patch is in staging-next, I am not sure what I am supposed
to do.
Thanks,
Horia
[toc] | [prev] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-04-30 07:30 +0200 |
| Subject | Re: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd |
| Message-ID | <tBPAJ-7C7-15@gated-at.bofh.it> |
| In reply to | #1633313 |
On Sat, Apr 29, 2017 at 05:18:04PM +0000, Horia Geantă wrote:
> On 4/29/2017 7:32 PM, Stuart Yoder wrote:
> > On Fri, Apr 28, 2017 at 9:38 AM, Horia Geantă <horia.geanta@nxp.com> wrote:
> >>
> >> While dpaa2_fd.simple structure fields are marked __leXX,
> >> corresponding cpu_to_leXX / leXX_to_cpu conversions are missing.
> >>
> >> While here, fix dpaa2_fd_{get,set}_bpid such that BMT, IVP bits
> >> sharing the 16-bit field with BPID are not affected.
> >
> > Please split this into 2 separate patches. Don't fix other misc things "while
> > you are at it" in the same patch.
> >
> I thought that having 2 issues on the same line would allow for this
> approach.
>
> Now that the patch is in staging-next, I am not sure what I am supposed
> to do.
It's non-rebase tree. Nothing to do.
regards,
dan carpenter
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web