Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1630520 > unrolled thread

Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow  Makefiles to override clean Shuah Khan <shuahkh@osg.samsung.com> - 2017-04-25 15:40 +0200
    Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean Michael Ellerman <mpe@ellerman.id.au> - 2017-04-26 13:00 +0200

#1630520 — Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean

On 04/21/2017 11:38 PM, Michael Ellerman wrote:
> Shuah Khan <shuahkh@osg.samsung.com> writes:
> 
>> Define CLEAN macro to allow Makefiles to override common clean target
>> in lib.mk. This will help fix the following failures:
>>
>> warning: overriding recipe for target 'clean'
>> ../lib.mk:55: warning: ignoring old recipe for target 'clean'
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> 
> Should probably have:
> 
> Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target")

Amended the change log to add the above.

> 
> 
> In hindsight I'm not sure moving the clean target into lib.mk was
> the best idea, but anyway it's a bit late to change our mind on that.

Yeah. Moving clean target to lib.mk ended up to be problematic. However,
there are some advantages as well. It will simplify some Makefiles. One
thing that was missed was that not finding the Makefiles that require
overrides. Anyway live and learn.

> 
> This patch is a good solution to fix the warnings.
> 
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
> 

Thanks. I plan to apply the patch with the amended changelog and your
Ack. Please let me know if you want to see v2 with the change sent out.

thanks,
-- Shuah

[toc] | [next] | [standalone]

#1631400 — Re: [PATCH 2/8] selftests: lib.mk: define CLEAN macro to allow Makefiles to override clean

Shuah Khan <shuahkh@osg.samsung.com> writes:
> On 04/21/2017 11:38 PM, Michael Ellerman wrote:
>> Shuah Khan <shuahkh@osg.samsung.com> writes:

>> This patch is a good solution to fix the warnings.
>> 
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Thanks. I plan to apply the patch with the amended changelog and your
> Ack. Please let me know if you want to see v2 with the change sent out.

I don't really mind if you send it or not.

cheers

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web